Skip to content

chore: use the new CopyTraceID helper in more places#45061

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
mainfrom
aleksandr.pasechnik/use-new-helpers-in-more-places
Jan 22, 2026
Merged

chore: use the new CopyTraceID helper in more places#45061
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
mainfrom
aleksandr.pasechnik/use-new-helpers-in-more-places

Conversation

@apiarian-datadog

@apiarian-datadog apiarian-datadog commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Use the helpers added in #44727 in more places.

Motivation

Set up good patterns for the future.

Describe how you validated your changes

Automated tests.

@apiarian-datadog
apiarian-datadog requested a review from a team as a code owner January 13, 2026 19:59
@github-actions github-actions Bot added team/agent-apm trace-agent medium review PR review might take time labels Jan 13, 2026
@apiarian-datadog apiarian-datadog added the changelog/no-changelog No changelog entry needed label Jan 13, 2026
@cit-pr-commenter

cit-pr-commenter Bot commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: fa7029fd-e950-4d2e-bafb-a9f4a6cfd7b2

Baseline: 4406c82
Comparison: 4645d78
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +0.47 [-2.49, +3.44] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +0.47 [-2.49, +3.44] 1 Logs
➖ ddot_metrics memory utilization +0.45 [+0.22, +0.68] 1 Logs
➖ ddot_logs memory utilization +0.28 [+0.21, +0.35] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.14 [-0.02, +0.29] 1 Logs
➖ quality_gate_idle memory utilization +0.08 [+0.04, +0.13] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.07 [+0.01, +0.12] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.05 [-0.48, +0.58] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.12, +0.14] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.01 [-0.39, +0.40] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.43, +0.42] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.10, +0.09] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.13, +0.11] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.05 [-0.09, -0.01] 1 Logs
➖ file_tree memory utilization -0.06 [-0.11, -0.01] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.06 [-0.22, +0.10] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.06 [-0.16, +0.03] 1 Logs
➖ otlp_ingest_logs memory utilization -0.07 [-0.16, +0.02] 1 Logs
➖ ddot_metrics_sum_delta memory utilization -0.10 [-0.30, +0.10] 1 Logs
➖ quality_gate_metrics_logs memory utilization -0.19 [-0.40, +0.02] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization -0.20 [-1.66, +1.27] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization -0.35 [-0.39, -0.31] 1 Logs bounds checks dashboard
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.44 [-0.67, -0.21] 1 Logs
➖ docker_containers_memory memory utilization -0.48 [-0.55, -0.41] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency lost_bytes 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
❌ quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (target internal profiling)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 11 (x4) Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 11 (x3) Oom killed Debug Dashboard

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b914841
📊 Static Quality Gates Dashboard

Error

Quality gate Change Size (prev → curr → max)
⚠️ agent_msi neutral 572.096 MiB
Gate failure full details
Quality gate Error type Error message
agent_msi StaticQualityGateFailed (non-blocking: size unchanged from ancestor) �[91mstatic_quality_gate_agent_msi failed!
Wire size 143.1 MB exceeds limit of 143.0 MB by 55.5 KB�[0m

Note: Some gates exceeded limits but are non-blocking because the size hasn't increased from the ancestor commit.

Successful checks

Info

Quality gate Change Size (prev → curr → max)
✅ agent_rpm_arm64_fips +4.0 KiB (0.00% increase) 682.363 → 682.367 → 688.480
✅ agent_suse_arm64_fips +4.0 KiB (0.00% increase) 682.363 → 682.367 → 688.480
28 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 704.921 MiB
✅ agent_deb_amd64_fips 700.198 MiB
✅ agent_heroku_amd64 327.192 MiB
✅ agent_rpm_amd64 704.907 MiB
✅ agent_rpm_amd64_fips 700.185 MiB
✅ agent_rpm_arm64 686.269 MiB
✅ agent_suse_amd64 704.907 MiB
✅ agent_suse_amd64_fips 700.185 MiB
✅ agent_suse_arm64 686.269 MiB
✅ docker_agent_amd64 767.048 MiB
✅ docker_agent_arm64 772.977 MiB
✅ docker_agent_jmx_amd64 957.927 MiB
✅ docker_agent_jmx_arm64 952.575 MiB
✅ docker_cluster_agent_amd64 180.769 MiB
✅ docker_cluster_agent_arm64 196.603 MiB
✅ docker_cws_instrumentation_amd64 7.135 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_amd64 38.863 MiB
✅ docker_dogstatsd_arm64 37.128 MiB
✅ dogstatsd_deb_amd64 30.082 MiB
✅ dogstatsd_deb_arm64 28.223 MiB
✅ dogstatsd_rpm_amd64 30.082 MiB
✅ dogstatsd_suse_amd64 30.082 MiB
✅ iot_agent_deb_amd64 43.163 MiB
✅ iot_agent_deb_arm64 40.268 MiB
✅ iot_agent_deb_armhf 40.857 MiB
✅ iot_agent_rpm_amd64 43.163 MiB
✅ iot_agent_suse_amd64 43.163 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
⚠️ agent_msi +8.0 KiB (0.01% increase) 143.066 → 143.074 → 143.020
✅ agent_deb_amd64 -9.28 KiB (0.01% reduction) 173.384 → 173.375 → 174.490
✅ agent_deb_amd64_fips +19.34 KiB (0.01% increase) 172.325 → 172.344 → 173.750
✅ agent_heroku_amd64 neutral 87.171 MiB
✅ agent_rpm_amd64 -20.82 KiB (0.01% reduction) 176.423 → 176.402 → 177.660
✅ agent_rpm_amd64_fips -7.81 KiB (0.00% reduction) 174.949 → 174.941 → 176.600
✅ agent_rpm_arm64 -12.75 KiB (0.01% reduction) 159.464 → 159.452 → 161.260
✅ agent_rpm_arm64_fips -7.27 KiB (0.00% reduction) 158.929 → 158.922 → 160.550
✅ agent_suse_amd64 -20.82 KiB (0.01% reduction) 176.423 → 176.402 → 177.660
✅ agent_suse_amd64_fips -7.81 KiB (0.00% reduction) 174.949 → 174.941 → 176.600
✅ agent_suse_arm64 -12.75 KiB (0.01% reduction) 159.464 → 159.452 → 161.260
✅ agent_suse_arm64_fips -7.27 KiB (0.00% reduction) 158.929 → 158.922 → 160.550
✅ docker_agent_amd64 neutral 260.984 MiB
✅ docker_agent_arm64 neutral 249.978 MiB
✅ docker_agent_jmx_amd64 neutral 329.623 MiB
✅ docker_agent_jmx_arm64 neutral 314.598 MiB
✅ docker_cluster_agent_amd64 neutral 63.876 MiB
✅ docker_cluster_agent_arm64 neutral 60.147 MiB
✅ docker_cws_instrumentation_amd64 neutral 2.995 MiB
✅ docker_cws_instrumentation_arm64 neutral 2.726 MiB
✅ docker_dogstatsd_amd64 neutral 15.043 MiB
✅ docker_dogstatsd_arm64 neutral 14.364 MiB
✅ dogstatsd_deb_amd64 neutral 7.958 MiB
✅ dogstatsd_deb_arm64 neutral 6.832 MiB
✅ dogstatsd_rpm_amd64 neutral 7.968 MiB
✅ dogstatsd_suse_amd64 neutral 7.968 MiB
✅ iot_agent_deb_amd64 +5.07 KiB (0.04% increase) 11.306 → 11.311 → 12.040
✅ iot_agent_deb_arm64 neutral 9.665 MiB
✅ iot_agent_deb_armhf neutral 9.870 MiB
✅ iot_agent_rpm_amd64 neutral 11.326 MiB
✅ iot_agent_suse_amd64 neutral 11.326 MiB

@apiarian-datadog
apiarian-datadog force-pushed the aleksandr.pasechnik/use-new-helpers-in-more-places branch 2 times, most recently from de4fc72 to 8c08068 Compare January 15, 2026 15:23
@github-actions github-actions Bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Jan 15, 2026
@apiarian-datadog
apiarian-datadog force-pushed the aleksandr.pasechnik/use-new-helpers-in-more-places branch from 8c08068 to 799fe32 Compare January 15, 2026 21:19
@github-actions github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 15, 2026
@apiarian-datadog
apiarian-datadog force-pushed the aleksandr.pasechnik/use-new-helpers-in-more-places branch from 799fe32 to 4645d78 Compare January 16, 2026 16:59
@apiarian-datadog
apiarian-datadog requested a review from a team as a code owner January 16, 2026 16:59
@lucaspimentel

lucaspimentel commented Jan 16, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jan 16, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lucaspimentel
lucaspimentel reviewed Jan 16, 2026
View reviewed changes
Comment thread pkg/trace/traceutil/span.go Outdated
lucaspimentel
lucaspimentel reviewed Jan 16, 2026
View reviewed changes
Comment thread pkg/trace/agent/normalizer_test.go
@apiarian-datadog
apiarian-datadog force-pushed the aleksandr.pasechnik/use-new-helpers-in-more-places branch from 4645d78 to a05ba38 Compare January 20, 2026 16:52
@apiarian-datadog apiarian-datadog added the qa/done QA done before merge and regressions are covered by tests label Jan 22, 2026
@apiarian-datadog

apiarian-datadog commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-01-22 14:47:43 UTC ℹ️ Start processing command /merge

2026-01-22 14:48:21 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2026-01-22 15:24:58 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 2958846 into main Jan 22, 2026
350 of 351 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the aleksandr.pasechnik/use-new-helpers-in-more-places branch January 22, 2026 15:24
@github-actions github-actions Bot added this to the 7.76.0 milestone Jan 22, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes
@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes
@Lewis-E Lewis-E Lewis-E approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-apm trace-agent

Projects

None yet

Milestone

7.76.0

Development

Successfully merging this pull request may close these issues.

4 participants

@apiarian-datadog @lucaspimentel @ajgajg1134 @Lewis-E