Make Azure Container App tags independent of cloudservice Init by Lewis-E · Pull Request #44414 · DataDog/datadog-agent

Lewis-E · 2025-12-18T16:17:20Z

What does this PR do?

Handles regression of ACA tags in 1.9.0
containerapp tags now generated without a dependency on Init, consistent with other cloud provider GetTags

Motivation

Bugfix

Describe how you validated your changes

New unit test
test in containerapp self-monitoring

Before:

After:

Lewis-E · 2025-12-18T16:18:26Z

@@ -14,33 +14,6 @@ import (
 )

 func TestGetContainerAppTags(t *testing.T) {


Merged this test with TestGetContainerAppTagsWithOptionalEnvVars as the change makes them identical

apiarian-datadog · 2025-12-18T16:28:00Z

+	// Check ContainerApp struct first, then fall back to environment variables
+	subscriptionID := c.SubscriptionId
+	if subscriptionID == "" {
+		subscriptionID = os.Getenv(AzureSubscriptionIdEnvVar)


when we load the env var in the init method, we do so with a fatal crash on the env var missing. is that functionality we should replicate here? would it make sense to pull the subscription/resource loading into a helper function we use in both places?

I was going to follow up this quick fix with another MR to see if we could move Init back to the top by moving the span functionality around, which would get us the panics in the expected place. I think it's really much more intuitive to have the cloud service init at the top of main, rather than have a panic in multiple places. I just also would want to test that one more since it'll change tracing functionality, so for speed: this.

agent-platform-auto-pr · 2025-12-18T16:51:27Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 930cdf1

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${705.42}$$ < $${707.13}$$	$${+0.04}$$	$${173.02}$$ < $${174.16}$$
✅	agent_deb_amd64_fips	$${0}$$	$${701.64}$$ < $${702.86}$$	$${-0.01}$$	$${172.23}$$ < $${173.5}$$
✅	agent_heroku_amd64	$${0}$$	$${327.72}$$ < $${327.92}$$	$${-0}$$	$${87.16}$$ < $${88.21}$$
✅	agent_msi	$${0}$$	$${571.12}$$ < $${982.08}$$	$${-0.03}$$	$${142.65}$$ < $${143.49}$$
✅	agent_rpm_amd64	$${0}$$	$${705.4}$$ < $${707.12}$$	$${-0}$$	$${176.1}$$ < $${177.29}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${701.63}$$ < $${702.85}$$	$${-0}$$	$${175.08}$$ < $${176.32}$$
✅	agent_rpm_arm64	$${0}$$	$${687.27}$$ < $${691.67}$$	$${+0}$$	$${159.07}$$ < $${160.7}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${684.33}$$ < $${687.54}$$	$${-0.04}$$	$${158.76}$$ < $${160.11}$$
✅	agent_suse_amd64	$${0}$$	$${705.4}$$ < $${707.12}$$	$${-0}$$	$${176.1}$$ < $${177.29}$$
✅	agent_suse_amd64_fips	$${0}$$	$${701.63}$$ < $${702.85}$$	$${-0}$$	$${175.08}$$ < $${176.32}$$
✅	agent_suse_arm64	$${0}$$	$${687.27}$$ < $${691.67}$$	$${+0}$$	$${159.07}$$ < $${160.7}$$
✅	agent_suse_arm64_fips	$${0}$$	$${684.33}$$ < $${687.54}$$	$${-0.04}$$	$${158.76}$$ < $${160.11}$$
✅	docker_agent_amd64	$${0}$$	$${767.2}$$ < $${769.38}$$	$${+0}$$	$${260.52}$$ < $${262.06}$$
✅	docker_agent_arm64	$${-0}$$	$${773.64}$$ < $${778.35}$$	$${-0}$$	$${249.6}$$ < $${251.72}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${958.08}$$ < $${960.26}$$	$${+0}$$	$${329.16}$$ < $${330.69}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${953.24}$$ < $${957.95}$$	$${-0}$$	$${314.24}$$ < $${316.35}$$
✅	docker_cluster_agent_amd64	$${0}$$	$${180.33}$$ < $${181.08}$$	$${+0}$$	$${63.71}$$ < $${64.49}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${196.19}$$ < $${198.49}$$	$${-0}$$	$${60.0}$$ < $${61.17}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.13}$$ < $${7.18}$$	$${+0}$$	$${2.99}$$ < $${3.33}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${-0}$$	$${2.73}$$ < $${3.09}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.76}$$ < $${39.38}$$	$${-0}$$	$${15.0}$$ < $${15.82}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.06}$$ < $${37.94}$$	$${+0}$$	$${14.33}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.98}$$ < $${30.61}$$	$${+0}$$	$${7.93}$$ < $${8.79}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.14}$$ < $${29.11}$$	$${+0}$$	$${6.81}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.98}$$ < $${30.61}$$	$${+0}$$	$${7.94}$$ < $${8.8}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.98}$$ < $${30.61}$$	$${+0}$$	$${7.94}$$ < $${8.8}$$
✅	iot_agent_deb_amd64	$${0}$$	$${42.92}$$ < $${43.29}$$	$${+0}$$	$${11.24}$$ < $${12.04}$$
✅	iot_agent_deb_arm64	$${0}$$	$${40.05}$$ < $${40.92}$$	$${-0}$$	$${9.61}$$ < $${10.45}$$
✅	iot_agent_deb_armhf	$${0}$$	$${40.63}$$ < $${41.03}$$	$${-0}$$	$${9.8}$$ < $${10.62}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${42.92}$$ < $${43.29}$$	$${-0}$$	$${11.25}$$ < $${12.06}$$
✅	iot_agent_suse_amd64	$${0}$$	$${42.92}$$ < $${43.29}$$	$${-0}$$	$${11.25}$$ < $${12.06}$$

cit-pr-commenter · 2025-12-18T17:08:55Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: bfce33d8-8151-4f8b-a554-6edf96c375b7

Baseline: 930cdf1
Comparison: a6fc1c9
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+3.89	[+0.80, +6.98]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+3.89	[+0.80, +6.98]	1	Logs
➖	quality_gate_logs	% cpu utilization	+1.89	[+0.39, +3.39]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.39	[+0.30, +0.48]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.37	[+0.14, +0.60]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.28	[+0.24, +0.31]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	+0.18	[-0.01, +0.37]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.16	[+0.11, +0.21]	1	Logs
➖	file_tree	memory utilization	+0.15	[+0.09, +0.22]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.12	[-0.02, +0.27]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.08	[-0.31, +0.46]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.06	[+0.01, +0.11]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.03	[-0.34, +0.40]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.10, +0.14]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.00	[-0.41, +0.42]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.08, +0.08]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.13, +0.12]	1	Logs
➖	ddot_metrics	memory utilization	-0.03	[-0.25, +0.20]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.07	[-0.23, +0.09]	1	Logs
➖	quality_gate_idle	memory utilization	-0.23	[-0.27, -0.18]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	-0.34	[-0.42, -0.27]	1	Logs
➖	docker_containers_memory	memory utilization	-0.44	[-0.52, -0.36]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-1.03	[-1.24, -0.82]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-1.20	[-1.28, -1.11]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Lewis-E · 2025-12-18T18:05:56Z

/merge

dd-devflow-routing-codex · 2025-12-18T18:06:00Z

View all feedbacks in Devflow UI.

2025-12-18 18:06:00 UTC ℹ️ Start processing command /merge

2025-12-18 18:06:08 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-18 18:17:39 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-12-18 19:54:46 UTC ℹ️ MergeQueue: This merge request was merged

Make Azure Container App tags independent of cloudservice Init

a6fc1c9

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Dec 18, 2025

Lewis-E commented Dec 18, 2025

View reviewed changes

apiarian-datadog reviewed Dec 18, 2025

View reviewed changes

github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 18, 2025

Lewis-E added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed labels Dec 18, 2025

Lewis-E marked this pull request as ready for review December 18, 2025 18:05

Lewis-E requested a review from a team as a code owner December 18, 2025 18:05

duncanpharvey approved these changes Dec 18, 2025

View reviewed changes

dd-mergequeue Bot merged commit 2f6862e into main Dec 18, 2025
355 of 359 checks passed

dd-mergequeue Bot deleted the lewis/SVLS-8201/containerapp-cloudservice-init-tags branch December 18, 2025 19:54

github-actions Bot added this to the 7.75.0 milestone Dec 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make Azure Container App tags independent of cloudservice Init#44414

Make Azure Container App tags independent of cloudservice Init#44414
dd-mergequeue[bot] merged 1 commit into
mainfrom
lewis/SVLS-8201/containerapp-cloudservice-init-tags

Lewis-E commented Dec 18, 2025 •

edited

Loading

Uh oh!

Lewis-E Dec 18, 2025

Uh oh!

apiarian-datadog Dec 18, 2025

Uh oh!

Lewis-E Dec 18, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr Bot commented Dec 18, 2025

Info

Uh oh!

cit-pr-commenter Bot commented Dec 18, 2025

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Lewis-E commented Dec 18, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -14,33 +14,6 @@ import (
		)

		func TestGetContainerAppTags(t *testing.T) {

Uh oh!

Conversation

Lewis-E commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Before:

After:

Uh oh!

Lewis-E Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

apiarian-datadog Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Lewis-E Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agent-platform-auto-pr Bot commented Dec 18, 2025

Static quality checks

Info

Uh oh!

cit-pr-commenter Bot commented Dec 18, 2025

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Lewis-E commented Dec 18, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lewis-E commented Dec 18, 2025 •

edited

Loading

Lewis-E Dec 18, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Dec 18, 2025 •

edited

Loading