[Cloud Run Jobs] Remove high cardinality tags from enhanced metrics by nhulston · Pull Request #43837 · DataDog/datadog-agent

nhulston · 2025-12-04T19:17:05Z

What does this PR do?

This is a temporary fix to remove high cardinality tags from Cloud Run Jobs enhanced metrics.
A more thorough refactor will be done in a future PR (#43370)

High cardinality removed:

Low cardinality still exists:

Motivation

Cost savings

Describe how you validated your changes

Manually with a real Cloud Run Job

Additional Notes

No changelog because Cloud Run Jobs support is not officially released yet.

Lewis-E

This won't cause any merge conflicts, thanks for the thought, and looks good to me ✅

agent-platform-auto-pr · 2025-12-04T19:58:23Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 87b5e65

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${-0}$$	$${705.25}$$ < $${706.32}$$	$${+0.02}$$	$${172.94}$$ < $${173.81}$$
✅	agent_deb_amd64_fips	$${0}$$	$${700.09}$$ < $${701.16}$$	$${+0.05}$$	$${171.74}$$ < $${172.71}$$
✅	agent_heroku_amd64	$${+0.89}$$	$${327.43}$$ < $${327.69}$$	$${+0.08}$$	$${87.38}$$ < $${88.19}$$
✅	agent_msi	$${+7.86}$$	$${978.7}$$ < $${982.08}$$	$${+0.02}$$	$${141.8}$$ < $${143.01}$$
✅	agent_rpm_amd64	$${-0}$$	$${705.23}$$ < $${706.31}$$	$${+0.01}$$	$${175.96}$$ < $${176.86}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${700.07}$$ < $${701.15}$$	$${-0.03}$$	$${174.0}$$ < $${174.95}$$
✅	agent_rpm_arm64	$${0}$$	$${690.91}$$ < $${691.67}$$	$${+0.02}$$	$${159.76}$$ < $${160.7}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${686.72}$$ < $${687.54}$$	$${+0.02}$$	$${159.12}$$ < $${160.1}$$
✅	agent_suse_amd64	$${-0}$$	$${705.23}$$ < $${706.31}$$	$${+0.01}$$	$${175.96}$$ < $${176.86}$$
✅	agent_suse_amd64_fips	$${0}$$	$${700.07}$$ < $${701.15}$$	$${-0.03}$$	$${174.0}$$ < $${174.95}$$
✅	agent_suse_arm64	$${0}$$	$${690.91}$$ < $${691.67}$$	$${+0.02}$$	$${159.76}$$ < $${160.7}$$
✅	agent_suse_arm64_fips	$${0}$$	$${686.72}$$ < $${687.54}$$	$${+0.02}$$	$${159.12}$$ < $${160.1}$$
✅	docker_agent_amd64	$${-0}$$	$${767.57}$$ < $${768.66}$$	$${-0}$$	$${260.64}$$ < $${261.52}$$
✅	docker_agent_arm64	$${-0}$$	$${777.53}$$ < $${778.35}$$	$${+0.01}$$	$${250.81}$$ < $${251.72}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${958.45}$$ < $${959.54}$$	$${+0}$$	$${329.28}$$ < $${330.15}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${957.12}$$ < $${957.95}$$	$${+0}$$	$${315.43}$$ < $${316.35}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${178.88}$$ < $${179.28}$$	$${+0}$$	$${63.18}$$ < $${63.96}$$
✅	docker_cluster_agent_arm64	$${+0}$$	$${196.39}$$ < $${196.79}$$	$${-0}$$	$${59.89}$$ < $${60.69}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.6}$$ < $${39.3}$$	$${+0}$$	$${14.91}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.24}$$ < $${37.94}$$	$${-0.01}$$	$${14.36}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.82}$$ < $${30.53}$$	$${+0}$$	$${7.87}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.33}$$ < $${29.11}$$	$${+0}$$	$${6.81}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.82}$$ < $${30.53}$$	$${+0}$$	$${7.88}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.82}$$ < $${30.53}$$	$${+0}$$	$${7.88}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${0}$$	$${42.6}$$ < $${43.19}$$	$${-0}$$	$${11.12}$$ < $${11.98}$$
✅	iot_agent_deb_arm64	$${0}$$	$${40.34}$$ < $${40.92}$$	$${-0}$$	$${9.58}$$ < $${10.45}$$
✅	iot_agent_deb_armhf	$${0}$$	$${40.24}$$ < $${40.86}$$	$${+0}$$	$${9.69}$$ < $${10.56}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${42.6}$$ < $${43.19}$$	$${-0}$$	$${11.14}$$ < $${12.0}$$
✅	iot_agent_suse_amd64	$${0}$$	$${42.6}$$ < $${43.19}$$	$${-0}$$	$${11.14}$$ < $${12.0}$$

cit-pr-commenter · 2025-12-04T20:16:17Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: cdb53312-3d9c-4ab0-8391-3a3214311cd4

Baseline: 12bfa8a
Comparison: 8fd3c6a
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-4.59	[-7.44, -1.73]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.19	[+0.71, +3.67]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	+1.19	[+0.98, +1.39]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.95	[+0.85, +1.05]	1	Logs
➖	file_tree	memory utilization	+0.25	[+0.20, +0.30]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.23	[+0.08, +0.38]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.23	[+0.07, +0.38]	1	Logs
➖	ddot_logs	memory utilization	+0.22	[+0.16, +0.27]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.10	[+0.04, +0.15]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.06	[-0.18, +0.30]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.02	[-0.36, +0.39]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.41, +0.42]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.39, +0.40]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.00	[-0.12, +0.12]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.08, +0.08]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.14, +0.13]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.06	[-0.10, -0.01]	1	Logs
➖	quality_gate_idle	memory utilization	-0.15	[-0.20, -0.10]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	-0.30	[-0.39, -0.22]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.42	[-0.47, -0.37]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	-0.53	[-0.75, -0.30]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.91	[-0.99, -0.84]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-1.05	[-1.25, -0.85]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-4.59	[-7.44, -1.73]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

duncanpharvey · 2025-12-04T20:59:05Z

+// highCardinalityTags is a set of tag keys that should be excluded from metrics
+var highCardinalityTags = map[string]struct{}{
+	"container_id":        {},
+	"gcr.container_id":    {},
+	"gcrfx.container_id":  {},
+	"replica_name":        {},
+	"aca.replica.name":    {},
+	"gcrj.execution_name": {},
+	"gcrj.task_index":     {},
+	"gcrj.task_attempt":   {},
+	"gcrj.task_count":     {},
+}
+


Could this be an array rather than a map?

The map has O(1) lookup, while an array would have O(n) lookup

nhulston · 2025-12-05T14:58:51Z

/merge

dd-devflow-routing-codex · 2025-12-05T14:58:55Z

View all feedbacks in Devflow UI.

2025-12-05 14:58:54 UTC ℹ️ Start processing command /merge

2025-12-05 14:58:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-05 14:59:11 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 34m (p90).

2025-12-05 15:15:54 UTC ℹ️ MergeQueue: This merge request was merged

nhulston added 4 commits December 4, 2025 13:58

organize tags by cardinality

9eddfa9

(chore): optimize WithoutHighCardinalityTags

5105644

skip high cardinality tags in Cloud Run Jobs metrics

5486b00

unit test

8fd3c6a

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Dec 4, 2025

nhulston added team/serverless-azure-gcp qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed labels Dec 4, 2025

nhulston marked this pull request as ready for review December 4, 2025 19:19

nhulston requested a review from a team as a code owner December 4, 2025 19:19

Lewis-E approved these changes Dec 4, 2025

View reviewed changes

duncanpharvey reviewed Dec 4, 2025

View reviewed changes

github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 5, 2025

duncanpharvey approved these changes Dec 5, 2025

View reviewed changes

dd-mergequeue Bot merged commit 4830ea9 into main Dec 5, 2025
335 of 337 checks passed

dd-mergequeue Bot deleted the nicholas.hulston/cloud-run-jobs-skip-high-cardinality-tags branch December 5, 2025 15:15

github-actions Bot added this to the 7.75.0 milestone Dec 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Cloud Run Jobs] Remove high cardinality tags from enhanced metrics#43837

[Cloud Run Jobs] Remove high cardinality tags from enhanced metrics#43837
dd-mergequeue[bot] merged 4 commits into
mainfrom
nicholas.hulston/cloud-run-jobs-skip-high-cardinality-tags

nhulston commented Dec 4, 2025 •

edited

Loading

Uh oh!

Lewis-E left a comment •

edited

Loading

Uh oh!

agent-platform-auto-pr Bot commented Dec 4, 2025

Info

Uh oh!

cit-pr-commenter Bot commented Dec 4, 2025

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

duncanpharvey Dec 4, 2025

Uh oh!

nhulston Dec 5, 2025

Uh oh!

nhulston commented Dec 5, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Dec 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nhulston commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

Lewis-E left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agent-platform-auto-pr Bot commented Dec 4, 2025

Static quality checks

Info

Uh oh!

cit-pr-commenter Bot commented Dec 4, 2025

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

duncanpharvey Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

nhulston Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

nhulston commented Dec 5, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nhulston commented Dec 4, 2025 •

edited

Loading

Lewis-E left a comment •

edited

Loading

dd-devflow-routing-codex Bot commented Dec 5, 2025 •

edited

Loading