[Cloud Run Jobs] Replace `exit_code` tag with `error:true` or `error:false` to reduce cardinality by nhulston · Pull Request #43694 · DataDog/datadog-agent

nhulston · 2025-12-01T20:18:26Z

What does this PR do?

Replace exit_code tag to succeeded:true or succeeded:false to reduce cardinality. The exit_code tag will no longer be needed after this change:
https://github.com/DataDog/web-ui/pull/251927

No changelog and non-breaking, since Cloud Run Jobs support is still under development.

In a future PR, we will remove the other high cardinality tags (e.g. execution_name). But we need to make some frontend changes first

Motivation

Cost savings
https://datadoghq.atlassian.net/browse/SVLS-8084

Describe how you validated your changes

Manually in Cloud Run Jobs

Additional Notes

…cardinality

agent-platform-auto-pr · 2025-12-01T21:00:46Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 7843536

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${705.21}$$ < $${706.32}$$	$${+0}$$	$${172.95}$$ < $${173.81}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${700.06}$$ < $${701.16}$$	$${+0.05}$$	$${171.75}$$ < $${172.71}$$
✅	agent_heroku_amd64	$${0}$$	$${326.41}$$ < $${327.69}$$	$${+0}$$	$${87.34}$$ < $${88.19}$$
✅	agent_msi	$${0}$$	$${969.43}$$ < $${982.08}$$	$${-0.02}$$	$${141.44}$$ < $${143.01}$$
✅	agent_rpm_amd64	$${+0}$$	$${705.2}$$ < $${706.31}$$	$${+0.06}$$	$${176.0}$$ < $${176.86}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${700.04}$$ < $${701.15}$$	$${+0.04}$$	$${174.03}$$ < $${174.95}$$
✅	agent_rpm_arm64	$${-0}$$	$${690.86}$$ < $${691.67}$$	$${+0.04}$$	$${159.8}$$ < $${160.7}$$
✅	agent_rpm_arm64_fips	$${-0}$$	$${686.68}$$ < $${687.54}$$	$${+0.02}$$	$${159.13}$$ < $${160.1}$$
✅	agent_suse_amd64	$${+0}$$	$${705.2}$$ < $${706.31}$$	$${+0.06}$$	$${176.0}$$ < $${176.86}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${700.04}$$ < $${701.15}$$	$${+0.04}$$	$${174.03}$$ < $${174.95}$$
✅	agent_suse_arm64	$${-0}$$	$${690.86}$$ < $${691.67}$$	$${+0.04}$$	$${159.8}$$ < $${160.7}$$
✅	agent_suse_arm64_fips	$${-0}$$	$${686.68}$$ < $${687.54}$$	$${+0.02}$$	$${159.13}$$ < $${160.1}$$
✅	docker_agent_amd64	$${+0}$$	$${767.54}$$ < $${768.66}$$	$${+0.01}$$	$${260.63}$$ < $${261.52}$$
✅	docker_agent_arm64	$${-0}$$	$${777.48}$$ < $${778.35}$$	$${+0}$$	$${250.81}$$ < $${251.72}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${958.41}$$ < $${959.54}$$	$${+0.01}$$	$${329.26}$$ < $${330.15}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${957.08}$$ < $${957.95}$$	$${+0}$$	$${315.44}$$ < $${316.35}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${178.88}$$ < $${179.28}$$	$${+0}$$	$${63.17}$$ < $${63.96}$$
✅	docker_cluster_agent_arm64	$${0}$$	$${196.39}$$ < $${196.79}$$	$${+0}$$	$${59.89}$$ < $${60.69}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${+0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${+0}$$	$${38.6}$$ < $${39.3}$$	$${+0}$$	$${14.91}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${-0}$$	$${37.3}$$ < $${37.94}$$	$${-0}$$	$${14.36}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.82}$$ < $${30.53}$$	$${+0}$$	$${7.87}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.33}$$ < $${29.11}$$	$${+0}$$	$${6.8}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.82}$$ < $${30.53}$$	$${-0}$$	$${7.88}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.82}$$ < $${30.53}$$	$${-0}$$	$${7.88}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${0}$$	$${42.59}$$ < $${43.19}$$	$${-0}$$	$${11.12}$$ < $${11.98}$$
✅	iot_agent_deb_arm64	$${0}$$	$${40.33}$$ < $${40.92}$$	$${-0}$$	$${9.58}$$ < $${10.45}$$
✅	iot_agent_deb_armhf	$${0}$$	$${40.23}$$ < $${40.86}$$	$${+0}$$	$${9.69}$$ < $${10.56}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${42.59}$$ < $${43.19}$$	$${+0}$$	$${11.14}$$ < $${12.0}$$
✅	iot_agent_suse_amd64	$${0}$$	$${42.59}$$ < $${43.19}$$	$${+0}$$	$${11.14}$$ < $${12.0}$$

cit-pr-commenter · 2025-12-01T21:13:03Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 209330d2-a5ae-411d-897d-4d58224a8817

Baseline: f3e5cec
Comparison: fe67e27
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-3.73	[-6.64, -0.82]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.26	[+0.79, +3.74]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.78	[+0.63, +0.93]	1	Logs
➖	ddot_logs	memory utilization	+0.61	[+0.55, +0.67]	1	Logs
➖	ddot_metrics	memory utilization	+0.41	[+0.19, +0.64]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.39	[+0.34, +0.44]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.32	[+0.27, +0.37]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.23	[+0.18, +0.28]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.19	[+0.13, +0.24]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.16	[-0.08, +0.40]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.13	[-0.08, +0.34]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	+0.10	[+0.01, +0.19]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.08	[+0.03, +0.12]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.05	[-0.15, +0.25]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.12, +0.15]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.36, +0.38]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.06, +0.07]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.12, +0.11]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.01	[-0.09, +0.08]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.38, +0.36]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.01	[-0.42, +0.40]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.16	[-0.32, -0.00]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-2.88	[-2.97, -2.79]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-3.73	[-6.64, -0.82]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

apiarian-datadog · 2025-12-01T23:00:16Z

-	metric.Add(shutdownMetricName, 1.0, c.GetSource(), metricAgent, fmt.Sprintf("exit_code:%d", exitCode))
+	errorTag := "error:false"
+	if exitCode != 0 {
+		errorTag = "error:true"


would exit_code_0:[true|false] be more clear here? "error" seems a bit generic

In the Cloud Run Jobs UI, they display the task as failed if exit_code != 0 and succeeded if exit_code == 0. Maybe failed: true|false or succeeded:true|false is better?

ah, if the "status code zero is success, other is failure" concept is standard for jobs, this is fine. making this a positive thing may be better, so "succeeded:true|false" instead of "failed:false|true".

nhulston · 2025-12-02T19:15:09Z

/merge

dd-devflow-routing-codex · 2025-12-02T19:15:13Z

View all feedbacks in Devflow UI.

2025-12-02 19:15:13 UTC ℹ️ Start processing command /merge

2025-12-02 19:15:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-02 21:14:50 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

nhulston · 2025-12-02T21:14:44Z

/remove

dd-devflow-routing-codex · 2025-12-02T21:14:46Z

View all feedbacks in Devflow UI.

2025-12-02 21:14:46 UTC ℹ️ Start processing command /remove

2025-12-02 21:14:49 UTC ℹ️ Devflow: /remove

nhulston · 2025-12-02T21:15:23Z

/merge

dd-devflow-routing-codex · 2025-12-02T21:15:27Z

View all feedbacks in Devflow UI.

2025-12-02 21:15:26 UTC ℹ️ Start processing command /merge

2025-12-02 21:15:33 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-03 01:16:15 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

…t-code-tag

nhulston · 2025-12-03T17:29:46Z

/merge

dd-devflow-routing-codex · 2025-12-03T17:29:49Z

View all feedbacks in Devflow UI.

2025-12-03 17:29:49 UTC ℹ️ Start processing command /merge

2025-12-03 17:29:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-03 19:58:17 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 41m (p90).

2025-12-03 20:20:13 UTC ℹ️ MergeQueue: This merge request was merged

nhulston added 2 commits December 1, 2025 15:17

replace exit_code tag with error:true or error:false to reduce …

0f060c1

…cardinality

update tests

a3219b0

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Dec 1, 2025

nhulston added team/serverless-azure-gcp changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Dec 1, 2025

nhulston marked this pull request as ready for review December 1, 2025 22:30

nhulston requested a review from a team as a code owner December 1, 2025 22:30

Lewis-E approved these changes Dec 1, 2025

View reviewed changes

apiarian-datadog reviewed Dec 1, 2025

View reviewed changes

github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 2, 2025

update tag to succeeded:true or succeeded:false

2d8cbfc

Merge branch 'main' into nicholas.hulston/cloud-run-jobs-simplify-exi…

fe67e27

…t-code-tag

apiarian-datadog approved these changes Dec 3, 2025

View reviewed changes

dd-mergequeue Bot merged commit 80b25d5 into main Dec 3, 2025
298 checks passed

dd-mergequeue Bot deleted the nicholas.hulston/cloud-run-jobs-simplify-exit-code-tag branch December 3, 2025 20:20

github-actions Bot added this to the 7.75.0 milestone Dec 3, 2025

Uh oh!

Conversation

nhulston commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

agent-platform-auto-pr Bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter Bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

apiarian-datadog Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

nhulston Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

apiarian-datadog Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

nhulston commented Dec 2, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nhulston commented Dec 2, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nhulston commented Dec 2, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nhulston commented Dec 3, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nhulston commented Dec 1, 2025 •

edited

Loading

agent-platform-auto-pr Bot commented Dec 1, 2025 •

edited

Loading

cit-pr-commenter Bot commented Dec 1, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Dec 2, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Dec 2, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Dec 2, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Dec 3, 2025 •

edited

Loading