Skip to content

[ACTP-1046] sync more PAR code to agent#43412

Merged
dd-mergequeue[bot] merged 18 commits into
mainfrom
gabriel.plassard/ACTP-1046/sync-par-to-agent
Dec 2, 2025
Merged

[ACTP-1046] sync more PAR code to agent#43412
dd-mergequeue[bot] merged 18 commits into
mainfrom
gabriel.plassard/ACTP-1046/sync-par-to-agent

Conversation

@dd-gplassard

@dd-gplassard dd-gplassard commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR synchronizes part of Private Action Runner from the current source code to the datadog agent

Motivation

We are migrating the PAR inside the agent

Describe how you validated your changes

This code is not currently called from the agent so it won't have any impact

Additional Notes

Discussed with @pgimalac and we are disabling the revive linter for the privateactionrunner package since having to fix those while it's not the main source of truth would be really cumbersome.

There will be subsequent PRs for the rest of the code

@github-actions github-actions Bot added the medium review PR review might take time label Nov 24, 2025
@dd-gplassard
dd-gplassard force-pushed the gabriel.plassard/ACTP-1046/sync-par-to-agent branch from 049a85b to 2aa60c1 Compare November 24, 2025 17:15
@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2869418

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0.03}$$ $${705.04}$$ < $${717.44}$$ $${+0}$$ $${172.93}$$ < $${177.37}$$
✅ agent_deb_amd64_fips $${+0.03}$$ $${699.88}$$ < $${711.66}$$ $${+0.05}$$ $${171.72}$$ < $${174.84}$$
✅ agent_heroku_amd64 $${+0.03}$$ $${326.36}$$ < $${337.57}$$ $${-0}$$ $${87.33}$$ < $${90.78}$$
✅ agent_msi $${+0}$$ $${969.05}$$ < $${1015.38}$$ $${-0.01}$$ $${141.39}$$ < $${149.42}$$
✅ agent_rpm_amd64 $${+0.03}$$ $${705.03}$$ < $${717.41}$$ $${+0}$$ $${175.91}$$ < $${178.01}$$
✅ agent_rpm_amd64_fips $${+0.03}$$ $${699.87}$$ < $${711.64}$$ $${+0.05}$$ $${174.01}$$ < $${177.26}$$
✅ agent_rpm_arm64 $${+0.03}$$ $${690.71}$$ < $${702.19}$$ $${+0.01}$$ $${159.73}$$ < $${163.22}$$
✅ agent_rpm_arm64_fips $${+0.03}$$ $${686.52}$$ < $${697.6}$$ $${-0}$$ $${159.05}$$ < $${162.68}$$
✅ agent_suse_amd64 $${+0.03}$$ $${705.03}$$ < $${717.41}$$ $${+0}$$ $${175.91}$$ < $${178.01}$$
✅ agent_suse_amd64_fips $${+0.03}$$ $${699.87}$$ < $${711.64}$$ $${+0.05}$$ $${174.01}$$ < $${177.26}$$
✅ agent_suse_arm64 $${+0.03}$$ $${690.71}$$ < $${702.19}$$ $${+0.01}$$ $${159.73}$$ < $${163.22}$$
✅ agent_suse_arm64_fips $${+0.03}$$ $${686.52}$$ < $${697.6}$$ $${-0}$$ $${159.05}$$ < $${162.68}$$
✅ docker_agent_amd64 $${+0.03}$$ $${767.38}$$ < $${769.92}$$ $${+0}$$ $${260.59}$$ < $${261.52}$$
✅ docker_agent_arm64 $${+0.03}$$ $${777.33}$$ < $${779.46}$$ $${-0}$$ $${250.78}$$ < $${251.72}$$
✅ docker_agent_jmx_amd64 $${+0.03}$$ $${958.26}$$ < $${960.8}$$ $${+0}$$ $${329.22}$$ < $${330.15}$$
✅ docker_agent_jmx_arm64 $${+0.03}$$ $${956.93}$$ < $${958.93}$$ $${+0}$$ $${315.41}$$ < $${316.35}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${178.85}$$ < $${207.49}$$ $${+0}$$ $${63.16}$$ < $${70.2}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${196.33}$$ < $${223.38}$$ $${-0}$$ $${59.88}$$ < $${66.42}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${38.58}$$ < $${39.3}$$ $${-0}$$ $${14.91}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${+0}$$ $${37.24}$$ < $${37.94}$$ $${-0}$$ $${14.36}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${29.8}$$ < $${30.53}$$ $${-0}$$ $${7.86}$$ < $${8.75}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${28.31}$$ < $${29.11}$$ $${-0}$$ $${6.8}$$ < $${7.71}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${29.8}$$ < $${30.53}$$ $${-0}$$ $${7.87}$$ < $${8.76}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${29.8}$$ < $${30.53}$$ $${-0}$$ $${7.87}$$ < $${8.76}$$
✅ iot_agent_deb_amd64 $${0}$$ $${42.55}$$ < $${43.19}$$ $${-0}$$ $${11.11}$$ < $${11.98}$$
✅ iot_agent_deb_arm64 $${0}$$ $${40.29}$$ < $${40.92}$$ $${-0}$$ $${9.57}$$ < $${10.45}$$
✅ iot_agent_deb_armhf $${0}$$ $${40.2}$$ < $${40.86}$$ $${-0}$$ $${9.69}$$ < $${10.56}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${42.56}$$ < $${43.19}$$ $${-0}$$ $${11.13}$$ < $${12.0}$$
✅ iot_agent_suse_amd64 $${0}$$ $${42.56}$$ < $${43.19}$$ $${-0}$$ $${11.13}$$ < $${12.0}$$

@cit-pr-commenter

cit-pr-commenter Bot commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6e4bfea8-b21c-4a68-9674-f15d767caf26

Baseline: 67dadff
Comparison: 9ea768c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.13 [-0.84, +5.11] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +2.13 [-0.84, +5.11] 1 Logs
➖ otlp_ingest_logs memory utilization +0.97 [+0.87, +1.06] 1 Logs
➖ ddot_logs memory utilization +0.66 [+0.59, +0.73] 1 Logs
➖ docker_containers_memory memory utilization +0.60 [+0.52, +0.69] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.38 [+0.24, +0.52] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.17 [-0.07, +0.40] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.15 [-0.00, +0.31] 1 Logs
➖ ddot_metrics_sum_delta memory utilization +0.15 [-0.06, +0.36] 1 Logs
➖ file_tree memory utilization +0.14 [+0.10, +0.19] 1 Logs
➖ quality_gate_logs % cpu utilization +0.08 [-1.37, +1.54] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.06 [+0.01, +0.11] 1 Logs
➖ quality_gate_metrics_logs memory utilization +0.02 [-0.19, +0.22] 1 Logs bounds checks dashboard
➖ file_to_blackhole_500ms_latency egress throughput +0.01 [-0.36, +0.37] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.07, +0.07] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.13, +0.14] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.12, +0.13] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.00 [-0.41, +0.41] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.01 [-0.06, +0.04] 1 Logs
➖ quality_gate_idle memory utilization -0.03 [-0.08, +0.02] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency egress throughput -0.05 [-0.43, +0.33] 1 Logs
➖ ddot_metrics memory utilization -0.13 [-0.33, +0.07] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.18 [-0.23, -0.13] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput -0.49 [-0.55, -0.43] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency lost_bytes 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@github-actions github-actions Bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Nov 25, 2025
@dd-gplassard dd-gplassard added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation and removed qa/skip-qa labels Nov 26, 2025
@dd-gplassard
dd-gplassard marked this pull request as ready for review November 26, 2025 12:57
@dd-gplassard
dd-gplassard requested review from a team as code owners November 26, 2025 12:57
ross-m-young
ross-m-young reviewed Nov 26, 2025
View reviewed changes
Comment thread pkg/privateactionrunner/util/jwt.go
aiuto
aiuto approved these changes Nov 26, 2025
View reviewed changes

@aiuto aiuto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For LICENSES.csv

@dd-gplassard

dd-gplassard commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

/merge -m squash

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 26, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-26 17:06:01 UTC ℹ️ Start processing command /merge -m squash

2025-11-26 17:06:10 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-11-26 21:07:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@dd-gplassard

dd-gplassard commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

/merge -m squash

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-12-02 09:00:47 UTC ℹ️ Start processing command /merge -m squash

2025-12-02 09:00:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-02 09:01:01 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@dd-gplassard

dd-gplassard commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

/merge -c

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-12-02 09:00:58 UTC ℹ️ Start processing command /merge -c

@dd-gplassard

dd-gplassard commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

/merge -m squash

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-12-02 09:23:10 UTC ℹ️ Start processing command /merge -m squash

2025-12-02 09:23:17 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-02 11:04:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 42m (p90).

2025-12-02 11:42:04 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 67324f0 into main Dec 2, 2025
281 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the gabriel.plassard/ACTP-1046/sync-par-to-agent branch December 2, 2025 11:42
@github-actions github-actions Bot added this to the 7.75.0 milestone Dec 2, 2025
@dd-gplassard dd-gplassard mentioned this pull request Dec 2, 2025
Merged
dd-mergequeue Bot pushed a commit that referenced this pull request Dec 2, 2025
@dd-gplassard
[ACTP-1046] sync more PAR code to agent (#2) (#43595)
9879391 
### What does this PR do?

This syncs additional code from the original PAR into the datadog agent

### Motivation

### Describe how you validated your changes

Code is not called yet

### Additional Notes

Previous PR : #43412
More PRs to come


Co-authored-by: gabriel.plassard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aiuto aiuto aiuto approved these changes
@pducolin pducolin pducolin approved these changes
@merchristK merchristK merchristK approved these changes
@ross-m-young ross-m-young ross-m-young approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation

Projects

None yet

Milestone

7.75.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dd-gplassard @aiuto @pducolin @merchristK @ross-m-young