[AGENTRUN-901] Update golang.org/x/... dependencies#43275
Conversation
jose-manuel-almaza
left a comment
There was a problem hiding this comment.
approved by mistake
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: f42d155 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.47 | [-2.41, +3.34] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | otlp_ingest_logs | memory utilization | +1.11 | [+1.02, +1.21] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.82 | [+0.76, +0.89] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.80 | [+0.58, +1.01] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | +0.47 | [-2.41, +3.34] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.44 | [-1.03, +1.91] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.40 | [+0.31, +0.49] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.25 | [+0.20, +0.29] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.22 | [+0.08, +0.37] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.20 | [+0.15, +0.25] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.14 | [+0.00, +0.29] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.06 | [-0.18, +0.29] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.03 | [-0.03, +0.08] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.38, +0.40] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.14, +0.14] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.08, +0.06] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.14, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.03 | [-0.40, +0.34] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.05 | [-0.47, +0.36] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.09 | [-0.14, -0.04] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.13 | [-0.25, -0.02] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.38 | [-0.60, -0.16] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.39 | [-0.44, -0.34] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.58 | [-0.79, -0.36] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
8ca14f5 to
cc8cbd0
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.73.x 7.73.x
# Navigate to the new working tree
cd .worktrees/backport-7.73.x
# Create a new branch
git switch --create backport-43275-to-7.73.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 433139dd0de0769a16595f3c3c39b6c7a7d666e8
# Push it to GitHub
git push --set-upstream origin backport-43275-to-7.73.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.73.xThen, create a pull request where the |
### What does this PR do? Updates all `golang.org/x` modules to their latest versions, including: - `golang.org/x/sys` from v0.37.0 to v0.38.0 - `golang.org/x/net` from v0.46.0 to v0.47.0 - `golang.org/x/text` from v0.30.0 to v0.31.0 - `golang.org/x/sync` from v0.17.0 to v0.18.0 - `golang.org/x/exp` from v0.0.0-20251009144603-d2f985daa21b to v0.0.0-20251113190631-e25ba8c21ef6 - `golang.org/x/crypto` from v0.43.0 to v0.45.0 - `golang.org/x/oauth2` from v0.32.0 to v0.33.0 - `golang.org/x/term` from v0.36.0 to v0.37.0 - `golang.org/x/mod` from v0.29.0 to v0.30.0 - `golang.org/x/tools` from v0.38.0 to v0.39.0 - `golang.org/x/arch` from v0.22.0 to v0.23.0 - `golang.org/x/telemetry` from v0.0.0-20251008203120-078029d740a8 to v0.0.0-20251111182119-bc8e575c7b54 ### Motivation Keep Go standard library extensions up-to-date ### Describe how you validated your changes CI should be enough. Co-authored-by: maxime.riaud <[email protected]>
What does this PR do?
Updates all
golang.org/xmodules to their latest versions, including:golang.org/x/sysfrom v0.37.0 to v0.38.0golang.org/x/netfrom v0.46.0 to v0.47.0golang.org/x/textfrom v0.30.0 to v0.31.0golang.org/x/syncfrom v0.17.0 to v0.18.0golang.org/x/expfrom v0.0.0-20251009144603-d2f985daa21b to v0.0.0-20251113190631-e25ba8c21ef6golang.org/x/cryptofrom v0.43.0 to v0.45.0golang.org/x/oauth2from v0.32.0 to v0.33.0golang.org/x/termfrom v0.36.0 to v0.37.0golang.org/x/modfrom v0.29.0 to v0.30.0golang.org/x/toolsfrom v0.38.0 to v0.39.0golang.org/x/archfrom v0.22.0 to v0.23.0golang.org/x/telemetryfrom v0.0.0-20251008203120-078029d740a8 to v0.0.0-20251111182119-bc8e575c7b54Motivation
Keep Go standard library extensions up-to-date
Describe how you validated your changes
CI should be enough.