Skip to content

[AGENTRUN-901] Update golang.org/x/... dependencies#43275

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
AGENTRUN-901-update-golang-org-x-crypto-package
Nov 21, 2025
Merged

[AGENTRUN-901] Update golang.org/x/... dependencies#43275
dd-mergequeue[bot] merged 1 commit into
mainfrom
AGENTRUN-901-update-golang-org-x-crypto-package

Conversation

@misteriaud

Copy link
Copy Markdown
Member

What does this PR do?

Updates all golang.org/x modules to their latest versions, including:

  • golang.org/x/sys from v0.37.0 to v0.38.0
  • golang.org/x/net from v0.46.0 to v0.47.0
  • golang.org/x/text from v0.30.0 to v0.31.0
  • golang.org/x/sync from v0.17.0 to v0.18.0
  • golang.org/x/exp from v0.0.0-20251009144603-d2f985daa21b to v0.0.0-20251113190631-e25ba8c21ef6
  • golang.org/x/crypto from v0.43.0 to v0.45.0
  • golang.org/x/oauth2 from v0.32.0 to v0.33.0
  • golang.org/x/term from v0.36.0 to v0.37.0
  • golang.org/x/mod from v0.29.0 to v0.30.0
  • golang.org/x/tools from v0.38.0 to v0.39.0
  • golang.org/x/arch from v0.22.0 to v0.23.0
  • golang.org/x/telemetry from v0.0.0-20251008203120-078029d740a8 to v0.0.0-20251111182119-bc8e575c7b54

Motivation

Keep Go standard library extensions up-to-date

Describe how you validated your changes

CI should be enough.

@misteriaud
misteriaud requested review from a team as code owners November 20, 2025 11:33
@github-actions github-actions Bot added component/system-probe team/agent-devx long review PR is complex, plan time to review it labels Nov 20, 2025
@misteriaud misteriaud added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Nov 20, 2025

@jose-manuel-almaza jose-manuel-almaza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved by mistake

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor f42d155

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0.03}$$ $${704.86}$$ < $${717.44}$$ $${+0.03}$$ $${172.45}$$ < $${177.37}$$
agent_deb_amd64_fips $${-0.02}$$ $${698.9}$$ < $${711.66}$$ $${-0.02}$$ $${171.21}$$ < $${174.84}$$
agent_heroku_amd64 $${-0.02}$$ $${327.29}$$ < $${337.57}$$ $${+0.02}$$ $${87.36}$$ < $${90.78}$$
agent_msi $${+0}$$ $${999.49}$$ < $${1015.38}$$ $${+0.02}$$ $${144.39}$$ < $${149.42}$$
agent_rpm_amd64 $${-0.03}$$ $${704.85}$$ < $${717.41}$$ $${-0.03}$$ $${175.65}$$ < $${178.01}$$
agent_rpm_amd64_fips $${-0.02}$$ $${698.89}$$ < $${711.64}$$ $${+0.02}$$ $${173.33}$$ < $${177.26}$$
agent_rpm_arm64 $${+0}$$ $${690.16}$$ < $${702.19}$$ $${-0.01}$$ $${159.44}$$ < $${163.22}$$
agent_rpm_arm64_fips $${+0}$$ $${685.34}$$ < $${697.6}$$ $${-0.01}$$ $${158.74}$$ < $${162.68}$$
agent_suse_amd64 $${-0.03}$$ $${704.85}$$ < $${717.41}$$ $${-0.03}$$ $${175.65}$$ < $${178.01}$$
agent_suse_amd64_fips $${-0.02}$$ $${698.89}$$ < $${711.64}$$ $${+0.02}$$ $${173.33}$$ < $${177.26}$$
agent_suse_arm64 $${+0}$$ $${690.16}$$ < $${702.19}$$ $${-0.01}$$ $${159.44}$$ < $${163.22}$$
agent_suse_arm64_fips $${+0}$$ $${685.34}$$ < $${697.6}$$ $${-0.01}$$ $${158.74}$$ < $${162.68}$$
docker_agent_amd64 $${-0.03}$$ $${767.24}$$ < $${769.92}$$ $${+0}$$ $${260.32}$$ < $${261.52}$$
docker_agent_arm64 $${+0}$$ $${776.9}$$ < $${779.46}$$ $${-0}$$ $${250.57}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${-0.03}$$ $${958.11}$$ < $${960.8}$$ $${+0.01}$$ $${328.97}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+0}$$ $${956.37}$$ < $${958.93}$$ $${+0}$$ $${315.2}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0}$$ $${179.2}$$ < $${207.49}$$ $${+0}$$ $${63.23}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${+0}$$ $${196.69}$$ < $${223.38}$$ $${+0}$$ $${59.96}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${+0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0.01}$$ $${38.54}$$ < $${39.3}$$ $${+0}$$ $${14.9}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${+0.06}$$ $${37.24}$$ < $${37.94}$$ $${+0.01}$$ $${14.34}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${+0}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.86}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${+0.01}$$ $${28.28}$$ < $${29.11}$$ $${+0}$$ $${6.79}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${+0}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.86}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${+0}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.86}$$ < $${8.76}$$
iot_agent_deb_amd64 $${-0.02}$$ $${42.36}$$ < $${43.19}$$ $${+0}$$ $${11.07}$$ < $${11.98}$$
iot_agent_deb_arm64 $${-0}$$ $${40.11}$$ < $${40.92}$$ $${+0}$$ $${9.53}$$ < $${10.45}$$
iot_agent_deb_armhf $${-0.02}$$ $${40.03}$$ < $${40.86}$$ $${+0}$$ $${9.64}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${-0.02}$$ $${42.36}$$ < $${43.19}$$ $${+0}$$ $${11.08}$$ < $${12.0}$$
iot_agent_suse_amd64 $${-0.02}$$ $${42.36}$$ < $${43.19}$$ $${+0}$$ $${11.08}$$ < $${12.0}$$

@cit-pr-commenter

cit-pr-commenter Bot commented Nov 20, 2025

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 337d9408-3648-4d30-8a99-df4585db7a7c

Baseline: f42d155
Comparison: cc8cbd0
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.47 [-2.41, +3.34] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs memory utilization +1.11 [+1.02, +1.21] 1 Logs
ddot_logs memory utilization +0.82 [+0.76, +0.89] 1 Logs
ddot_metrics_sum_delta memory utilization +0.80 [+0.58, +1.01] 1 Logs
docker_containers_cpu % cpu utilization +0.47 [-2.41, +3.34] 1 Logs
quality_gate_logs % cpu utilization +0.44 [-1.03, +1.91] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.40 [+0.31, +0.49] 1 Logs
file_tree memory utilization +0.25 [+0.20, +0.29] 1 Logs
otlp_ingest_metrics memory utilization +0.22 [+0.08, +0.37] 1 Logs
quality_gate_idle memory utilization +0.20 [+0.15, +0.25] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.14 [+0.00, +0.29] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.06 [-0.18, +0.29] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.03, +0.08] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.38, +0.40] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.14, +0.14] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.08, +0.06] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.12] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.40, +0.34] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.47, +0.36] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.09 [-0.14, -0.04] 1 Logs
docker_containers_memory memory utilization -0.13 [-0.25, -0.02] 1 Logs
ddot_metrics memory utilization -0.38 [-0.60, -0.16] 1 Logs
quality_gate_idle_all_features memory utilization -0.39 [-0.44, -0.34] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.58 [-0.79, -0.36] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@misteriaud
misteriaud requested a review from a team as a code owner November 20, 2025 14:32
@misteriaud
misteriaud removed the request for review from a team November 20, 2025 15:37
@misteriaud

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 20, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-20 15:42:21 UTC ℹ️ Start processing command /merge


2025-11-20 15:42:29 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-20 19:43:07 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@misteriaud
misteriaud force-pushed the AGENTRUN-901-update-golang-org-x-crypto-package branch from 8ca14f5 to cc8cbd0 Compare November 21, 2025 09:00
@misteriaud

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 21, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-21 09:02:08 UTC ℹ️ Start processing command /merge


2025-11-21 09:02:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-21 11:20:15 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 36m (p90).


2025-11-21 12:04:48 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 433139d into main Nov 21, 2025
594 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the AGENTRUN-901-update-golang-org-x-crypto-package branch November 21, 2025 12:04
@github-actions github-actions Bot added this to the 7.74.0 milestone Nov 21, 2025
@dd-octo-sts

dd-octo-sts Bot commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

The backport to 7.73.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.73.x 7.73.x
# Navigate to the new working tree
cd .worktrees/backport-7.73.x
# Create a new branch
git switch --create backport-43275-to-7.73.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 433139dd0de0769a16595f3c3c39b6c7a7d666e8
# Push it to GitHub
git push --set-upstream origin backport-43275-to-7.73.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.73.x

Then, create a pull request where the base branch is 7.73.x and the compare/head branch is backport-43275-to-7.73.x.

duncanpharvey pushed a commit that referenced this pull request Nov 24, 2025
### What does this PR do?

Updates all `golang.org/x` modules to their latest versions, including:
- `golang.org/x/sys` from v0.37.0 to v0.38.0
- `golang.org/x/net` from v0.46.0 to v0.47.0
- `golang.org/x/text` from v0.30.0 to v0.31.0
- `golang.org/x/sync` from v0.17.0 to v0.18.0
- `golang.org/x/exp` from v0.0.0-20251009144603-d2f985daa21b to v0.0.0-20251113190631-e25ba8c21ef6
- `golang.org/x/crypto` from v0.43.0 to v0.45.0
- `golang.org/x/oauth2` from v0.32.0 to v0.33.0
- `golang.org/x/term` from v0.36.0 to v0.37.0
- `golang.org/x/mod` from v0.29.0 to v0.30.0
- `golang.org/x/tools` from v0.38.0 to v0.39.0
- `golang.org/x/arch` from v0.22.0 to v0.23.0
- `golang.org/x/telemetry` from v0.0.0-20251008203120-078029d740a8 to v0.0.0-20251111182119-bc8e575c7b54

### Motivation

Keep Go standard library extensions up-to-date

### Describe how you validated your changes
CI should be enough.


Co-authored-by: maxime.riaud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed component/system-probe long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants