-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Bump bazel version: 8.3.1 ➡ 8.4.2
#43273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 30a562e Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.30 | [-0.67, +5.27] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.30 | [-0.67, +5.27] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.51 | [+1.43, +1.59] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.71 | [+0.61, +0.81] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.35 | [+0.30, +0.39] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.32 | [+0.17, +0.48] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.31 | [+0.17, +0.46] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.22 | [+0.15, +0.28] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.21 | [-0.03, +0.45] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.09 | [-0.28, +0.47] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.08 | [+0.03, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.02 | [-0.36, +0.41] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.02 | [-0.39, +0.43] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.08, +0.10] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.00 | [-0.04, +0.05] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.14, +0.13] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.13, +0.12] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.14 | [-0.34, +0.06] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.19 | [-0.24, -0.14] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.39 | [-0.44, -0.34] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -0.43 | [-1.89, +1.02] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | -0.54 | [-0.63, -0.46] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.66 | [-0.87, -0.44] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.18 | [-1.39, -0.97] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
3392739 to
97e19dc
Compare
5733d73 to
00ca4e1
Compare
00ca4e1 to
db06026
Compare
bazel version: 8.3.1 -> 8.4.2bazel version: 8.3.1 → 8.4.2
bazel version: 8.3.1 → 8.4.2bazel version: 8.3.1 ➡ 8.4.2
.gitlab/bazel/defs.yaml
Outdated
| .bazel:runner:linux-amd64: | ||
| cache: [] | ||
| variables: | ||
| BAZELISK_BASE_URL: https://github.com/bazelbuild/bazel/releases/download #TODO(regis): remove once https://binaries.ddbuild.io/bazel works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we put this in //.bazeliskrc?
I just tried creating it and that seems to work along with .bazelversion.
Then it gets picked up by all jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It indeed works, but the runner's environment variable unfortunately takes precedence:
Configuration variables are evaluated with precedence order. The preferred values are derived in order from highest to lowest precedence as follows:
- Variables defined in the environment
- Variables defined in the workspace root .bazeliskrc
- Variables defined in the user home .bazeliskrc
I won't forget that:
I'll get back to mirror maintainers to understand what's wrong on their side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: this got fixed upstream - I therefore removed the workaround.
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
[email protected] unqueued this merge request |
Maybe that is the behavior we want. Only a few people should ever set their own .bazeliskrc. We could also warn ### YOU ARE IN DEVELOPER MODE ### if you have both files. |
|
/remove |
|
View all feedbacks in Devflow UI.
|
|
@tonyaiuto, would you be so kind as to ping @aiuto as an approver instead? 😉 |
db06026 to
5509c4d
Compare
8d93076 to
72ae563
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
### Motivation See: - https://github.com/bazelbuild/bazel/releases/tag/8.4.0 - https://github.com/bazelbuild/bazel/releases/tag/8.4.1 - https://github.com/bazelbuild/bazel/releases/tag/8.4.2 (8.5.0 is due soon) #### Cache & reliability - 8.4.0 honors XDG_CACHE_HOME on macOS, which will definitely help ([ABLD-300](https://datadoghq.atlassian.net/browse/ABLD-300)): bazelbuild/bazel#26773 - 8.4.1 fixes a race condition affecting repository contents cache: bazelbuild/bazel#26950 - 8.4.0 fixes another race condition affecting workers: bazelbuild/bazel#26475 #### Modules - 8.4.0 brings new `--module_mirrors` flag for fallback URLs when primary sources are slow/unavailable: bazelbuild/bazel#26850 - 8.4.0 avoids the need for dummy `MODULE.bazel` files with `git_repository`/`http_archive`: bazelbuild/bazel#26462 - 8.4.2 fixes a maintenance annoyance for `MODULE.bazel.lock` file: bazelbuild/bazel#27111 #### Platforms - 8.4.0 allows to mitigate the long path issue with **MSVC on Windows**: bazelbuild/bazel#26532 - 8.4.2 fixes **macOS** compatibility issues: bazelbuild/bazel#27014 [ABLD-300]: https://datadoghq.atlassian.net/browse/ABLD-300?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: regis.desgroppes <[email protected]>
Motivation
See:
(8.5.0 is due soon)
Cache & reliability
XDG_CACHE_HOMEon macOS, which will definitely help (ABLD-300): [8.4.0] Respect XDG directory settings on macOS bazelbuild/bazel#26773Modules
--module_mirrorsflag for fallback URLs when primary sources are slow/unavailable: [8.4.0] Add--module_mirrorsbazelbuild/bazel#26850MODULE.bazelfiles withgit_repository/http_archive: [8.4.0] Overlay the registryMODULE.bazelfile on the module repo bazelbuild/bazel#26462MODULE.bazel.lockfile: [8.4.2] Clean up default lockfile bazelbuild/bazel#27111Platforms