Skip to content

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Nov 20, 2025

Motivation

See:

(8.5.0 is due soon)

Cache & reliability

Modules

Platforms

@rdesgroppes rdesgroppes added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 20, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 20, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 20, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ada8f58

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0.1}$$ $${705.0}$$ < $${717.44}$$ $${+0.06}$$ $${172.49}$$ < $${177.37}$$
agent_deb_amd64_fips $${+0.09}$$ $${699.05}$$ < $${711.66}$$ $${+0.05}$$ $${171.3}$$ < $${174.84}$$
agent_heroku_amd64 $${+0.12}$$ $${327.46}$$ < $${337.57}$$ $${+0.04}$$ $${87.38}$$ < $${90.78}$$
agent_msi $${+0.22}$$ $${999.82}$$ < $${1015.38}$$ $${+0.01}$$ $${144.45}$$ < $${149.42}$$
agent_rpm_amd64 $${+0.1}$$ $${704.99}$$ < $${717.41}$$ $${+0.02}$$ $${175.74}$$ < $${178.01}$$
agent_rpm_amd64_fips $${+0.09}$$ $${699.03}$$ < $${711.64}$$ $${+0.07}$$ $${173.43}$$ < $${177.26}$$
agent_rpm_arm64 $${+0.08}$$ $${690.28}$$ < $${702.19}$$ $${+0.03}$$ $${159.54}$$ < $${163.22}$$
agent_rpm_arm64_fips $${+0.09}$$ $${685.47}$$ < $${697.6}$$ $${+0.03}$$ $${158.84}$$ < $${162.68}$$
agent_suse_amd64 $${+0.1}$$ $${704.99}$$ < $${717.41}$$ $${+0.02}$$ $${175.74}$$ < $${178.01}$$
agent_suse_amd64_fips $${+0.09}$$ $${699.03}$$ < $${711.64}$$ $${+0.07}$$ $${173.43}$$ < $${177.26}$$
agent_suse_arm64 $${+0.08}$$ $${690.28}$$ < $${702.19}$$ $${+0.03}$$ $${159.54}$$ < $${163.22}$$
agent_suse_arm64_fips $${+0.09}$$ $${685.47}$$ < $${697.6}$$ $${+0.03}$$ $${158.84}$$ < $${162.68}$$
docker_agent_amd64 $${+0.09}$$ $${767.37}$$ < $${769.92}$$ $${+0.05}$$ $${260.39}$$ < $${261.52}$$
docker_agent_arm64 $${+0.08}$$ $${777.02}$$ < $${779.46}$$ $${+0.06}$$ $${250.65}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0.09}$$ $${958.25}$$ < $${960.8}$$ $${+0.04}$$ $${329.02}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+0.08}$$ $${956.62}$$ < $${958.93}$$ $${+0.05}$$ $${315.27}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${-0.02}$$ $${179.19}$$ < $${207.49}$$ $${-0}$$ $${63.23}$$ < $${70.2}$$
docker_cluster_agent_arm64 $${+0}$$ $${196.69}$$ < $${223.38}$$ $${+0.01}$$ $${59.97}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0.01}$$ $${38.54}$$ < $${39.3}$$ $${+0}$$ $${14.9}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.24}$$ < $${37.94}$$ $${+0}$$ $${14.34}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${+0.01}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.85}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${+0.01}$$ $${28.28}$$ < $${29.11}$$ $${+0}$$ $${6.79}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${+0.01}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${+0.01}$$ $${29.76}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 $${+0.04}$$ $${42.48}$$ < $${43.19}$$ $${+0.01}$$ $${11.1}$$ < $${11.98}$$
iot_agent_deb_arm64 $${+0.04}$$ $${40.22}$$ < $${40.92}$$ $${+0.01}$$ $${9.55}$$ < $${10.45}$$
iot_agent_deb_armhf $${+0.04}$$ $${40.13}$$ < $${40.86}$$ $${+0.01}$$ $${9.67}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${+0.04}$$ $${42.48}$$ < $${43.19}$$ $${+0.01}$$ $${11.12}$$ < $${12.0}$$
iot_agent_suse_amd64 $${+0.04}$$ $${42.48}$$ < $${43.19}$$ $${+0.01}$$ $${11.12}$$ < $${12.0}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 20, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: baad043c-b4ad-4a68-941c-55079311fb12

Baseline: 30a562e
Comparison: 72ae563
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.30 [-0.67, +5.27] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.30 [-0.67, +5.27] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.51 [+1.43, +1.59] 1 Logs
otlp_ingest_logs memory utilization +0.71 [+0.61, +0.81] 1 Logs
quality_gate_idle_all_features memory utilization +0.35 [+0.30, +0.39] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.32 [+0.17, +0.48] 1 Logs
otlp_ingest_metrics memory utilization +0.31 [+0.17, +0.46] 1 Logs
ddot_logs memory utilization +0.22 [+0.15, +0.28] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.21 [-0.03, +0.45] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.09 [-0.28, +0.47] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.08 [+0.03, +0.13] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.36, +0.41] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.39, +0.43] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.08, +0.10] 1 Logs
file_tree memory utilization +0.00 [-0.04, +0.05] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.14, +0.13] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.13, +0.12] 1 Logs
ddot_metrics_sum_delta memory utilization -0.14 [-0.34, +0.06] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.19 [-0.24, -0.14] 1 Logs
quality_gate_idle memory utilization -0.39 [-0.44, -0.34] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.43 [-1.89, +1.02] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -0.54 [-0.63, -0.46] 1 Logs
ddot_metrics memory utilization -0.66 [-0.87, -0.44] 1 Logs
quality_gate_metrics_logs memory utilization -1.18 [-1.39, -0.97] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-bazel branch 2 times, most recently from 3392739 to 97e19dc Compare November 21, 2025 13:17
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 21, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-bazel branch 3 times, most recently from 5733d73 to 00ca4e1 Compare November 21, 2025 14:27
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Nov 21, 2025
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-bazel branch from 00ca4e1 to db06026 Compare November 21, 2025 16:24
@rdesgroppes rdesgroppes marked this pull request as ready for review November 21, 2025 16:38
@rdesgroppes rdesgroppes requested a review from a team as a code owner November 21, 2025 16:38
@rdesgroppes rdesgroppes added the ask-review Ask required teams to review this PR label Nov 21, 2025
@rdesgroppes rdesgroppes changed the title Bump bazel version: 8.3.1 -> 8.4.2 Bump bazel version: 8.3.1 → 8.4.2 Nov 21, 2025
@rdesgroppes rdesgroppes changed the title Bump bazel version: 8.3.1 → 8.4.2 Bump bazel version: 8.3.1 ➡ 8.4.2 Nov 21, 2025
.bazel:runner:linux-amd64:
cache: []
variables:
BAZELISK_BASE_URL: https://github.com/bazelbuild/bazel/releases/download #TODO(regis): remove once https://binaries.ddbuild.io/bazel works
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we put this in //.bazeliskrc?
I just tried creating it and that seems to work along with .bazelversion.
Then it gets picked up by all jobs.

Copy link
Contributor Author

@rdesgroppes rdesgroppes Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indeed works, but the runner's environment variable unfortunately takes precedence:

Configuration variables are evaluated with precedence order. The preferred values are derived in order from highest to lowest precedence as follows:

  • Variables defined in the environment
  • Variables defined in the workspace root .bazeliskrc
  • Variables defined in the user home .bazeliskrc

I won't forget that:

I'll get back to mirror maintainers to understand what's wrong on their side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: this got fixed upstream - I therefore removed the workaround.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 21, 2025
@rdesgroppes
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 24, 2025

View all feedbacks in Devflow UI.

2025-11-24 13:27:28 UTC ℹ️ Start processing command /merge


2025-11-24 13:27:37 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-24 15:27:00 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@tonyaiuto
Copy link

It indeed works, but the runner's environment variable unfortunately takes precedence:

Maybe that is the behavior we want. Only a few people should ever set their own .bazeliskrc. We could also warn ### YOU ARE IN DEVELOPER MODE ### if you have both files.

@rdesgroppes
Copy link
Contributor Author

/remove

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 24, 2025

View all feedbacks in Devflow UI.

2025-11-24 15:26:56 UTC ℹ️ Start processing command /remove


2025-11-24 15:27:00 UTC ℹ️ Devflow: /remove

@rdesgroppes
Copy link
Contributor Author

rdesgroppes commented Nov 24, 2025

@tonyaiuto, would you be so kind as to ping @aiuto as an approver instead? 😉

@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-bazel branch from db06026 to 5509c4d Compare November 24, 2025 16:26
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-bazel branch from 8d93076 to 72ae563 Compare November 25, 2025 12:39
@rdesgroppes
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 25, 2025

View all feedbacks in Devflow UI.

2025-11-25 13:47:25 UTC ℹ️ Start processing command /merge


2025-11-25 13:47:33 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-25 13:52:12 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 45m (p90).


2025-11-25 14:12:11 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit cd2b9ac into main Nov 25, 2025
263 checks passed
@dd-mergequeue dd-mergequeue bot deleted the regis.desgroppes/bump-bazel branch November 25, 2025 14:12
@github-actions github-actions bot added this to the 7.74.0 milestone Nov 25, 2025
chouquette pushed a commit that referenced this pull request Nov 27, 2025
### Motivation
See:
- https://github.com/bazelbuild/bazel/releases/tag/8.4.0
- https://github.com/bazelbuild/bazel/releases/tag/8.4.1
- https://github.com/bazelbuild/bazel/releases/tag/8.4.2

(8.5.0 is due soon)

#### Cache & reliability
- 8.4.0 honors XDG_CACHE_HOME on macOS, which will definitely help ([ABLD-300](https://datadoghq.atlassian.net/browse/ABLD-300)): bazelbuild/bazel#26773
- 8.4.1 fixes a race condition affecting repository contents cache: bazelbuild/bazel#26950
- 8.4.0 fixes another race condition affecting workers: bazelbuild/bazel#26475

#### Modules
- 8.4.0 brings new `--module_mirrors` flag for fallback URLs when primary sources are slow/unavailable: bazelbuild/bazel#26850
- 8.4.0 avoids the need for dummy `MODULE.bazel` files with `git_repository`/`http_archive`: bazelbuild/bazel#26462
- 8.4.2 fixes a maintenance annoyance for `MODULE.bazel.lock` file: bazelbuild/bazel#27111

#### Platforms
- 8.4.0 allows to mitigate the long path issue with **MSVC on Windows**: bazelbuild/bazel#26532
- 8.4.2 fixes **macOS** compatibility issues: bazelbuild/bazel#27014

[ABLD-300]: https://datadoghq.atlassian.net/browse/ABLD-300?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: regis.desgroppes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants