[APM] add implementation of span derived primary tags for APM stats by jdgumz · Pull Request #42996 · DataDog/datadog-agent

jdgumz · 2025-11-12T21:01:59Z

This feature adds configuration of span-based primary tags so that when APM stats are calculated, we collect the appropriate tags from spans. We cannot attach these tags in any other way.

Implementing this feature will help serverless customers who cannot rely on container tags for primary tags in APM. It will also help customers who have important span tags that can be used to scope their applications' performance.

agent-platform-auto-pr · 2025-11-12T21:43:48Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 9fd9c72
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+11.91 KiB (0.00% increase)	755.711 → 755.723 → 759.670
✅	agent_deb_amd64_fips	+11.91 KiB (0.00% increase)	714.623 → 714.635 → 720.180
✅	agent_heroku_amd64	+12.0 KiB (0.00% increase)	323.382 → 323.394 → 329.530
✅	agent_msi	+20.0 KiB (0.00% increase)	622.105 → 622.124 → 1073.220
✅	agent_rpm_amd64	+11.91 KiB (0.00% increase)	755.695 → 755.707 → 759.640
✅	agent_rpm_amd64_fips	+11.91 KiB (0.00% increase)	714.607 → 714.619 → 720.160
✅	agent_rpm_arm64	+2.82 KiB (0.00% increase)	733.980 → 733.983 → 741.840
✅	agent_rpm_arm64_fips	+6.82 KiB (0.00% increase)	695.799 → 695.806 → 703.390
✅	agent_suse_amd64	+11.91 KiB (0.00% increase)	755.695 → 755.707 → 759.640
✅	agent_suse_amd64_fips	+11.91 KiB (0.00% increase)	714.607 → 714.619 → 720.160
✅	agent_suse_arm64	+2.82 KiB (0.00% increase)	733.980 → 733.983 → 741.840
✅	agent_suse_arm64_fips	+6.82 KiB (0.00% increase)	695.799 → 695.806 → 703.390
✅	docker_agent_amd64	+11.92 KiB (0.00% increase)	816.761 → 816.773 → 821.990
✅	docker_agent_arm64	+2.81 KiB (0.00% increase)	819.765 → 819.768 → 828.520
✅	docker_agent_jmx_amd64	+11.92 KiB (0.00% increase)	1007.672 → 1007.684 → 1012.870
✅	docker_agent_jmx_arm64	+2.82 KiB (0.00% increase)	999.459 → 999.462 → 1008.120
✅	docker_cluster_agent_amd64	+4.67 KiB (0.00% increase)	190.054 → 190.059 → 191.320
✅	dogstatsd_deb_amd64	+4.0 KiB (0.01% increase)	29.716 → 29.720 → 30.610
✅	dogstatsd_deb_arm64	+4.0 KiB (0.01% increase)	27.872 → 27.876 → 29.110
✅	dogstatsd_rpm_amd64	+4.0 KiB (0.01% increase)	29.716 → 29.720 → 30.610
✅	dogstatsd_suse_amd64	+4.0 KiB (0.01% increase)	29.716 → 29.720 → 30.610
✅	iot_agent_deb_amd64	+4.0 KiB (0.01% increase)	42.605 → 42.609 → 43.290
✅	iot_agent_rpm_amd64	+4.0 KiB (0.01% increase)	42.605 → 42.609 → 43.290
✅	iot_agent_suse_amd64	+4.0 KiB (0.01% increase)	42.605 → 42.609 → 43.290

7 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	docker_cluster_agent_arm64	205.440 MiB
✅	docker_cws_instrumentation_amd64	7.135 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	38.496 MiB
✅	docker_dogstatsd_arm64	36.812 MiB
✅	iot_agent_deb_arm64	39.710 MiB
✅	iot_agent_deb_armhf	40.435 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-7.41 KiB (0.00% reduction)	185.226 → 185.218 → 186.090
✅	agent_deb_amd64_fips	-44.04 KiB (0.02% reduction)	176.147 → 176.104 → 180.330
✅	agent_heroku_amd64	-10.13 KiB (0.01% reduction)	87.228 → 87.218 → 88.440
✅	agent_msi	+8.0 KiB (0.01% increase)	138.363 → 138.371 → 143.470
✅	agent_rpm_amd64	+27.68 KiB (0.01% increase)	187.112 → 187.139 → 189.170
✅	agent_rpm_amd64_fips	+10.77 KiB (0.01% increase)	178.193 → 178.203 → 181.060
✅	agent_rpm_arm64	-23.16 KiB (0.01% reduction)	169.281 → 169.259 → 170.020
✅	agent_rpm_arm64_fips	+42.84 KiB (0.03% increase)	162.224 → 162.266 → 164.130
✅	agent_suse_amd64	+27.68 KiB (0.01% increase)	187.112 → 187.139 → 189.170
✅	agent_suse_amd64_fips	+10.77 KiB (0.01% increase)	178.193 → 178.203 → 181.060
✅	agent_suse_arm64	-23.16 KiB (0.01% reduction)	169.281 → 169.259 → 170.020
✅	agent_suse_arm64_fips	+42.84 KiB (0.03% increase)	162.224 → 162.266 → 164.130
✅	docker_agent_amd64	+12.46 KiB (0.00% increase)	277.506 → 277.518 → 279.410
✅	docker_agent_arm64	-3.11 KiB (0.00% reduction)	264.832 → 264.829 → 267.960
✅	docker_agent_jmx_amd64	+14.02 KiB (0.00% increase)	346.151 → 346.165 → 348.040
✅	docker_agent_jmx_arm64	-10.96 KiB (0.00% reduction)	329.474 → 329.463 → 332.560
✅	docker_cluster_agent_amd64	-3.37 KiB (0.00% reduction)	66.436 → 66.433 → 67.220
✅	docker_cluster_agent_arm64	neutral	62.483 MiB → 63.640
✅	docker_cws_instrumentation_amd64	neutral	2.995 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.726 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	14.903 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.235 MiB → 14.830
✅	dogstatsd_deb_amd64	neutral	7.853 MiB → 8.790
✅	dogstatsd_deb_arm64	neutral	6.741 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.864 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.864 MiB → 8.800
✅	iot_agent_deb_amd64	-2.41 KiB (0.02% reduction)	11.235 → 11.232 → 12.040
✅	iot_agent_deb_arm64	neutral	9.599 MiB → 10.450
✅	iot_agent_deb_armhf	-4.27 KiB (0.04% reduction)	9.802 → 9.798 → 10.620
✅	iot_agent_rpm_amd64	neutral	11.252 MiB → 12.060
✅	iot_agent_suse_amd64	neutral	11.252 MiB → 12.060

cit-pr-commenter · 2025-11-12T22:03:29Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c46283ac-058a-4afe-abf7-5a20f6b3ba25

Baseline: 9fd9c72
Comparison: fc06eaf
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.51	[-1.62, +4.64]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_memory	memory utilization	+1.56	[+1.42, +1.70]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+1.51	[-1.62, +4.64]	1	Logs
➖	quality_gate_logs	% cpu utilization	+1.07	[-0.45, +2.60]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.41	[+0.33, +0.48]	1	Logs
➖	quality_gate_idle	memory utilization	+0.18	[+0.13, +0.22]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	+0.10	[+0.04, +0.16]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.04	[-0.39, +0.47]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.03	[-0.02, +0.08]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.02	[-0.21, +0.25]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.01	[-0.12, +0.13]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.04, +0.05]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.10, +0.09]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.13, +0.11]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.50, +0.46]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.03	[-0.23, +0.18]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	-0.07	[-0.22, +0.09]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.08	[-0.46, +0.30]	1	Logs
➖	ddot_metrics	memory utilization	-0.10	[-0.32, +0.11]	1	Logs
➖	file_tree	memory utilization	-0.19	[-0.24, -0.13]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.19	[-0.23, -0.15]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	-0.21	[-0.40, -0.02]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.50	[-0.66, -0.34]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.62	[-0.71, -0.52]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

pkg/proto/datadog/trace/stats.proto

pkg/trace/stats/span_concentrator.go

github-actions · 2026-02-18T16:11:52Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Sam-Maya · 2026-02-18T16:32:15Z

I have read the CLA Document and I hereby sign the CLA

pkg/config/setup/apm.go

comp/trace/config/setup.go

dustmop · 2026-02-19T02:13:54Z

pkg/config/setup/apm.go

+	config.BindEnvAndSetDefault("apm_config.span_derived_primary_tags", []string{}, "DD_APM_SPAN_DERIVED_PRIMARY_TAGS")
+	config.ParseEnvAsStringSlice("apm_config.span_derived_primary_tags", func(in string) []string {
+		var out []string
+		if err := json.Unmarshal([]byte(in), &out); err != nil {


Just to verify this is what you want: if this setting is configured as an env var then the value has to be json. DD_APM_SPAN_DERIVED_PRIMARY_TAGS=key:value won't work, but DD_APM_SPAN_DERIVED_PRIMARY_TAGS=["key":"value"] will.

This will only store the keys so DD_APM_SPAN_DERIVED_PRIMARY_TAGS='["key1","key2"]' is the intended behavior.

ichinaski

Leaving the PR approved, but there are a few follow ups needed for this new feature:

Add a new revision to the Client-Side Stats spec
Implement the required changes on the trace-agent to expose the new setting
Implement the new feature on SDKs with CSS: dd-trace-go and dd-trace-java, libdatadog
Add system-tests to verify the behavior and feature parity

pkg/config/setup/apm.go

@Sam-Maya

…7] (#1630) # What does this PR do? Add two fields to `ClientGroupedStats`: 1. `service_source` 2. `span_derived_primary_tags` It syncs the changes on datadog-agent. See pkg/proto/datadog/trace/stats.proto in DataDog/datadog-agent#42996. # Motivation To support span derived primary tags for trace stats generated in Lambda extension. # Additional Notes @Sam-Maya is driving this effort. # How to test the change? This PR only includes struct changes in this PR. Will set and test the struct in future PRs. Co-authored-by: yiming.luo <[email protected]>

add implementation of span derived primary tags for APM stats

31b7ce7

jdgumz added the do-not-merge/WIP label Nov 12, 2025

github-actions bot added team/agent-apm trace-agent long review PR is complex, plan time to review it labels Nov 12, 2025

add msgpack encoding

1eb14e7

apiarian-datadog reviewed Dec 12, 2025

View reviewed changes

pkg/proto/datadog/trace/stats.proto Show resolved Hide resolved

pkg/trace/stats/span_concentrator.go Outdated Show resolved Hide resolved

pkg/trace/stats/span_concentrator.go Outdated Show resolved Hide resolved

dd-octo-sts bot added internal Identify a non-fork PR team/agent-configuration labels Feb 18, 2026

Merge main into apm/span-based-primary-tag-config

53e7aa2

Sam-Maya force-pushed the apm/span-based-primary-tag-config branch from a3a031d to 53e7aa2 Compare February 18, 2026 16:28

jdgumz marked this pull request as ready for review February 18, 2026 21:11

jdgumz requested review from a team as code owners February 18, 2026 21:11

jdgumz requested a review from s-alad February 18, 2026 21:11

s-alad approved these changes Feb 19, 2026

View reviewed changes

pkg/config/setup/apm.go Outdated Show resolved Hide resolved

Sam-Maya added 3 commits February 18, 2026 20:45

change var name

7779e27

add BindEnvAndSetDefault

444ec36

formatting

6d7cca0

dustmop reviewed Feb 19, 2026

View reviewed changes

use IsConfigured

e78f75a

Sam-Maya requested a review from dustmop February 19, 2026 04:51

hush-hush approved these changes Feb 19, 2026

View reviewed changes

ichinaski approved these changes Feb 19, 2026

View reviewed changes

pkg/config/setup/apm.go Show resolved Hide resolved

Sam-Maya added the qa/done QA done before merge and regressions are covered by tests label Feb 19, 2026

return nil when parsing fails

5b00091

Sam-Maya removed the qa/done QA done before merge and regressions are covered by tests label Feb 19, 2026

add reno

fc06eaf

Sam-Maya requested a review from a team as a code owner February 19, 2026 16:25

Sam-Maya added qa/done QA done before merge and regressions are covered by tests and removed do-not-merge/WIP labels Feb 19, 2026

joepeeples approved these changes Feb 19, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d bot merged commit bdcdd8c into main Feb 19, 2026
307 of 310 checks passed

gh-worker-dd-mergequeue-cf854d bot deleted the apm/span-based-primary-tag-config branch February 19, 2026 19:13

github-actions bot added this to the 7.77.0 milestone Feb 19, 2026

lym953 mentioned this pull request Mar 2, 2026

feat(trace-protobuf)!: Add two fields to ClientGroupedStats [SVLS-8627] DataDog/libdatadog#1630

Merged

Conversation

jdgumz commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter bot commented Nov 12, 2025 • edited by cit-pr-commenter-54b7da bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sam-Maya commented Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

dustmop Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Sam-Maya Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

ichinaski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jdgumz commented Nov 12, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Nov 12, 2025 •

edited

Loading

cit-pr-commenter bot commented Nov 12, 2025 •

edited by cit-pr-commenter-54b7da bot

Loading

github-actions bot commented Feb 18, 2026 •

edited

Loading