[Serverless] Remove Lambda Extension#42994
Conversation
| defer traceAgent.Stop() | ||
| defer metricAgent.Stop() | ||
| assert.Subset(t, metricAgent.GetExtraTags(), allTags) | ||
| assert.Subset(t, logs.GetLogsTags(), allTags) |
There was a problem hiding this comment.
Before these changes, this GetLogsTags() method was not used anywhere except for this test
| @@ -1,201 +0,0 @@ | |||
| // Unless explicitly stated otherwise all files in this repository are licensed | |||
| // under the Apache License Version 2.0. | |||
There was a problem hiding this comment.
In AWS, pkg/serverless/apikey/... handles decryption of secrets for AWS KMS & SecretsManager. There is no Azure/GCP logic here, so it can be safely removed.
| func GetLogsTags() []string { | ||
| if logsScheduler != nil { | ||
| return logsScheduler.GetLogsTags() | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
this func was not used anywhere other than in a unit test
nhulston
added
the
qa/done
|
lgtm |
gabedos
left a comment
gabedos
left a comment
There was a problem hiding this comment.
lgtm removing lambda env detection
dustmop
left a comment
dustmop
left a comment
There was a problem hiding this comment.
LGTM for agent-configuration owned files
| API_KEY: x |
There was a problem hiding this comment.
Your attention to detail is commendable.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
17 participants
What does this PR do?
serverless-init, which is used for Serverless containers like Google Cloud Run. So we must keep any references toserverlessthat are used byserverless-initMotivation
Lambda Extension is deprecated, but lots of the logic was tightly coupled with serverless-init.
Public blog post
https://www.datadoghq.com/blog/engineering/datadog-lambda-extension-rust/
Internal links
https://datadoghq.atlassian.net/browse/SVLS-7955
https://dd.slack.com/archives/C0813DKJMS5/p1762894639463349
Describe how you validated your changes
Built and tested serverless-init in Cloud Run
Additional Notes