[Serverless] Change serverless-init log level & remove noisy logs by nhulston · Pull Request #42657 · DataDog/datadog-agent

nhulston · 2025-11-03T20:17:14Z

What does this PR do?

Change default log level from off to error
In in-container mode, change startup errors to error log level
Remove noisy error & warn logs in serverless-init

Motivation

#27083
https://datadoghq.atlassian.net/browse/SVLS-7891

Describe how you validated your changes

Manually

Additional Notes

agent-platform-auto-pr · 2025-11-03T20:59:06Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d01a85a

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0.01}$$	$${688.27}$$ < $${695.26}$$	$${+0.06}$$	$${167.9}$$ < $${171.42}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${682.62}$$ < $${689.56}$$	$${+0.01}$$	$${166.21}$$ < $${168.75}$$
✅	agent_heroku_amd64	$${+0}$$	$${336.7}$$ < $${337.56}$$	$${-0.01}$$	$${89.82}$$ < $${90.78}$$
✅	agent_msi	$${+0.01}$$	$${1002.29}$$ < $${1015.38}$$	$${-0.01}$$	$${145.32}$$ < $${149.42}$$
✅	agent_rpm_amd64	$${+0.01}$$	$${688.26}$$ < $${695.24}$$	$${+0}$$	$${170.44}$$ < $${172.66}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${682.6}$$ < $${689.55}$$	$${+0.03}$$	$${169.33}$$ < $${171.31}$$
✅	agent_rpm_arm64	$${+0}$$	$${677.58}$$ < $${684.17}$$	$${+0.01}$$	$${155.66}$$ < $${158.47}$$
✅	agent_rpm_arm64_fips	$${+0.01}$$	$${673.02}$$ < $${679.54}$$	$${+0.04}$$	$${154.34}$$ < $${156.53}$$
✅	agent_suse_amd64	$${+0.01}$$	$${688.26}$$ < $${695.24}$$	$${+0}$$	$${170.44}$$ < $${172.66}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${682.6}$$ < $${689.55}$$	$${+0.03}$$	$${169.33}$$ < $${171.31}$$
✅	agent_suse_arm64	$${+0}$$	$${677.58}$$ < $${684.17}$$	$${+0.01}$$	$${155.66}$$ < $${158.47}$$
✅	agent_suse_arm64_fips	$${+0.01}$$	$${673.02}$$ < $${679.54}$$	$${+0.04}$$	$${154.34}$$ < $${156.53}$$
✅	docker_agent_amd64	$${+0.01}$$	$${746.99}$$ < $${747.75}$$	$${-0.01}$$	$${251.73}$$ < $${252.67}$$
✅	docker_agent_arm64	$${+0}$$	$${760.76}$$ < $${761.44}$$	$${-0}$$	$${242.25}$$ < $${243.19}$$
✅	docker_agent_jmx_amd64	$${+0.01}$$	$${937.86}$$ < $${938.63}$$	$${+0}$$	$${320.36}$$ < $${321.29}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${940.23}$$ < $${940.91}$$	$${-0.01}$$	$${306.85}$$ < $${307.81}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${206.55}$$ < $${207.49}$$	$${-0}$$	$${69.24}$$ < $${70.2}$$
✅	docker_cluster_agent_arm64	$${+0}$$	$${222.43}$$ < $${223.38}$$	$${+0.02}$$	$${65.48}$$ < $${66.42}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${-0}$$	$${6.69}$$ < $${6.92}$$	$${-0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.47}$$ < $${39.3}$$	$${-0}$$	$${14.85}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${-0}$$	$${37.12}$$ < $${37.94}$$	$${-0}$$	$${14.29}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.69}$$ < $${30.53}$$	$${-0}$$	$${7.82}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.21}$$ < $${29.11}$$	$${+0}$$	$${6.76}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.69}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.69}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${+0}$$	$${42.24}$$ < $${43.19}$$	$${-0}$$	$${11.03}$$ < $${11.98}$$
✅	iot_agent_deb_arm64	$${0}$$	$${39.98}$$ < $${40.92}$$	$${+0}$$	$${9.49}$$ < $${10.45}$$
✅	iot_agent_deb_armhf	$${0}$$	$${39.91}$$ < $${40.86}$$	$${-0}$$	$${9.61}$$ < $${10.56}$$
✅	iot_agent_rpm_amd64	$${+0}$$	$${42.24}$$ < $${43.19}$$	$${-0}$$	$${11.04}$$ < $${12.0}$$
✅	iot_agent_suse_amd64	$${+0}$$	$${42.24}$$ < $${43.19}$$	$${-0}$$	$${11.04}$$ < $${12.0}$$

cit-pr-commenter · 2025-11-03T22:08:25Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ed539368-6ec0-4b59-b159-3f28c55ccebf

Baseline: d01a85a
Comparison: 50fa44d
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-0.01	[-1.00, +0.98]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_memory	memory utilization	+2.99	[+2.53, +3.44]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+2.76	[+2.52, +3.00]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.79	[+0.72, +0.86]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.72	[+0.68, +0.76]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	+0.68	[+0.61, +0.75]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.49	[+0.28, +0.69]	1	Logs
➖	ddot_metrics	memory utilization	+0.48	[+0.26, +0.71]	1	Logs
➖	file_tree	memory utilization	+0.39	[+0.34, +0.43]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.19	[+0.03, +0.34]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.13	[-0.10, +0.37]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.13	[-0.49, +0.74]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.05	[-0.55, +0.66]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.58, +0.63]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.22, +0.24]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-0.01	[-1.00, +0.98]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.05	[-0.66, +0.55]	1	Logs
➖	quality_gate_idle	memory utilization	-0.07	[-0.11, -0.03]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.16	[-0.21, -0.11]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.52	[-0.68, -0.36]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.73	[-0.82, -0.63]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.08	[-3.85, +1.68]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

…up-err-to-stderr

nhulston · 2025-11-06T20:20:00Z

+	// Disable UDS listener for serverless environments - traces are sent via HTTP to localhost instead.
+	// This avoids noisy error logs.
+	pkgconfigsetup.Datadog().Set("apm_config.receiver_socket", "", model.SourceAgentRuntime)
+


In mode.go I also tried setting DD_APM_RECEIVER_SOCKET=""

But:

By default, empty environment variables are considered unset and will fall back to the next configuration source, unless AllowEmptyEnv is used.

(according to https://github.com/spf13/viper)

So this was the only working solution

…rnings

changed changelog

git-thuerk-done

looks good for docs

rahulkaukuntla

LGTM for Agent Configuration-owned files

apiarian-datadog · 2025-11-11T16:05:16Z

+	// This commonly occurs in serverless environments like Cloud Run or Azure Container Apps
+	// where Kubernetes metadata is not available.
+	if strings.TrimSpace(valueFromConfig) == "" {
+		return map[string]map[string]string{}


should we gate this early return on detecting that this is running in a serverless environment? others may still care about the errors

I don't think we can detect easily if we're in a serverless environment. Especially in sidecar mode--the sidecar has no special env vars to indicate we're in serverless.

Alternatively, I can add back a log but lower it to debug? What do you think?

nhulston · 2025-11-12T14:38:24Z

/merge

dd-devflow-routing-codex · 2025-11-12T14:38:28Z

View all feedbacks in Devflow UI.

2025-11-12 14:38:27 UTC ℹ️ Start processing command /merge

2025-11-12 14:38:32 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-11-12 15:59:21 UTC ℹ️ MergeQueue: This merge request was merged

print startup error to stderr

6ec5655

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Nov 3, 2025

nhulston added team/serverless-azure-gcp qa/done QA done before merge and regressions are covered by tests labels Nov 3, 2025

changelog

2577fab

nhulston marked this pull request as ready for review November 3, 2025 21:51

nhulston requested review from a team as code owners November 3, 2025 21:51

apiarian-datadog reviewed Nov 3, 2025

View reviewed changes

Comment thread cmd/serverless-init/mode/initcontainer_mode.go Outdated

git-thuerk-done previously approved these changes Nov 3, 2025

View reviewed changes

github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 4, 2025

nhulston requested a review from apiarian-datadog November 4, 2025 19:44

nhulston added 3 commits November 5, 2025 10:54

Merge branch 'main' into nicholas.hulston/serverless-init-print-start…

11c3db0

…up-err-to-stderr

(fix): change default log level to INFO

cfb6461

change log from stderr to log.Errorf

6d32dc0

nhulston changed the title ~~[Serverless] Print startup errors to stdout~~ [Serverless] Change serverless-init log level Nov 5, 2025

nhulston added 4 commits November 6, 2025 14:48

changelog

6ead2a3

change default log level to error

3822449

(nit): fix func comment

5871647

Skip noisy Kubernetes metadata error logs

f91ae23

nhulston changed the title ~~[Serverless] Change serverless-init log level~~ [Serverless] Change serverless-init log level & remove noisy logs Nov 6, 2025

nhulston added 2 commits November 6, 2025 15:18

disable UDS listener in serverless-init

43c2a9e

update changelog

5cf1da9

nhulston requested a review from a team as a code owner November 6, 2025 20:19

nhulston requested a review from rahulkaukuntla November 6, 2025 20:19

nhulston commented Nov 6, 2025

View reviewed changes

fix(serverless): set defaults for non-relevant configs to suppress wa…

50fa44d

…rnings

nhulston requested a review from git-thuerk-done November 6, 2025 21:05

git-thuerk-done approved these changes Nov 6, 2025

View reviewed changes

rahulkaukuntla approved these changes Nov 10, 2025

View reviewed changes

apiarian-datadog approved these changes Nov 11, 2025

View reviewed changes

dd-mergequeue Bot merged commit 1bc2941 into main Nov 12, 2025
292 checks passed

dd-mergequeue Bot deleted the nicholas.hulston/serverless-init-print-startup-err-to-stderr branch November 12, 2025 15:59

github-actions Bot added this to the 7.74.0 milestone Nov 12, 2025

Uh oh!

Conversation

nhulston commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

agent-platform-auto-pr Bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

Uh oh!

cit-pr-commenter Bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

nhulston Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

git-thuerk-done left a comment

Choose a reason for hiding this comment

Uh oh!

rahulkaukuntla left a comment

Choose a reason for hiding this comment

Uh oh!

apiarian-datadog Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

nhulston Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

nhulston commented Nov 12, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nhulston commented Nov 3, 2025 •

edited

Loading

agent-platform-auto-pr Bot commented Nov 3, 2025 •

edited

Loading

cit-pr-commenter Bot commented Nov 3, 2025 •

edited

Loading

nhulston Nov 6, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Nov 12, 2025 •

edited

Loading