Skip to content

Replace serverless logger with log wrapper#42496

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
pgimalac/serverless-init-use-log-wrapper
Nov 6, 2025
Merged

Replace serverless logger with log wrapper#42496
dd-mergequeue[bot] merged 2 commits into
mainfrom
pgimalac/serverless-init-use-log-wrapper

Conversation

@pgimalac

@pgimalac pgimalac commented Oct 30, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Replace serverless logger with log wrapper.

Motivation

Code clean up.
Eventually reduce log package API surface.

Describe how you validated your changes

CI

Additional Notes

@pgimalac pgimalac added changelog/no-changelog No changelog entry needed team/serverless-azure-gcp qa/done QA done before merge and regressions are covered by tests labels Oct 30, 2025
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Oct 30, 2025
@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 81d499c

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 DataNotFound $${677.35}$$ < $${702.15}$$ DataNotFound $${165.31}$$ < $${177.79}$$
✅ agent_deb_amd64_fips DataNotFound $${671.72}$$ < $${696.65}$$ DataNotFound $${164.14}$$ < $${176.53}$$
✅ agent_heroku_amd64 DataNotFound $${336.58}$$ < $${340.18}$$ DataNotFound $${89.82}$$ < $${91.08}$$
✅ agent_msi DataNotFound $${1014.02}$$ < $${1015.38}$$ DataNotFound $${148.37}$$ < $${150.78}$$
✅ agent_rpm_amd64 DataNotFound $${677.34}$$ < $${702.14}$$ DataNotFound $${167.56}$$ < $${180.53}$$
✅ agent_rpm_amd64_fips DataNotFound $${671.71}$$ < $${696.64}$$ DataNotFound $${166.18}$$ < $${178.79}$$
✅ agent_rpm_arm64 DataNotFound $${667.12}$$ < $${686.31}$$ DataNotFound $${153.51}$$ < $${161.22}$$
✅ agent_rpm_arm64_fips DataNotFound $${662.7}$$ < $${681.84}$$ DataNotFound $${152.54}$$ < $${160.18}$$
✅ agent_suse_amd64 DataNotFound $${677.34}$$ < $${702.14}$$ DataNotFound $${167.56}$$ < $${180.53}$$
✅ agent_suse_amd64_fips DataNotFound $${671.71}$$ < $${696.64}$$ DataNotFound $${166.18}$$ < $${178.79}$$
✅ agent_suse_arm64 DataNotFound $${667.12}$$ < $${686.31}$$ DataNotFound $${153.51}$$ < $${161.22}$$
✅ agent_suse_arm64_fips DataNotFound $${662.7}$$ < $${681.84}$$ DataNotFound $${152.54}$$ < $${160.18}$$
✅ docker_agent_amd64 DataNotFound $${747.89}$$ < $${773.59}$$ DataNotFound $${252.2}$$ < $${266.06}$$
✅ docker_agent_arm64 DataNotFound $${761.62}$$ < $${781.7}$$ DataNotFound $${242.74}$$ < $${251.85}$$
✅ docker_agent_jmx_amd64 DataNotFound $${938.77}$$ < $${964.45}$$ DataNotFound $${320.84}$$ < $${334.68}$$
✅ docker_agent_jmx_arm64 DataNotFound $${941.09}$$ < $${961.17}$$ DataNotFound $${307.34}$$ < $${316.44}$$
✅ docker_cluster_agent_amd64 DataNotFound $${213.72}$$ < $${213.74}$$ DataNotFound $${72.51}$$ < $${73.14}$$
✅ docker_cluster_agent_arm64 DataNotFound $${229.61}$$ < $${229.68}$$ DataNotFound $${68.75}$$ < $${69.41}$$
✅ docker_cws_instrumentation_amd64 DataNotFound $${7.07}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 DataNotFound $${38.43}$$ < $${39.3}$$ DataNotFound $${14.84}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 DataNotFound $${37.12}$$ < $${37.94}$$ DataNotFound $${14.29}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 DataNotFound $${29.65}$$ < $${30.53}$$ DataNotFound $${7.82}$$ < $${8.75}$$
✅ dogstatsd_deb_arm64 DataNotFound $${28.24}$$ < $${29.11}$$ DataNotFound $${6.77}$$ < $${7.71}$$
✅ dogstatsd_rpm_amd64 DataNotFound $${29.65}$$ < $${30.53}$$ DataNotFound $${7.83}$$ < $${8.76}$$
✅ dogstatsd_suse_amd64 DataNotFound $${29.65}$$ < $${30.53}$$ DataNotFound $${7.83}$$ < $${8.76}$$
✅ iot_agent_deb_amd64 DataNotFound $${42.33}$$ < $${54.97}$$ DataNotFound $${11.05}$$ < $${14.45}$$
✅ iot_agent_deb_arm64 DataNotFound $${40.12}$$ < $${51.9}$$ DataNotFound $${9.54}$$ < $${12.63}$$
✅ iot_agent_deb_armhf DataNotFound $${40.04}$$ < $${51.84}$$ DataNotFound $${9.64}$$ < $${12.74}$$
✅ iot_agent_rpm_amd64 DataNotFound $${42.33}$$ < $${54.97}$$ DataNotFound $${11.07}$$ < $${14.47}$$
✅ iot_agent_suse_amd64 DataNotFound $${42.33}$$ < $${54.97}$$ DataNotFound $${11.07}$$ < $${14.47}$$

@cit-pr-commenter

cit-pr-commenter Bot commented Oct 30, 2025

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 139baa0b-20c0-4eaa-a8d1-85a9fe9662ca

Baseline: 274934e
Comparison: b55c68e
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_memory memory utilization +14.25 [+13.78, +14.71] 1 Logs

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
✅ docker_containers_cpu % cpu utilization -12.23 [-13.81, -10.66] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_memory memory utilization +14.25 [+13.78, +14.71] 1 Logs
➖ quality_gate_logs % cpu utilization +3.23 [+0.43, +6.04] 1 Logs bounds checks dashboard
➖ ddot_metrics memory utilization +0.20 [+0.01, +0.39] 1 Logs
➖ ddot_metrics_sum_delta memory utilization +0.19 [+0.02, +0.37] 1 Logs
➖ ddot_logs memory utilization +0.16 [+0.10, +0.22] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.11 [-0.49, +0.71] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.11 [-0.10, +0.32] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.07 [-0.06, +0.20] 1 Logs
➖ otlp_ingest_logs memory utilization +0.07 [-0.02, +0.15] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.03 [-0.57, +0.63] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.00 [-0.59, +0.59] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.25, +0.22] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.02 [-0.61, +0.58] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.12 [-0.17, -0.07] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.18 [-0.22, -0.14] 1 Logs bounds checks dashboard
➖ file_tree memory utilization -0.21 [-0.26, -0.17] 1 Logs
➖ quality_gate_idle memory utilization -0.25 [-0.29, -0.21] 1 Logs bounds checks dashboard
➖ otlp_ingest_metrics memory utilization -0.32 [-0.46, -0.17] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.91 [-0.97, -0.85] 1 Logs
➖ quality_gate_metrics_logs memory utilization -1.83 [-2.05, -1.62] 1 Logs bounds checks dashboard
✅ docker_containers_cpu % cpu utilization -12.23 [-13.81, -10.66] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@pgimalac
pgimalac marked this pull request as ready for review October 30, 2025 17:40
@pgimalac
pgimalac requested a review from a team as a code owner October 30, 2025 17:40
@pgimalac pgimalac added the ask-review Ask in slack required teams to review this PR label Oct 30, 2025
nhulston
nhulston approved these changes Nov 5, 2025
View reviewed changes

@nhulston nhulston left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built serverless-init and ran in a real container; everything looks good. Thanks for this!

@pgimalac

pgimalac commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 6, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-06 12:35:56 UTC ℹ️ Start processing command /merge

2025-11-06 12:36:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 60m (p90).

2025-11-06 13:06:37 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit e89e966 into main Nov 6, 2025
291 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the pgimalac/serverless-init-use-log-wrapper branch November 6, 2025 13:06
@github-actions github-actions Bot added this to the 7.74.0 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nhulston nhulston nhulston approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ask-review Ask in slack required teams to review this PR changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/serverless-azure-gcp

Projects

None yet

Milestone

7.74.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pgimalac @nhulston