Revert "Revert "[ACIX-835] Update testify to v1.11.1" (#42017)" #42020

L3n41c · 2025-10-16T08:16:54Z

This reverts commit aa9e94f.

What does this PR do?

Re-apply #41981 and fix the tests that it broke.

Motivation

Same as #41981: speed up tests execution thanks to stretchr/testify#1427 that makes require.EventuallyWithT test the condition immediately instead of waiting for an initial delay before making the very first try.

Describe how you validated your changes

Launched a full pipeline to be sure to run all the tests and not a subset of them: #42020 (comment)

Additional Notes

The main feature we were looking for by upgrading testify to v1.11.1 was the fact that that require.EventuallyWithT is now evaluating the condition the first time immediately instead of waiting for a tick delay before making the first try.
This unexpectedly broke the tests that are touched in this PR.
Fixing tests by adding a time.Sleep(…) is most probably not the smartest way of fixing them. But it restores the execution time flow of the previous versions of testify that happened to make the tests pass.

This reverts commit aa9e94f.

L3n41c · 2025-10-16T08:17:38Z

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

dd-devflow-routing-codex · 2025-10-16T08:17:41Z

View all feedbacks in Devflow UI.

2025-10-16 08:17:41 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

2025-10-16 08:17:57 UTC ℹ️ Branch synced on Gitlab

Branch lenaic/ACIX-835 was out-of-sync on Gitlab - it has been resynced

2025-10-16 08:18:56 UTC ℹ️ Gitlab pipeline started

Started pipeline #79458283

L3n41c · 2025-10-16T08:58:45Z

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

dd-devflow-routing-codex · 2025-10-16T08:58:48Z

View all feedbacks in Devflow UI.

2025-10-16 08:58:47 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

2025-10-16 08:59:44 UTC ℹ️ Gitlab pipeline started

Started pipeline #79462344

agent-platform-auto-pr · 2025-10-16T09:10:22Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d54f5f9

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${-0.02}$$	$${674.8}$$ < $${702.15}$$	$${+0.01}$$	$${164.66}$$ < $${177.79}$$
✅	agent_deb_amd64_fips	$${-0.02}$$	$${669.31}$$ < $${696.65}$$	$${+0.01}$$	$${163.88}$$ < $${176.53}$$
✅	agent_heroku_amd64	$${-0.01}$$	$${336.54}$$ < $${340.18}$$	$${+0}$$	$${89.83}$$ < $${91.08}$$
✅	agent_msi	$${0}$$	$${1013.63}$$ < $${1015.38}$$	$${-0.01}$$	$${148.42}$$ < $${150.78}$$
✅	agent_rpm_amd64	$${-0.02}$$	$${674.79}$$ < $${702.14}$$	$${-0.03}$$	$${166.94}$$ < $${180.53}$$
✅	agent_rpm_amd64_fips	$${-0.02}$$	$${669.29}$$ < $${696.64}$$	$${+0.01}$$	$${165.53}$$ < $${178.79}$$
✅	agent_rpm_arm64	$${-0.01}$$	$${664.39}$$ < $${686.31}$$	$${-0.01}$$	$${153.2}$$ < $${161.22}$$
✅	agent_rpm_arm64_fips	$${-0.01}$$	$${659.91}$$ < $${681.84}$$	$${-0.01}$$	$${152.69}$$ < $${160.18}$$
✅	agent_suse_amd64	$${-0.02}$$	$${674.79}$$ < $${702.14}$$	$${-0.03}$$	$${166.94}$$ < $${180.53}$$
✅	agent_suse_amd64_fips	$${-0.02}$$	$${669.29}$$ < $${696.64}$$	$${+0.01}$$	$${165.53}$$ < $${178.79}$$
✅	agent_suse_arm64	$${-0.01}$$	$${664.39}$$ < $${686.31}$$	$${-0.01}$$	$${153.2}$$ < $${161.22}$$
✅	agent_suse_arm64_fips	$${-0.01}$$	$${659.91}$$ < $${681.84}$$	$${-0.01}$$	$${152.69}$$ < $${160.18}$$
✅	docker_agent_amd64	$${-0.01}$$	$${746.23}$$ < $${773.59}$$	$${-0}$$	$${251.82}$$ < $${266.06}$$
✅	docker_agent_arm64	$${-0.01}$$	$${759.78}$$ < $${781.7}$$	$${-0}$$	$${242.44}$$ < $${251.85}$$
✅	docker_agent_jmx_amd64	$${-0.01}$$	$${937.1}$$ < $${964.45}$$	$${-0}$$	$${320.46}$$ < $${334.68}$$
✅	docker_agent_jmx_arm64	$${-0.01}$$	$${939.25}$$ < $${961.17}$$	$${-0}$$	$${307.03}$$ < $${316.44}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${213.01}$$ < $${213.74}$$	$${-0}$$	$${72.26}$$ < $${73.14}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${228.92}$$ < $${229.68}$$	$${+0}$$	$${68.53}$$ < $${69.41}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${-0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.44}$$ < $${39.3}$$	$${-0}$$	$${14.84}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.12}$$ < $${37.94}$$	$${+0}$$	$${14.28}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.66}$$ < $${30.53}$$	$${-0}$$	$${7.82}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.25}$$ < $${29.11}$$	$${-0}$$	$${6.77}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.66}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.66}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${0}$$	$${41.9}$$ < $${54.97}$$	$${+0}$$	$${10.9}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${0}$$	$${39.71}$$ < $${51.9}$$	$${+0}$$	$${9.41}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${0}$$	$${39.58}$$ < $${51.84}$$	$${-0}$$	$${9.49}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${41.9}$$ < $${54.97}$$	$${-0}$$	$${10.91}$$ < $${14.47}$$
✅	iot_agent_suse_amd64	$${0}$$	$${41.9}$$ < $${54.97}$$	$${-0}$$	$${10.91}$$ < $${14.47}$$

cit-pr-commenter · 2025-10-16T09:46:10Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e6adbfbf-e7ea-45d7-a637-40b8cd0c611c

Baseline: 85fb7fb
Comparison: 6070ee3
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
✅	docker_containers_cpu	% cpu utilization	-10.49	[-11.64, -9.33]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.64	[-0.15, +5.43]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.54	[+0.33, +0.75]	1	Logs
➖	ddot_metrics	memory utilization	+0.39	[+0.21, +0.57]	1	Logs
➖	ddot_logs	memory utilization	+0.08	[+0.02, +0.15]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.05	[-0.07, +0.16]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.03	[-0.57, +0.64]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.22, +0.24]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.01	[-0.12, +0.14]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.00	[-0.04, +0.05]	1	Logs bounds checks dashboard
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.61, +0.60]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.60, +0.58]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.06	[-0.67, +0.55]	1	Logs
➖	quality_gate_idle	memory utilization	-0.07	[-0.11, -0.04]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.11	[-0.15, -0.07]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.16	[-0.21, -0.12]	1	Logs
➖	docker_containers_memory	memory utilization	-0.21	[-0.60, +0.19]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.39	[-0.54, -0.24]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.76	[-0.89, -0.64]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-1.00	[-1.20, -0.80]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-1.89	[-1.97, -1.81]	1	Logs
✅	docker_containers_cpu	% cpu utilization	-10.49	[-11.64, -9.33]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
❌	docker_containers_memory	memory_usage	7/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

L3n41c · 2025-10-16T11:54:44Z

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

dd-devflow-routing-codex · 2025-10-16T11:54:48Z

View all feedbacks in Devflow UI.

2025-10-16 11:54:47 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

2025-10-16 11:56:49 UTC ℹ️ Gitlab pipeline started

Started pipeline #79481153

L3n41c · 2025-10-20T07:25:09Z

/merge

dd-devflow-routing-codex · 2025-10-20T07:25:12Z

View all feedbacks in Devflow UI.

2025-10-20 07:25:12 UTC ℹ️ Start processing command /merge

2025-10-20 07:25:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 46m (p90).

2025-10-20 07:42:01 UTC ℹ️ MergeQueue: This merge request was merged

Revert "Revert "[ACIX-835] Update testify to v1.11.1" (#42017)"

98b2356

This reverts commit aa9e94f.

L3n41c added this to the 7.73.0 milestone Oct 16, 2025

L3n41c added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/container-integrations labels Oct 16, 2025

github-actions bot added the short review PR is simple enough to be reviewed quickly label Oct 16, 2025

github-actions bot added the component/system-probe label Oct 16, 2025

[EBPF] kmt: delay execution of the first try

f9ae464

L3n41c force-pushed the lenaic/ACIX-835 branch from bc69608 to f9ae464 Compare October 16, 2025 11:52

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Oct 16, 2025

L3n41c marked this pull request as ready for review October 16, 2025 13:56

L3n41c requested review from a team as code owners October 16, 2025 13:56

L3n41c requested a review from matthewleese October 16, 2025 13:56

L3n41c added the ask-review Ask required teams to review this PR label Oct 16, 2025

matthewleese approved these changes Oct 17, 2025

View reviewed changes

guyarb added 2 commits October 19, 2025 12:11

Merge branch 'main' into lenaic/ACIX-835

a9ac56d

usm: tests: Remove sleep

6070ee3

github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Oct 19, 2025

guyarb removed the request for review from a team October 19, 2025 12:33

dd-mergequeue bot merged commit 03ee04e into main Oct 20, 2025
357 checks passed

dd-mergequeue bot deleted the lenaic/ACIX-835 branch October 20, 2025 07:42

Revert "Revert "[ACIX-835] Update testify to v1.11.1" (#42017)" #42020

Revert "Revert "[ACIX-835] Update testify to v1.11.1" (#42017)" #42020

Uh oh!

Conversation

L3n41c commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

L3n41c commented Oct 16, 2025

Uh oh!

dd-devflow-routing-codex bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

L3n41c commented Oct 16, 2025

Uh oh!

dd-devflow-routing-codex bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

Uh oh!

L3n41c commented Oct 16, 2025

Uh oh!

dd-devflow-routing-codex bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

L3n41c commented Oct 20, 2025

Uh oh!

dd-devflow-routing-codex bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

L3n41c commented Oct 16, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Oct 16, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Oct 16, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Oct 16, 2025 •

edited

Loading

cit-pr-commenter bot commented Oct 16, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Oct 16, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Oct 20, 2025 •

edited

Loading