Skip to content

Revert "[ACIX-835] Update testify to v1.11.1" #42017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KevinFairise2 merged 1 commit into from
Oct 16, 2025
Merged

Revert "[ACIX-835] Update testify to v1.11.1" #42017

KevinFairise2 merged 1 commit into from
Oct 16, 2025

Conversation

@KevinFairise2
Copy link
Member

@KevinFairise2 KevinFairise2 commented Oct 16, 2025

Reverts #41981

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Oct 16, 2025
@KevinFairise2 KevinFairise2 merged commit aa9e94f into main Oct 16, 2025
157 of 195 checks passed
@KevinFairise2 KevinFairise2 deleted the revert-41981-lenaic/ACIX-835 branch October 16, 2025 07:17
@github-actions github-actions bot added this to the 7.73.0 milestone Oct 16, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Oct 16, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d1d44cce-040b-42a9-9770-dd87706c8367

Baseline: 746d1ba
Comparison: 5c1aa7c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization -0.13 [-1.11, +0.86] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.36 [+0.16, +0.55] 1 Logs
➖ otlp_ingest_logs memory utilization +0.34 [+0.21, +0.47] 1 Logs
➖ docker_containers_memory memory utilization +0.15 [-0.37, +0.67] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.13 [+0.01, +0.25] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.12 [+0.08, +0.16] 1 Logs bounds checks dashboard
➖ file_to_blackhole_100ms_latency egress throughput +0.03 [-0.56, +0.63] 1 Logs
➖ file_tree memory utilization +0.01 [-0.02, +0.05] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.26, +0.25] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.01 [-0.61, +0.59] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.02 [-0.62, +0.59] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.65, +0.56] 1 Logs
➖ docker_containers_cpu % cpu utilization -0.13 [-1.11, +0.86] 1 Logs
➖ quality_gate_idle memory utilization -0.16 [-0.19, -0.12] 1 Logs bounds checks dashboard
➖ ddot_metrics_sum_delta memory utilization -0.16 [-0.31, -0.00] 1 Logs
➖ ddot_logs memory utilization -0.18 [-0.24, -0.12] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.32 [-0.35, -0.28] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.47 [-0.59, -0.35] 1 Logs
➖ quality_gate_logs % cpu utilization -0.47 [-3.25, +2.31] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput -0.76 [-0.82, -0.71] 1 Logs
➖ ddot_metrics memory utilization -0.90 [-1.08, -0.73] 1 Logs
➖ quality_gate_metrics_logs memory utilization -0.91 [-1.09, -0.73] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

L3n41c added a commit that referenced this pull request Oct 16, 2025
@L3n41c
Revert "Revert "[ACIX-835] Update testify to v1.11.1" (#42017)"
98b2356 
This reverts commit aa9e94f.
dd-mergequeue bot pushed a commit that referenced this pull request Oct 20, 2025
@L3n41c @guyarb
Revert "Revert "[ACIX-835] Update testify to v1.11.1" (#42017)" (#42020)
03ee04e 
This reverts commit aa9e94f.

### What does this PR do?

Re-apply #41981 and fix the tests that it broke.

### Motivation

Same as #41981: speed up tests execution thanks to stretchr/testify#1427 that makes `require.EventuallyWithT` test the condition immediately instead of waiting for an initial delay before making the very first try.

### Describe how you validated your changes

Launched a [full pipeline](https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/79481153) to be sure to run all the tests and not a subset of them: #42020 (comment)

### Additional Notes

The main feature we were looking for by upgrading `testify` to `v1.11.1` was the fact that that `require.EventuallyWithT` is now evaluating the condition the first time immediately instead of waiting for a `tick` delay before making the first try.
This unexpectedly broke the tests that are touched in this PR.
Fixing tests by adding a `time.Sleep(…)` is most probably not the smartest way of fixing them. But it restores the execution time flow of the previous versions of `testify` that happened to make the tests pass.

Co-authored-by: guyarb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

short review PR is simple enough to be reviewed quickly

Projects

None yet

Milestone

7.73.0

Development

Successfully merging this pull request may close these issues.

2 participants

@KevinFairise2