Skip to content

Update the bzip2 build for our requirements#41205

Merged
dd-mergequeue[bot] merged 4 commits into
mainfrom
aiuto/bz2
Sep 25, 2025
Merged

Update the bzip2 build for our requirements#41205
dd-mergequeue[bot] merged 4 commits into
mainfrom
aiuto/bz2

Conversation

@aiuto

@aiuto aiuto commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Build bzip2 as a shared library.

  • switch from BCR to a private BUILD file.
  • verify that the bzip2 1.0.8 version we see in the original repo and the two mirrors is actually the same content.
    • then use the most available.
  • build shared library
  • continue to build static bzip2 tool as //deps/bzip2:bzip2
  • integrate options currently used by Omnibus
  • preserve compile options for AIX, in case omnibus script goes away before we get there.
  • add basic smoke tests culled from upstream repository.

For next time:

  • figure out if we actually need the symlinked .so files, and how to install them.
  • have omnibus use this

Related:

@aiuto
Update the bzip2 build for our requirements
b63bbff 
- switch from BCR to a private BUILD file.
- verify that the bzip2 1.0.8 version we see in the original repo and the two mirrors is actually the same content.
  - then use the most available.
- build shared library
- continue to build static bzip2 tool as //deps/bzip2:bzip2
- integrate options currently used by Omnibus
- preserve compile options for AIX, in case omnibus script goes away before we get there.
- add basic smoke tests culled from upstream repository.

- figure out how to install the
- have omnibus use this

Related:
- bazelbuild/platforms#126
@aiuto
aiuto marked this pull request as ready for review September 24, 2025 04:44
@aiuto
aiuto requested a review from a team as a code owner September 24, 2025 04:44
@github-actions github-actions Bot added medium review PR review might take time team/agent-build labels Sep 24, 2025
@cit-pr-commenter

cit-pr-commenter Bot commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 46e892bd-77ba-4560-84fd-250550e4af00

Baseline: 0874460
Comparison: baaaed6
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization -4.21 [-7.27, -1.15] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_logs % cpu utilization +3.27 [+0.44, +6.11] 1 Logs bounds checks dashboard
➖ tcp_syslog_to_blackhole ingress throughput +0.50 [+0.43, +0.57] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.30 [+0.25, +0.34] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization +0.20 [+0.16, +0.24] 1 Logs bounds checks dashboard
➖ ddot_metrics memory utilization +0.19 [+0.04, +0.34] 1 Logs
➖ ddot_logs memory utilization +0.18 [+0.12, +0.24] 1 Logs
➖ docker_containers_memory memory utilization +0.18 [+0.03, +0.32] 1 Logs
➖ ddot_metrics_sum_delta memory utilization +0.17 [+0.03, +0.32] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.12 [+0.00, +0.23] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.07 [-0.06, +0.19] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.06 [-0.54, +0.65] 1 Logs
➖ quality_gate_metrics_logs memory utilization +0.01 [-0.20, +0.22] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.23, +0.24] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
➖ file_tree memory utilization -0.01 [-0.05, +0.04] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.02 [-0.58, +0.55] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.62, +0.58] 1 Logs
➖ otlp_ingest_logs memory utilization -0.05 [-0.17, +0.06] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.06 [-0.25, +0.13] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.06 [-0.12, -0.00] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.13 [-0.71, +0.46] 1 Logs
➖ docker_containers_cpu % cpu utilization -4.21 [-7.27, -1.15] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cb50630

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 DataNotFound $${696.68}$$ < $${703.13}$$ DataNotFound $${175.4}$$ < $${178.38}$$
✅ agent_deb_amd64_fips DataNotFound $${691.19}$$ < $${697.61}$$ DataNotFound $${173.94}$$ < $${177.15}$$
✅ agent_heroku_amd64 DataNotFound $${335.74}$$ < $${341.62}$$ DataNotFound $${88.89}$$ < $${91.52}$$
✅ agent_msi DataNotFound $${987.88}$$ < $${990.42}$$ DataNotFound $${150.8}$$ < $${152.42}$$
✅ agent_rpm_amd64 DataNotFound $${696.67}$$ < $${703.12}$$ DataNotFound $${177.7}$$ < $${180.53}$$
✅ agent_rpm_amd64_fips DataNotFound $${691.18}$$ < $${697.6}$$ DataNotFound $${176.04}$$ < $${178.87}$$
✅ agent_rpm_arm64 DataNotFound $${682.77}$$ < $${689.82}$$ DataNotFound $${158.94}$$ < $${162.16}$$
✅ agent_rpm_arm64_fips DataNotFound $${678.35}$$ < $${685.08}$$ DataNotFound $${157.86}$$ < $${161.11}$$
✅ agent_suse_amd64 DataNotFound $${696.67}$$ < $${703.12}$$ DataNotFound $${177.7}$$ < $${180.53}$$
✅ agent_suse_amd64_fips DataNotFound $${691.18}$$ < $${697.6}$$ DataNotFound $${176.04}$$ < $${178.87}$$
✅ agent_suse_arm64 DataNotFound $${682.77}$$ < $${689.82}$$ DataNotFound $${158.94}$$ < $${162.16}$$
✅ agent_suse_arm64_fips DataNotFound $${678.35}$$ < $${685.08}$$ DataNotFound $${157.86}$$ < $${161.11}$$
✅ docker_agent_amd64 DataNotFound $${768.05}$$ < $${774.54}$$ DataNotFound $${263.07}$$ < $${266.46}$$
✅ docker_agent_arm64 DataNotFound $${778.1}$$ < $${785.2}$$ DataNotFound $${249.15}$$ < $${252.92}$$
✅ docker_agent_jmx_amd64 DataNotFound $${958.92}$$ < $${965.41}$$ DataNotFound $${331.73}$$ < $${335.08}$$
✅ docker_agent_jmx_arm64 DataNotFound $${957.56}$$ < $${964.66}$$ DataNotFound $${313.78}$$ < $${317.54}$$
✅ docker_cluster_agent_amd64 DataNotFound $${212.75}$$ < $${213.74}$$ DataNotFound $${72.19}$$ < $${73.2}$$
✅ docker_cluster_agent_arm64 DataNotFound $${228.67}$$ < $${229.68}$$ DataNotFound $${68.47}$$ < $${69.48}$$
✅ docker_cws_instrumentation_amd64 DataNotFound $${7.06}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 DataNotFound $${38.44}$$ < $${39.3}$$ DataNotFound $${14.84}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 DataNotFound $${37.12}$$ < $${37.94}$$ DataNotFound $${14.3}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 DataNotFound $${29.67}$$ < $${30.53}$$ DataNotFound $${7.82}$$ < $${8.75}$$
✅ dogstatsd_deb_arm64 DataNotFound $${28.26}$$ < $${29.12}$$ DataNotFound $${6.78}$$ < $${7.71}$$
✅ dogstatsd_rpm_amd64 DataNotFound $${29.67}$$ < $${30.53}$$ DataNotFound $${7.83}$$ < $${8.77}$$
✅ dogstatsd_suse_amd64 DataNotFound $${29.67}$$ < $${30.53}$$ DataNotFound $${7.83}$$ < $${8.77}$$
✅ iot_agent_deb_amd64 DataNotFound $${54.46}$$ < $${54.97}$$ DataNotFound $${13.6}$$ < $${14.45}$$
✅ iot_agent_deb_arm64 DataNotFound $${51.74}$$ < $${51.9}$$ DataNotFound $${11.73}$$ < $${12.63}$$
✅ iot_agent_deb_armhf DataNotFound $${51.3}$$ < $${51.84}$$ DataNotFound $${11.8}$$ < $${12.74}$$
✅ iot_agent_rpm_amd64 DataNotFound $${54.46}$$ < $${54.97}$$ DataNotFound $${13.62}$$ < $${14.47}$$
✅ iot_agent_suse_amd64 DataNotFound $${54.46}$$ < $${54.97}$$ DataNotFound $${13.62}$$ < $${14.47}$$

@aiuto aiuto added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Sep 24, 2025
JSGette
JSGette reviewed Sep 24, 2025
View reviewed changes
Comment thread deps/bzip2.BUILD.bazel Outdated
JSGette
JSGette reviewed Sep 24, 2025
View reviewed changes
Comment thread deps/bzip2.BUILD.bazel
JSGette
JSGette reviewed Sep 24, 2025
View reviewed changes
Comment thread deps/bzip2.BUILD.bazel
@aiuto

aiuto commented Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 25, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-25 15:10:02 UTC ℹ️ Start processing command /merge

2025-09-25 15:10:10 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-25 15:31:26 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 32m (p90).

2025-09-25 15:46:00 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 5f331b5 into main Sep 25, 2025
249 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the aiuto/bz2 branch September 25, 2025 15:45
@github-actions github-actions Bot added this to the 7.72.0 milestone Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSGette JSGette JSGette approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Milestone

7.72.0

Development

Successfully merging this pull request may close these issues.

2 participants

@aiuto @JSGette