[Backport 7.70.x] [AGENTRUN-673] Add mlx5_core network check metrics by agent-platform-auto-pr[bot] · Pull Request #40349 · DataDog/datadog-agent

agent-platform-auto-pr · 2025-08-28T13:42:57Z

Backport decde86 from #40326.

What does this PR do?

The mlx5_core NIC metrics were added to the python network check after we had ported the ethtool parsing over so these were not being sent in our Azure staging clusters.

This PR adds support for parsing those stats and comprehensive unit tests for the ethtool metrics in general.

Motivation

Describe how you validated your changes (if not by through tests)

Thorough unit tests
Will deploy on staging to confirm

Possible Drawbacks / Trade-offs

### What does this PR do? The mlx5_core NIC metrics were added to the [python network check](DataDog/integrations-core#20481) after we had ported the ethtool parsing over so these were not being sent in our Azure staging clusters. This PR adds support for parsing those stats and comprehensive unit tests for the ethtool metrics in general. ### Motivation ### Describe how you validated your changes (if not by through tests) * Thorough unit tests * Will deploy on staging to confirm ### Possible Drawbacks / Trade-offs (cherry picked from commit decde86)

cit-pr-commenter · 2025-08-28T14:36:47Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f5decff8-ce0c-4caa-b1cf-4fecc6a8f351

Baseline: 803a0fc
Comparison: 41d6df5
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.19	[-2.90, +3.28]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+0.67	[+0.26, +1.07]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	+0.36	[+0.30, +0.43]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+0.19	[-2.90, +3.28]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.18	[+0.12, +0.24]	1	Logs
➖	quality_gate_idle	memory utilization	+0.17	[+0.14, +0.21]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.09	[-0.04, +0.21]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.05	[-0.54, +0.63]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.03	[-0.12, +0.17]	1	Logs
➖	ddot_logs	memory utilization	+0.02	[-0.07, +0.11]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.57, +0.61]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.31, +0.32]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.62, +0.61]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.03, +0.01]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.06	[-0.62, +0.50]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.15	[-0.19, -0.12]	1	Logs
➖	file_tree	memory utilization	-0.21	[-0.25, -0.18]	1	Logs
➖	ddot_metrics	memory utilization	-0.36	[-0.47, -0.24]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.42	[-0.45, -0.39]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-2.10	[-4.81, +0.61]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-08-28T15:02:43Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 666416e

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${-0.42}$$	$${700.91}$$ < $${704.84}$$	$${-0.43}$$	$${177.17}$$ < $${178.58}$$
✅	agent_deb_amd64_fips	$${-11.39}$$	$${688.2}$$ < $${703.09}$$	$${-2.85}$$	$${174.09}$$ < $${178.12}$$
✅	agent_heroku_amd64	$${-0.41}$$	$${350.61}$$ < $${355.37}$$	$${-0.55}$$	$${94.1}$$ < $${95.72}$$
✅	agent_msi	$${-0.4}$$	$${974.93}$$ < $${980.61}$$	$${+2.95}$$	$${150.39}$$ < $${152.67}$$
✅	agent_rpm_amd64	$${-0.42}$$	$${700.9}$$ < $${704.83}$$	$${-0.53}$$	$${179.32}$$ < $${180.22}$$
✅	agent_rpm_amd64_fips	$${-11.39}$$	$${688.19}$$ < $${703.08}$$	$${-3.16}$$	$${175.67}$$ < $${179.85}$$
✅	agent_rpm_arm64	$${-0.31}$$	$${689.94}$$ < $${694.74}$$	$${-0.44}$$	$${161.69}$$ < $${163.96}$$
✅	agent_rpm_arm64_fips	$${-10.5}$$	$${678.06}$$ < $${693.05}$$	$${-2.69}$$	$${158.44}$$ < $${163.0}$$
✅	agent_suse_amd64	$${-0.42}$$	$${700.9}$$ < $${704.83}$$	$${-0.53}$$	$${179.32}$$ < $${180.22}$$
✅	agent_suse_amd64_fips	$${-11.39}$$	$${688.19}$$ < $${703.08}$$	$${-3.16}$$	$${175.67}$$ < $${179.85}$$
✅	agent_suse_arm64	$${-0.31}$$	$${689.94}$$ < $${694.74}$$	$${-0.44}$$	$${161.69}$$ < $${163.96}$$
✅	agent_suse_arm64_fips	$${-10.5}$$	$${678.06}$$ < $${693.05}$$	$${-2.69}$$	$${158.44}$$ < $${163.0}$$
✅	docker_agent_amd64	$${+0.01}$$	$${783.32}$$ < $${788.65}$$	$${-0}$$	$${269.97}$$ < $${272.01}$$
✅	docker_agent_arm64	$${+0.12}$$	$${795.7}$$ < $${802.0}$$	$${+0}$$	$${256.76}$$ < $${259.7}$$
✅	docker_agent_jmx_amd64	$${-0.43}$$	$${974.19}$$ < $${979.84}$$	$${-0.41}$$	$${338.6}$$ < $${340.95}$$
✅	docker_agent_jmx_arm64	$${-0.32}$$	$${975.16}$$ < $${981.8}$$	$${-0.43}$$	$${321.34}$$ < $${324.65}$$
✅	docker_cluster_agent_amd64	$${+0.04}$$	$${214.48}$$ < $${214.5}$$	$${+0}$$	$${72.91}$$ < $${73.51}$$
✅	docker_cluster_agent_arm64	$${+0.06}$$	$${230.32}$$ < $${230.33}$$	$${+0.02}$$	$${69.16}$$ < $${69.77}$$
✅	docker_cws_instrumentation_amd64	$${+0}$$	$${7.07}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${-0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.71}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${-0}$$	$${38.72}$$ < $${39.57}$$	$${-0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${-0.06}$$	$${37.36}$$ < $${38.2}$$	$${-0}$$	$${14.39}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${-0}$$	$${29.95}$$ < $${31.4}$$	$${+0}$$	$${7.89}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${-0}$$	$${28.53}$$ < $${29.97}$$	$${-0.01}$$	$${6.85}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${-0}$$	$${29.95}$$ < $${31.4}$$	$${-0}$$	$${7.9}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${-0}$$	$${29.95}$$ < $${31.4}$$	$${-0}$$	$${7.9}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${+0}$$	$${54.34}$$ < $${54.55}$$	$${-0}$$	$${13.68}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${+0}$$	$${51.65}$$ < $${51.9}$$	$${+0}$$	$${11.85}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${+0}$$	$${51.18}$$ < $${51.42}$$	$${-0.03}$$	$${11.91}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${+0}$$	$${54.34}$$ < $${54.55}$$	$${+0}$$	$${13.7}$$ < $${14.47}$$
✅	iot_agent_rpm_arm64	$${+0.48}$$	$${51.65}$$ < $${51.91}$$	$${-0.07}$$	$${11.86}$$ < $${12.65}$$
✅	iot_agent_suse_amd64	$${+0}$$	$${54.34}$$ < $${54.55}$$	$${+0}$$	$${13.7}$$ < $${14.47}$$

agent-platform-auto-pr Bot requested a review from a team as a code owner August 28, 2025 13:42

agent-platform-auto-pr Bot added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests backport bot long review PR is complex, plan time to review it team/agent-runtimes labels Aug 28, 2025

agent-platform-auto-pr Bot requested a review from jeremy-hanna August 28, 2025 13:42

agent-platform-auto-pr Bot added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests backport bot long review PR is complex, plan time to review it team/agent-runtimes labels Aug 28, 2025

jeremy-hanna approved these changes Aug 28, 2025

View reviewed changes

FlorentClarret approved these changes Sep 3, 2025

View reviewed changes

FlorentClarret merged commit 3bfcf0c into 7.70.x Sep 3, 2025
384 checks passed

FlorentClarret deleted the backport-40326-to-7.70.x branch September 3, 2025 12:57

github-actions Bot added this to the 7.70.1 milestone Sep 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Backport 7.70.x] [AGENTRUN-673] Add mlx5_core network check metrics#40349

[Backport 7.70.x] [AGENTRUN-673] Add mlx5_core network check metrics#40349
FlorentClarret merged 1 commit into
7.70.xfrom
backport-40326-to-7.70.x

agent-platform-auto-pr Bot commented Aug 28, 2025

Uh oh!

cit-pr-commenter Bot commented Aug 28, 2025

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

agent-platform-auto-pr Bot commented Aug 28, 2025

Info

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

agent-platform-auto-pr Bot commented Aug 28, 2025

What does this PR do?

Motivation

Describe how you validated your changes (if not by through tests)

Possible Drawbacks / Trade-offs

Uh oh!

cit-pr-commenter Bot commented Aug 28, 2025

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr Bot commented Aug 28, 2025

Static quality checks

Info

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants