Skip to content

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Aug 25, 2025

What does this PR do?

The present change simply consists in switching the bazel_dep for bzip2 to a patch version of the module that uses a Bazel-hosted mirror:

-    "url": "https://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz"
+    "url": "https://mirror.bazel.build/sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz"

Motivation

sourceware.org happens to blacklist some IP ranges, see:

... which prevents from successfully fetching bzip2 from our AWS-hosted macOS runners:

ERROR: no such package '@@bzip2+//': java.io.IOException: Error
 downloading [https://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz] to
 /private/var/tmp/_bazel_ec2-user/a7472b478f70b5844f17194e8ea22363/external/bzip2+/temp4855649124641959474/bzip2-1.0.8.tar.gz:
  GET returned 403 Forbidden

@rdesgroppes rdesgroppes requested a review from a team as a code owner August 25, 2025 15:55
@rdesgroppes rdesgroppes added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation ask-review Ask required teams to review this PR labels Aug 25, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Aug 25, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Aug 25, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 19a98054-a348-4747-b99b-bfe21e897eea

Baseline: b6d5666
Comparison: 810667b
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +14.03 [+10.67, +17.39] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +14.03 [+10.67, +17.39] 1 Logs
docker_containers_memory memory utilization +0.91 [+0.76, +1.07] 1 Logs
quality_gate_idle memory utilization +0.68 [+0.62, +0.74] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.37 [+0.31, +0.43] 1 Logs
otlp_ingest_logs memory utilization +0.22 [+0.08, +0.36] 1 Logs
file_tree memory utilization +0.10 [+0.06, +0.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.09 [-0.53, +0.71] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.58, +0.68] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.60, +0.69] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.02 [-0.03, +0.06] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.10] 1 Logs
quality_gate_idle_all_features memory utilization -0.01 [-0.05, +0.02] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.62, +0.57] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.31 [-0.37, -0.26] 1 Logs
otlp_ingest_metrics memory utilization -0.36 [-0.51, -0.20] 1 Logs
ddot_metrics memory utilization -0.76 [-0.97, -0.55] 1 Logs
ddot_logs memory utilization -1.56 [-1.67, -1.46] 1 Logs
quality_gate_metrics_logs memory utilization -1.75 [-2.11, -1.40] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.25 [-4.98, +0.48] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Aug 25, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b6d5666

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${700.24}$$ < $${704.84}$$ $${+0}$$ $${177.13}$$ < $${178.58}$$
agent_deb_amd64_fips $${0}$$ $${687.53}$$ < $${703.09}$$ $${-0.01}$$ $${173.99}$$ < $${178.12}$$
agent_heroku_amd64 $${0}$$ $${350.3}$$ < $${355.37}$$ $${-0.01}$$ $${93.96}$$ < $${95.72}$$
agent_msi $${0}$$ $${972.75}$$ < $${980.61}$$ $${+0.01}$$ $${150.13}$$ < $${152.67}$$
agent_rpm_amd64 $${0}$$ $${700.23}$$ < $${704.83}$$ $${-0.01}$$ $${179.01}$$ < $${180.22}$$
agent_rpm_amd64_fips $${0}$$ $${687.52}$$ < $${703.08}$$ $${+0.01}$$ $${175.67}$$ < $${179.85}$$
agent_rpm_arm64 $${0}$$ $${689.16}$$ < $${694.74}$$ $${+0.02}$$ $${161.62}$$ < $${163.96}$$
agent_rpm_arm64_fips $${0}$$ $${677.26}$$ < $${693.05}$$ $${-0.04}$$ $${158.4}$$ < $${163.0}$$
agent_suse_amd64 $${0}$$ $${700.23}$$ < $${704.83}$$ $${-0.01}$$ $${179.01}$$ < $${180.22}$$
agent_suse_amd64_fips $${0}$$ $${687.52}$$ < $${703.08}$$ $${+0.01}$$ $${175.67}$$ < $${179.85}$$
agent_suse_arm64 $${0}$$ $${689.16}$$ < $${694.74}$$ $${+0.02}$$ $${161.62}$$ < $${163.96}$$
agent_suse_arm64_fips $${0}$$ $${677.26}$$ < $${693.05}$$ $${-0.04}$$ $${158.4}$$ < $${163.0}$$
docker_agent_amd64 $${+0}$$ $${782.65}$$ < $${788.65}$$ $${+0}$$ $${269.85}$$ < $${272.01}$$
docker_agent_arm64 $${+0}$$ $${794.91}$$ < $${802.0}$$ $${+0}$$ $${256.63}$$ < $${259.7}$$
docker_agent_jmx_amd64 $${+0}$$ $${973.52}$$ < $${979.84}$$ $${-0}$$ $${338.47}$$ < $${340.95}$$
docker_agent_jmx_arm64 $${+0}$$ $${974.38}$$ < $${981.8}$$ $${-0}$$ $${321.24}$$ < $${324.65}$$
docker_cluster_agent_amd64 $${0}$$ $${211.9}$$ < $${214.5}$$ $${-0}$$ $${72.05}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${0}$$ $${227.93}$$ < $${230.33}$$ $${-0}$$ $${68.35}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.48}$$ < $${39.57}$$ $${-0}$$ $${14.89}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.16}$$ < $${38.2}$$ $${-0}$$ $${14.34}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.71}$$ < $${31.4}$$ $${-0}$$ $${7.85}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${28.3}$$ < $${29.97}$$ $${-0}$$ $${6.81}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.71}$$ < $${31.4}$$ $${-0}$$ $${7.86}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${29.71}$$ < $${31.4}$$ $${-0}$$ $${7.86}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${54.13}$$ < $${54.55}$$ $${+0}$$ $${13.65}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.45}$$ < $${51.9}$$ $${-0}$$ $${11.81}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${51.0}$$ < $${51.42}$$ $${+0}$$ $${11.88}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${54.13}$$ < $${54.55}$$ $${-0}$$ $${13.67}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${54.13}$$ < $${54.55}$$ $${-0}$$ $${13.67}$$ < $${14.47}$$

sourceware.org happens to blacklist some IP ranges, see:
- conan-io/conan-center-index#26881
- https://sourceware.org/pipermail/overseers/2025q1/019931.html
- https://lwn.net/Articles/1008897/

... which prevents from successfully fetching `bzip2` from our
AWS-hosted macOS runners:
```
ERROR: no such package '@@bzip2+//': java.io.IOException: Error
 downloading [https://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz] to
 /private/var/tmp/_bazel_ec2-user/a7472b478f70b5844f17194e8ea22363/external/bzip2+/temp4855649124641959474/bzip2-1.0.8.tar.gz:
  GET returned 403 Forbidden
```

The present change simply consists in switching the corresponding
`bazel_dep` to a patch version of the module that uses a Bazel-hosted
mirror:
```diff
-    "url": "https://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz"
+    "url": "https://mirror.bazel.build/sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz"
```
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/make-bazel-retrieve-bzip2-on-aws-hosted-runners branch from 7f36052 to 810667b Compare August 26, 2025 06:11
Copy link
Contributor

@JSGette JSGette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rdesgroppes rdesgroppes merged commit 4b6da50 into main Aug 26, 2025
237 checks passed
@rdesgroppes rdesgroppes deleted the regis.desgroppes/make-bazel-retrieve-bzip2-on-aws-hosted-runners branch August 26, 2025 07:26
@github-actions github-actions bot added this to the 7.71.0 milestone Aug 26, 2025
@rdesgroppes rdesgroppes changed the title Make bazel retrieve bzip2 on AWS-hosted runners [ABLD-135] Make bazel retrieve bzip2 on AWS-hosted runners Aug 29, 2025
rdesgroppes added a commit that referenced this pull request Sep 2, 2025
### What does this PR do?
Now `bazelisk` is available on all our CI executors
([macOS](DataDog/ci-platform-machine-images#395)
runners,
[Linux](DataDog/datadog-agent-buildimages#951) &
[Windows](DataDog/datadog-agent-buildimages#953)
containers), this change secures an initial part of our `bazel` setup
while providing reusable job templates to ease caching in CI.

Practically, it adds a handful of jobs focusing on **building `bazel`
dependencies** in the corresponding GitLab `deps_build` stage.

Overall, it consists in:
1. verifying **`bazelisk` properly bootstraps `bazel` across all
platforms**, (primary scope of the PR)
2. extracting initial `bazel:`-prefixed CI job templates and dogfooding
them, (i.e. by building deps)
3. binding `bazelisk`/`bazel` caches to GitLab caching capabilities
(runner-based as of now): installed binaries, "repository cache", "repo
contents cache", and "disk cache" are all saved/restored correctly
to/from GitLab while honoring OS/architecture boundaries,
4. marking in-workspace cache in both `.bazelignore` and `.gitignore`,
5. adjusting code/job ownership accordingly.

### Motivation
Securing some initial `bazel` configuration in CI :
- ensures all platforms are kept in the radar over next iterations,
- prevents regressions over next iterations,
- establishes foundations for future jobs.

### Possible Drawbacks / Trade-offs
- on Windows, compilation errors made be descope dependencies being
built to **only `bzip2`**. This will be of course addressed in a
subsequent PR,
- GitLab caching is still runner-based for the time being, which can be
revisited later. (like everything)

### Additional Notes
Main addressed challenges:
- cache location conflicts[^1]: externalized "repo contents cache"
through `tools/bazel*` wrappers:
  - bazelbuild/bazel#26384
  - bazelbuild/bazel#26522
  - bazelbuild/bazel#26773
  - bazelbuild/bazel#26802
- macOS runners:
  - `bzip2` dependency: fetch from a reachable source:
    - [x] #40219
- Windows:
- `bazel` spawn strategy: fallback to a permissive strategy since
`sandboxed` is unsupported
    - [x] #40328
- `tools/bazel` wrapper: fallback to batch (`tools/bazel.bat`), since
`bash` is discouraged by `bazel` in this case and `tools/bazel.ps1`
poses detection problems,
  - long paths were supported in containers but not on runners:
    - [x] DataDog/ci-platform-machine-images#429
  - recursive symlinks: use `robocopy` instead of `copy`/`move`/`xcopy`.
  
[^1]:
> ERROR: The repo contents cache
[/path/to/datadog-agent/.cache/repo_contents] is inside the workspace
[/path/to/datadog-agent]. This can cause spurious failures. Disable the
repo contents cache with `--repo_contents_cache=`, or specify
`--repo_contents_cache=<path outside the workspace>`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants