trace/stats: Add HTTP Method and Endpoint for resource renaming by e-n-0 · Pull Request #39372 · DataDog/datadog-agent

e-n-0 · 2025-07-30T13:23:06Z

What does this PR do?

This PR adds the HTTP Method and HTTP Endpoint to the stats protobuf file.
This also includes all required changes to correctly construct a stat span with these new data.

Changes

As the method NewStatSpan is also used in the dd-trace-go tracer that is imported in some contrib (like serverless), we chose to deprecated this method for this release and replace it by NewStatSpanWithHTTPEndpoint.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

RFC
Tracer PR that use the new updated stats: feat: resource renaming dd-trace-go#3851
Intake PR

cit-pr-commenter · 2025-07-30T14:13:27Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 637a1fb5-17e0-4c80-bffd-d738c4bf37f4

Baseline: 2f79110
Comparison: 55257ed
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
✅	docker_containers_cpu	% cpu utilization	-6.14	[-9.23, -3.04]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+2.30	[+1.94, +2.66]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+0.62	[-2.12, +3.36]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.55	[+0.49, +0.62]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.45	[+0.30, +0.60]	1	Logs
➖	ddot_logs	memory utilization	+0.24	[+0.13, +0.35]	1	Logs
➖	ddot_metrics	memory utilization	+0.17	[-0.02, +0.36]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.16	[-0.41, +0.72]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.09	[-0.51, +0.68]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.03	[+0.00, +0.05]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.10, +0.13]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.59, +0.62]	1	Logs
➖	quality_gate_idle	memory utilization	-0.01	[-0.06, +0.05]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.04	[-0.07, -0.00]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.07	[-0.65, +0.51]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.07	[-0.10, -0.05]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	-0.12	[-0.30, +0.06]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.24	[-0.28, -0.20]	1	Logs
➖	docker_containers_memory	memory utilization	-1.20	[-1.34, -1.06]	1	Logs
✅	docker_containers_cpu	% cpu utilization	-6.14	[-9.23, -3.04]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	docker_containers_cpu	simple_check_run	9/10
✅	docker_containers_memory	memory_usage	10/10
❌	docker_containers_memory	simple_check_run	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-09-01T14:09:36Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2f79110

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${701.6}$$ < $${704.84}$$	$${+0}$$	$${177.4}$$ < $${178.58}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${688.87}$$ < $${703.09}$$	$${+0.01}$$	$${174.35}$$ < $${178.12}$$
✅	agent_heroku_amd64	$${0}$$	$${350.8}$$ < $${355.37}$$	$${+0.01}$$	$${94.25}$$ < $${95.72}$$
✅	agent_msi	$${+0.02}$$	$${977.4}$$ < $${980.61}$$	$${-0}$$	$${150.28}$$ < $${152.67}$$
✅	agent_rpm_amd64	$${+0}$$	$${701.59}$$ < $${704.83}$$	$${+0.03}$$	$${179.65}$$ < $${180.22}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${688.85}$$ < $${703.08}$$	$${+0.01}$$	$${175.8}$$ < $${179.85}$$
✅	agent_rpm_arm64	$${0}$$	$${690.55}$$ < $${694.74}$$	$${+0.01}$$	$${161.81}$$ < $${163.96}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${678.66}$$ < $${693.05}$$	$${-0.02}$$	$${158.44}$$ < $${163.0}$$
✅	agent_suse_amd64	$${+0}$$	$${701.59}$$ < $${704.83}$$	$${+0.03}$$	$${179.65}$$ < $${180.22}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${688.85}$$ < $${703.08}$$	$${+0.01}$$	$${175.8}$$ < $${179.85}$$
✅	agent_suse_arm64	$${0}$$	$${690.55}$$ < $${694.74}$$	$${+0.01}$$	$${161.81}$$ < $${163.96}$$
✅	agent_suse_arm64_fips	$${0}$$	$${678.66}$$ < $${693.05}$$	$${-0.02}$$	$${158.44}$$ < $${163.0}$$
✅	docker_agent_amd64	$${+0}$$	$${784.01}$$ < $${788.65}$$	$${+0}$$	$${270.27}$$ < $${272.01}$$
✅	docker_agent_arm64	$${-0}$$	$${796.31}$$ < $${802.0}$$	$${-0.02}$$	$${256.98}$$ < $${259.7}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${974.87}$$ < $${979.84}$$	$${+0.01}$$	$${338.89}$$ < $${340.95}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${975.77}$$ < $${981.8}$$	$${+0.01}$$	$${321.6}$$ < $${324.65}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${212.68}$$ < $${214.5}$$	$${+0}$$	$${72.22}$$ < $${73.51}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${228.6}$$ < $${230.33}$$	$${-0}$$	$${68.48}$$ < $${69.77}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${-0}$$	$${2.71}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.33}$$ < $${39.57}$$	$${0}$$	$${14.81}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${36.99}$$ < $${38.2}$$	$${-0}$$	$${14.26}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.56}$$ < $${31.4}$$	$${+0}$$	$${7.8}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.15}$$ < $${29.97}$$	$${-0}$$	$${6.76}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.56}$$ < $${31.4}$$	$${+0}$$	$${7.81}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.56}$$ < $${31.4}$$	$${+0}$$	$${7.81}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${54.56}$$ < $${54.97}$$	$${-0}$$	$${13.76}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${+0}$$	$${51.86}$$ < $${51.9}$$	$${-0}$$	$${11.89}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${0}$$	$${51.43}$$ < $${51.84}$$	$${+0}$$	$${11.96}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${54.56}$$ < $${54.97}$$	$${-0}$$	$${13.77}$$ < $${14.47}$$
✅	iot_agent_suse_amd64	$${0}$$	$${54.56}$$ < $${54.97}$$	$${-0}$$	$${13.77}$$ < $${14.47}$$

ichinaski

LGTM

e-n-0 · 2025-09-02T15:26:22Z

/merge

dd-devflow-routing-codex · 2025-09-02T15:26:29Z

View all feedbacks in Devflow UI.

2025-09-02 15:26:29 UTC ℹ️ Start processing command /merge

2025-09-02 15:26:51 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 31m (p90).

2025-09-02 15:54:26 UTC ℹ️ MergeQueue: This merge request was merged

## Description This PR implements the resource renaming feature specified in RFC-1051. This contains the following changes: - add the `http.endpoint` tag when `http.route` is not reported by an integration. Its value is a "simplified endpoint" representation of the url path. - add the http method and http endpoint in the aggregation key of for span stats (see corresponding agent PR DataDog/datadog-agent#39372) The feature is turned off by default behind the env var: "DD_TRACE_RESOURCE_RENAMING_ENABLED" APPSEC-58892 ## Notes Added the TRACING_CONFIG_NONDEFAULT_3 scenario to the CI. It contains the system tests for this feature. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Brett Langdon <[email protected]>

github-actions Bot added team/agent-apm trace-agent medium review PR review might take time labels Jul 30, 2025

e-n-0 force-pushed the flavien/resource-renaming branch from 963329a to 1e16398 Compare August 7, 2025 14:50

github-actions Bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Aug 25, 2025

e-n-0 force-pushed the flavien/resource-renaming branch 2 times, most recently from 2f8f75d to 63e4d49 Compare August 25, 2025 12:14

github-actions Bot added medium review PR review might take time and removed long review PR is complex, plan time to review it labels Aug 25, 2025

e-n-0 force-pushed the flavien/resource-renaming branch 3 times, most recently from 441c5cf to 119f830 Compare September 1, 2025 09:49

e-n-0 added 7 commits September 1, 2025 11:52

update proto

b762cc9

add fields to the statSpan for the Bucket Aggregation key

7ac2d0b

missed stats updated struct

35c73cd

tesst

5c318c4

missed stats updated struct

baf9428

rename to HTTP_endpoint

2c26998

use as a new method (and deprecate the older) to make CI pass

1086c3b

e-n-0 force-pushed the flavien/resource-renaming branch from 119f830 to 1086c3b Compare September 1, 2025 09:56

e-n-0 added 2 commits September 1, 2025 13:12

fix protobuf

8dd61aa

rename to NewStatSpanWithHTTPEndpoint

2f0bdee

e-n-0 changed the title ~~POC: Resource renaming~~ trace/stats: Add HTTP Method and Endpoint to stat spans for resource renaming Sep 1, 2025

add release note

2fbaa04

e-n-0 added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Sep 1, 2025

e-n-0 changed the title ~~trace/stats: Add HTTP Method and Endpoint to stat spans for resource renaming~~ trace/stats: Add HTTP Method and Endpoint for resource renaming Sep 1, 2025

remove best effort

9628fac

e-n-0 marked this pull request as ready for review September 1, 2025 15:01

e-n-0 requested review from a team as code owners September 1, 2025 15:01

e-n-0 requested a review from ogaca-dd September 1, 2025 15:01

drichards-87 approved these changes Sep 1, 2025

View reviewed changes

christophe-papazian approved these changes Sep 1, 2025

View reviewed changes

ichinaski reviewed Sep 1, 2025

View reviewed changes

Comment thread pkg/trace/stats/span_concentrator.go Outdated

e-n-0 and others added 3 commits September 1, 2025 18:36

new stat span with config instead

96517d0

Merge branch 'main' into flavien/resource-renaming

fd63fd2

add comment to new config struct

55257ed

e-n-0 requested a review from ichinaski September 2, 2025 09:45

e-n-0 added qa/done QA done before merge and regressions are covered by tests and removed qa/rc-required Only for a PR that requires validation on the Release Candidate labels Sep 2, 2025

mackjmr approved these changes Sep 2, 2025

View reviewed changes

ichinaski approved these changes Sep 2, 2025

View reviewed changes

dd-mergequeue Bot merged commit ec5199a into main Sep 2, 2025
282 checks passed

dd-mergequeue Bot deleted the flavien/resource-renaming branch September 2, 2025 15:54

github-actions Bot added this to the 7.71.0 milestone Sep 2, 2025

This was referenced Sep 16, 2025

feat(tracing): resource renaming DataDog/dd-trace-py#14580

Merged

add end to end system tests for resource renaming DataDog/system-tests#5267

Merged

e-n-0 mentioned this pull request Oct 17, 2025

feat: resource renaming DataDog/dd-trace-go#3851

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

trace/stats: Add HTTP Method and Endpoint for resource renaming#39372

trace/stats: Add HTTP Method and Endpoint for resource renaming#39372
dd-mergequeue[bot] merged 14 commits into
mainfrom
flavien/resource-renaming

e-n-0 commented Jul 30, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter Bot commented Jul 30, 2025 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

Uh oh!

agent-platform-auto-pr Bot commented Sep 1, 2025 •

edited

Loading

Info

Uh oh!

Uh oh!

ichinaski left a comment

Uh oh!

e-n-0 commented Sep 2, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Sep 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

e-n-0 commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Changes

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

cit-pr-commenter Bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr Bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

Uh oh!

ichinaski left a comment

Choose a reason for hiding this comment

Uh oh!

e-n-0 commented Sep 2, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

e-n-0 commented Jul 30, 2025 •

edited

Loading

cit-pr-commenter Bot commented Jul 30, 2025 •

edited

Loading

agent-platform-auto-pr Bot commented Sep 1, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Sep 2, 2025 •

edited

Loading