Skip to content

[AGNTLOG-222] - adjust serverless to always utilize gzip compression#37523

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
ryan.hall/serverless-gzip
May 30, 2025
Merged

[AGNTLOG-222] - adjust serverless to always utilize gzip compression#37523
dd-mergequeue[bot] merged 2 commits into
mainfrom
ryan.hall/serverless-gzip

Conversation

@ddrthall

@ddrthall ddrthall commented May 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Revert to gzip compression for serverless log-agent endpoints

Motivation

Describe how you validated your changes

Automated testing is expected to cover the entirety of the verification requirements.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions Bot added short review PR is simple enough to be reviewed quickly team/agent-log-pipelines labels May 30, 2025
@ddrthall ddrthall added the qa/done QA done before merge and regressions are covered by tests label May 30, 2025
@ddrthall
ddrthall marked this pull request as ready for review May 30, 2025 20:55
@ddrthall
ddrthall requested review from a team as code owners May 30, 2025 20:55
@duncanista duncanista mentioned this pull request May 30, 2025
Closed
@ddrthall ddrthall added this to the 7.68.0 milestone May 30, 2025
@ddrthall

ddrthall commented May 30, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow

dd-devflow Bot commented May 30, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-05-30 21:03:37 UTC ℹ️ Start processing command /merge

2025-05-30 21:03:44 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-05-30 22:51:13 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-05-30 23:43:01 UTC ℹ️ MergeQueue: This merge request was merged

@cit-pr-commenter

cit-pr-commenter Bot commented May 30, 2025

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e87908cd-ae72-4995-a4ab-391b8eab82b9

Baseline: 8ad866f
Comparison: dde84c6
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
❌ quality_gate_logs % cpu utilization +7.76 [+4.88, +10.65] 1 Logs bounds checks dashboard

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
❌ quality_gate_logs % cpu utilization +7.76 [+4.88, +10.65] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization +2.20 [+1.35, +3.04] 1 Logs
➖ ddot_logs memory utilization +0.57 [+0.44, +0.71] 1 Logs
➖ quality_gate_idle memory utilization +0.37 [+0.31, +0.43] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.10 [+0.01, +0.19] 1 Logs bounds checks dashboard
➖ file_to_blackhole_500ms_latency egress throughput +0.08 [-0.48, +0.64] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.05 [-0.01, +0.10] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.02 [-0.64, +0.67] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.62, +0.63] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.61, +0.62] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.28] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.01 [-0.24, +0.22] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.63, +0.59] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.04 [-0.67, +0.60] 1 Logs
➖ ddot_metrics memory utilization -0.09 [-0.21, +0.02] 1 Logs
➖ file_tree memory utilization -0.11 [-0.27, +0.05] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.11 [-0.70, +0.48] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.19 [-0.36, -0.02] 1 Logs
➖ docker_containers_memory memory utilization -0.19 [-0.27, -0.11] 1 Logs
➖ otlp_ingest_logs memory utilization -0.33 [-0.45, -0.21] 1 Logs
➖ docker_containers_cpu % cpu utilization -0.69 [-3.75, +2.36] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -1.82 [-1.91, -1.74] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ docker_containers_memory memory_usage 0/10
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented May 30, 2025

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 8ad866f

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${\color{red}+0}$$ $${\color{green}746.97}$$ < $${752.99}$$ $${\color{red}+0.01}$$ $${\color{green}184.91}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${\color{red}+0}$$ $${\color{green}745.34}$$ < $${751.36}$$ $${\color{red}+0.04}$$ $${\color{green}184.38}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${\color{green}-0}$$ $${\color{green}369.01}$$ < $${369.68}$$ $${\color{red}+0}$$ $${\color{green}98.67}$$ < $${99.55}$$
✅ agent_msi $${\color{green}0}$$ $${\color{green}986.07}$$ < $${987.01}$$ $${\color{green}-0.01}$$ $${\color{green}149.68}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${\color{red}+0}$$ $${\color{green}746.96}$$ < $${752.98}$$ $${\color{green}-0.01}$$ $${\color{green}186.52}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${\color{red}+0}$$ $${\color{green}745.33}$$ < $${751.35}$$ $${\color{red}+0.02}$$ $${\color{green}186.25}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${\color{green}0}$$ $${\color{green}733.69}$$ < $${739.42}$$ $${\color{green}-0.02}$$ $${\color{green}168.57}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${\color{green}-0}$$ $${\color{green}732.19}$$ < $${737.91}$$ $${\color{green}-0}$$ $${\color{green}167.66}$$ < $${170.22}$$
✅ agent_suse_amd64 $${\color{red}+0}$$ $${\color{green}746.96}$$ < $${752.98}$$ $${\color{green}-0.01}$$ $${\color{green}186.52}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${\color{red}+0}$$ $${\color{green}745.33}$$ < $${751.35}$$ $${\color{red}+0.02}$$ $${\color{green}186.25}$$ < $${189.81}$$
✅ agent_suse_arm64 $${\color{green}0}$$ $${\color{green}733.69}$$ < $${739.42}$$ $${\color{green}-0.02}$$ $${\color{green}168.57}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${\color{green}-0}$$ $${\color{green}732.19}$$ < $${737.91}$$ $${\color{green}-0}$$ $${\color{green}167.66}$$ < $${170.22}$$
✅ docker_agent_amd64 $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_agent_arm64 $${\color{red}+0}$$ $${\color{green}840.94}$$ < $${858.97}$$ $${\color{green}-0}$$ $${\color{green}268.2}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${\color{red}+0}$$ $${\color{green}840.94}$$ < $${858.97}$$ $${\color{green}-0}$$ $${\color{green}268.2}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${\color{red}+0}$$ $${\color{green}830.76}$$ < $${849.39}$$ $${\color{red}+0}$$ $${\color{green}282.09}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${\color{red}+0}$$ $${\color{green}259.08}$$ < $${259.73}$$ $${\color{green}-0}$$ $${\color{green}102.83}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${\color{red}+0}$$ $${\color{green}273.49}$$ < $${274.24}$$ $${\color{red}+0}$$ $${\color{green}97.55}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${\color{red}+0}$$ $${\color{green}7.08}$$ < $${7.12}$$ $${\color{red}+0}$$ $${\color{green}2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${\color{red}+0}$$ $${\color{green}6.69}$$ < $${6.92}$$ $${\color{red}+0}$$ $${\color{green}2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${\color{red}+0}$$ $${\color{green}38.9}$$ < $${39.57}$$ $${\color{red}+0}$$ $${\color{green}14.94}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${\color{green}0}$$ $${\color{green}37.52}$$ < $${38.2}$$ $${\color{red}+0}$$ $${\color{green}13.95}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${\color{green}0}$$ $${\color{green}30.59}$$ < $${31.52}$$ $${\color{red}+0}$$ $${\color{green}8.02}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${\color{green}0}$$ $${\color{green}29.14}$$ < $${30.08}$$ $${\color{green}-0}$$ $${\color{green}6.97}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${\color{green}0}$$ $${\color{green}30.59}$$ < $${31.52}$$ $${\color{green}-0}$$ $${\color{green}8.03}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${\color{green}0}$$ $${\color{green}30.59}$$ < $${31.52}$$ $${\color{green}-0}$$ $${\color{green}8.03}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${\color{green}0}$$ $${\color{green}59.97}$$ < $${60.17}$$ $${\color{green}-0}$$ $${\color{green}15.0}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${\color{green}0}$$ $${\color{green}56.7}$$ < $${56.94}$$ $${\color{green}-0}$$ $${\color{green}12.86}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${\color{green}0}$$ $${\color{green}56.15}$$ < $${56.41}$$ $${\color{red}+0.02}$$ $${\color{green}13.02}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${\color{green}0}$$ $${\color{green}59.97}$$ < $${60.18}$$ $${\color{green}-0}$$ $${\color{green}15.01}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${\color{green}0}$$ $${\color{green}56.7}$$ < $${56.94}$$ $${\color{green}-0}$$ $${\color{green}12.88}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${\color{green}0}$$ $${\color{green}59.97}$$ < $${60.18}$$ $${\color{green}-0}$$ $${\color{green}15.01}$$ < $${15.84}$$

@dd-mergequeue
dd-mergequeue Bot merged commit dfcd7cc into main May 30, 2025
@dd-mergequeue
dd-mergequeue Bot deleted the ryan.hall/serverless-gzip branch May 30, 2025 23:43
@nhulston nhulston mentioned this pull request Sep 29, 2025
Merged
dd-mergequeue Bot pushed a commit that referenced this pull request Sep 29, 2025
@nhulston
[Serverless-Init] Use zstd compression (#41353)
4f9f46a 
### What does this PR do?

Use `zstd` compression. We just need to enable add the `zstd` build tag (in DataDog/datadog-lambda-extension#878)

[Before this change](https://github.com/DataDog/serverless-init-performance-testing/blob/main/saved-profiles/cpu-glib.pb.gz):
<img width="1000" height="62" alt="Screenshot 2025-09-29 at 12 45 16 PM" src="https://github.com/user-attachments/assets/306a6233-db57-4617-8d3e-c65adcd73537" />

[After this change](https://github.com/DataDog/serverless-init-performance-testing/blob/main/saved-profiles/cpu-zstd.pb.gz):
<img width="1000" height="62" alt="Screenshot 2025-09-29 at 12 45 24 PM" src="https://github.com/user-attachments/assets/402ffddd-e8b1-45e8-8bce-9fddddf5b5e3" />

The cum% for `(*batchStrategy).addMessage` goes down from 20.16% to 4.12%.

<img width="500" height="425" alt="Screenshot 2025-09-29 at 5 13 42 PM" src="https://github.com/user-attachments/assets/a95ac5ed-577b-4ed1-81dd-fd97e17a9782" />


For more information, see [this one-pager](https://docs.google.com/document/d/1ovNSaNk_rZKcF3SDz8Ol5ypCD_MRqpq25MsnxMgTmPU/edit?usp=sharing).

This PR pretty much just reverts #37523

### Motivation

Improving serverless-init performance
https://datadoghq.atlassian.net/browse/SVLS-7667

### Describe how you validated your changes

- Unit tests
- Manual testing & [profiling the agent](https://github.com/DataDog/serverless-init-performance-testing)
- [Serverless self-monitoring tests](https://gitlab.ddbuild.io/DataDog/serverless-init-self-monitoring/-/pipelines/77863262). It has monitors to make sure we are still receiving logs/metrics/traces
- [Serverless e2e tests](https://gitlab.ddbuild.io/DataDog/serverless-e2e-serverless-init-gcp-tests/-/pipelines/77869595/). Failures are known issues and unrelated to this change.

### Additional Notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cswatt cswatt cswatt approved these changes
@duncanista duncanista duncanista approved these changes
@soberpeach soberpeach soberpeach approved these changes

Assignees

No one assigned

Labels

qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-log-pipelines

Projects

None yet

Milestone

7.68.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ddrthall @cswatt @duncanista @soberpeach