[SVLS-5917] Add Azure Containerapp namespace for v2 billing#30783
Merged
Conversation
jcstorms1
added
changelog/no-changelog
Regression Detector |
github-actions
Bot
added
the
short review
duncanpharvey
approved these changes
Nov 5, 2024
duncanpharvey
left a comment
duncanpharvey
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Looks like you need to address some lint failures before this can be merged though
Contributor
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48300947 --os-family=ubuntuNote: This applies to commit 8d02231 |
Contributor
Author
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
acanamespace tags for spans generated in environments usingserverless-initor the sidecar mode.aca.replica.nameaca.resource.idaca.resource.groupaca.app.nameaca.app.regionaca.app.revisionaca.subscription.idMotivation
Updated billing will be introduced soon and this will standardize the span tags
https://datadoghq.atlassian.net/browse/SVLS-5917
Describe how to test/QA your changes
Unit tests
Possible Drawbacks / Trade-offs
Additional Notes