Skip to content

[Serverless] Update sidecar tagging for V2 billing#30463

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
storms/SVLS-5715
Oct 24, 2024
Merged

[Serverless] Update sidecar tagging for V2 billing#30463
dd-mergequeue[bot] merged 2 commits into
mainfrom
storms/SVLS-5715

Conversation

@jcstorms1

Copy link
Copy Markdown
Contributor

What does this PR do?

  1. Adds the _.dd prefix to the datadog_sidecar_version tag.

Motivation

Standardized tagging for V2 Billing
https://datadoghq.atlassian.net/browse/SVLS-5715

Describe how to test/QA your changes

Unit tests

Possible Drawbacks / Trade-offs

Additional Notes

@jcstorms1 jcstorms1 added changelog/no-changelog No changelog entry needed team/serverless-azure-gcp qa/done QA done before merge and regressions are covered by tests labels Oct 24, 2024
@jcstorms1 jcstorms1 added this to the 7.58.0 milestone Oct 24, 2024
@jcstorms1
jcstorms1 requested a review from a team as a code owner October 24, 2024 15:26
@agent-platform-auto-pr

Copy link
Copy Markdown
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=47352566 --os-family=ubuntu

Note: This applies to commit 902a280

@nina9753 nina9753 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function_Target changes are already there. The pt should be good for gcp cloud run functions!

@jcstorms1

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow

dd-devflow Bot commented Oct 24, 2024

Copy link
Copy Markdown

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue
dd-mergequeue Bot merged commit 5a2382d into main Oct 24, 2024
@dd-mergequeue
dd-mergequeue Bot deleted the storms/SVLS-5715 branch October 24, 2024 17:19
@github-actions github-actions Bot modified the milestones: 7.58.0, 7.60.0 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests team/serverless-azure-gcp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants