Add Metadata to Profiles from Azure Container Apps#30428
Conversation
Regression DetectorRegression Detector ResultsRun ID: 276d066e-6206-432e-9248-6798289c0a0c Metrics dashboard Target profiles Baseline: b718ef8 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | basic_py_check | % cpu utilization | +1.90 | [-0.78, +4.57] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.84 | [+0.75, +0.94] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.75 | [+0.03, +1.47] | 1 | Logs |
| ➖ | idle | memory utilization | +0.39 | [+0.34, +0.43] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.21 | [+0.16, +0.26] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.02 | [-0.16, +0.20] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.10, +0.07] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.23, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.38, +0.31] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.04 | [-0.29, +0.20] | 1 | Logs |
| ➖ | idle_all_features | memory utilization | -0.05 | [-0.15, +0.05] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.07 | [-0.56, +0.43] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.25 | [-0.37, -0.12] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -0.36 | [-1.16, +0.45] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.92 | [-0.98, -0.87] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -1.01 | [-3.52, +1.50] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
| ✅ | idle | memory_usage | 10/10 |
| ✅ | idle_all_features | memory_usage | 10/10 |
| ✅ | quality_gate_idle | memory_usage | 10/10 |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=47266622 --os-family=ubuntuNote: This applies to commit f17d507 |
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
/remove |
|
🚂 Devflow: |
|
This merge request was unqueued If you need support, contact us on Slack #devflow! |
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Adds
subscription_id,resource_group, andresource_idtags to profiles from Azure Container Apps.Motivation
Provide profiling backend with Azure Container App metadata to enable proper billing.
https://datadoghq.atlassian.net/browse/SVLS-5848
Describe how to test/QA your changes
Build serverless-init test image from https://github.com/DataDog/datadog-lambda-extension/tree/main/scripts.
Deploy to Azure Container Apps
Application Code
Dockerfile
Possible Drawbacks / Trade-offs
Additional Notes
These tags are already available on spans. With this change they are available on profiles as well.