Skip to content

[SVLS-5713] Correctly set log source in sidecar mode#30070

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
storms/svls-5713
Oct 17, 2024
Merged

[SVLS-5713] Correctly set log source in sidecar mode#30070
dd-mergequeue[bot] merged 2 commits into
mainfrom
storms/svls-5713

Conversation

@jcstorms1

Copy link
Copy Markdown
Contributor

What does this PR do?

Correctly sets the log source when using sidecar mode of serverless-init.

image

Motivation

Previously the source was incorrectly set as undefined.

image

Describe how to test/QA your changes

Live tests using an Azure App Service app with a sidecar.

Possible Drawbacks / Trade-offs

Additional Notes

@jcstorms1 jcstorms1 added team/serverless-azure-gcp qa/done QA done before merge and regressions are covered by tests labels Oct 11, 2024
@jcstorms1 jcstorms1 added this to the Triage milestone Oct 11, 2024
@jcstorms1
jcstorms1 requested a review from a team as a code owner October 11, 2024 17:56
@jcstorms1 jcstorms1 changed the title [SVLS-5713] Correctly set log source in sidecar mode of serverless-init [SVLS-5713] Correctly set log source in sidecar mode Oct 11, 2024
@jcstorms1 jcstorms1 added the changelog/no-changelog No changelog entry needed label Oct 11, 2024

@duncanpharvey duncanpharvey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agent-platform-auto-pr

Copy link
Copy Markdown
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46819179 --os-family=ubuntu

Note: This applies to commit 7fa9093

@cit-pr-commenter

Copy link
Copy Markdown

Regression Detector

@jcstorms1

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow

dd-devflow Bot commented Oct 17, 2024

Copy link
Copy Markdown

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

@dd-mergequeue
dd-mergequeue Bot merged commit f7b3b58 into main Oct 17, 2024
@dd-mergequeue
dd-mergequeue Bot deleted the storms/svls-5713 branch October 17, 2024 16:04
@github-actions github-actions Bot modified the milestones: Triage, 7.60.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests team/serverless-azure-gcp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants