Update serverless-init Cloud Run service to support cloud run functions via Cloud Functions UI#29404
Conversation
…t' into nina.rei/SVLS-5506/cloudrunfunction-serverless-init
…oud run functions vs Cloud Functions
nina9753
added
team/serverless-azure-gcp
changelog/no-changelog
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=45031697 --os-family=ubuntuNote: This applies to commit 5e3228a |
Regression DetectorRegression Detector ResultsRun ID: fc3919a4-cf19-4d55-8222-aff27a54ac5a Metrics dashboard Target profiles Baseline: 49ca38e Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | basic_py_check | % cpu utilization | +1.45 | [-1.25, +4.14] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.21 | [+0.46, +1.96] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.15 | [+0.06, +0.23] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | idle | memory utilization | -0.34 | [-0.38, -0.29] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -0.40 | [-1.21, +0.40] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.42 | [-0.48, -0.37] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -1.85 | [-4.29, +0.59] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
|
|
||
| func isCloudRunFunction() bool { | ||
| _, cloudRunFunctionMode := os.LookupEnv(functionTargetEnvVar) | ||
| _ = log.Warn(fmt.Sprintf("cloud function mode SET TO: %t", cloudRunFunctionMode)) |
There was a problem hiding this comment.
Does this really need to be assigned to _ in order for it to work? I'm guessing no.
Also, I'm thinking this is more a debug level log than a warn. What are your thoughts on that?
There was a problem hiding this comment.
Great call out! I updated the log level to debug. Line 104 returns 2 variables to i need to keep the leading _ as I am ignoring this return value
purple4reina
left a comment
purple4reina
left a comment
There was a problem hiding this comment.
Had just one question for you, otherwise looks good!
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
3 participants
What does this PR do?
Update serverless-init Cloud Run service to support Cloud Run functions
This adds the other environmental variables returned by cloud run and cloud run functions into the tag array.
K_CONFIGURATION,FUNCTION_SIGNATURE_TYPE,FUNCTION_TARGETThis also updates the metric prefix to be
gcp.cloudfunctionand the origin iscloudfunctionCustomers will now need to add the
FUNCTION_TARGETenvironment variable to their cloud run functions containerMotivation
Google Cloud Run Function now supports sidecars under cloud run
Additional Notes
Currently blocks PR #29057 which will update the origin to
cloudrunfunctionwhen we make this product GAPossible Drawbacks / Trade-offs
Currently, this approach will work for all runtimes except Go. Which does not have any out of the box environmental variables we could use to mark a service as a cloud function source deploy. We will need to force the customer to add
FUNCTION_TARGETto the variables during setup so that in datadog everything is tagged correctlyDescribe how to test/QA your changes
added a new test case
TestGetCloudRunFunctionTagsWithEnvironmentVariablesyou can also run all test locally by runninggo test -tags "test" -v ./cmd/serverless-init/...currently deployed as gcp-run-function-rc3 and deployed to our team project
datadog-serverless-gcp-demoinside the artifact registry tag serverless-init-sidercar hereYou can view the test service in the serverless org here