[Bugfix] [SLES-1749] histogram_aggregates and histogram_percentiles added to serverless in…#28102
Conversation
joeyzhao2018
added
changelog/no-changelog
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=40589774 --os-family=ubuntuNote: This applies to commit a3719e5 |
Regression DetectorRegression Detector ResultsRun ID: 56c605e6-c498-49a5-83f7-54ae4938549b Metrics dashboard Target profiles Baseline: 15e395d Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | basic_py_check | % cpu utilization | +1.56 | [-1.01, +4.12] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.24 | [+0.36, +2.12] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.90 | [+0.08, +1.71] | Logs |
| ➖ | idle | memory utilization | +0.47 | [+0.43, +0.50] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.92 | [-5.67, +3.83] | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.70 | [-14.42, +11.02] | Logs |
| ➖ | file_tree | memory utilization | -2.10 | [-2.19, -2.00] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
dustmop
left a comment
dustmop
left a comment
There was a problem hiding this comment.
Looks good, thanks for tracking this down and fixing it!
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
2 participants
https://datadoghq.atlassian.net/browse/SLES-1749
What does this PR do?
Bugfix to include two missing configurations
histogram_aggregatesandhistogram_percentilesin the config initialization for serverlessMotivation
Bugfix for https://datadoghq.atlassian.net/browse/SLES-1749
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
I used git bisect to locate the first bad commit as #23006
Then basically binary searched to find out these two configurations.
Once found, the bug became obvious as these two configurations should be included for dogstatsd configurations.