[backport][CWS] move all etw events in same goroutine as process events (#23316)#23334
Conversation
(cherry picked from commit 835f3bb)
paulcacheux
added
changelog/no-changelog
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 0f0b850d-d8fc-40d7-b2b5-b8e01e49613e Performance changes are noted in the perf column of each table:
Experiments with missing or malformed data
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration. No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.20 | [-6.36, +6.77] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.82 | [-0.59, +2.24] |
| ➖ | process_agent_standard_check | memory utilization | +0.37 | [+0.33, +0.41] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.34 | [-0.31, +0.99] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.29 | [+0.23, +0.34] |
| ➖ | idle | memory utilization | +0.26 | [+0.22, +0.29] |
| ➖ | file_to_blackhole | % cpu utilization | +0.20 | [-6.36, +6.77] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.11 | [+0.08, +0.15] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.07 | [+0.04, +0.10] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.01 | [-0.00, +0.03] |
| ➖ | trace_agent_json | ingress throughput | +0.00 | [-0.03, +0.04] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | file_tree | memory utilization | -0.21 | [-0.29, -0.12] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 51m) Use |
|
🚨 MergeQueue Gitlab pipeline didn't start on its own and we were unable to create it... Please retry. If you need support, contact us on Slack #ci-interfaces with those details! |
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 51m) Use |
2 participants
(cherry picked from commit 835f3bb)
What does this PR do?
manual backport of #23316
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes