[CWS] move all etw events in same goroutine as process events#23316
Conversation
paulcacheux
added
changelog/no-changelog
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 12c734bb-6ca2-4801-91c5-5ac35b6853f6 Performance changes are noted in the perf column of each table:
Experiments with missing or malformed data
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration. No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.68 | [-5.90, +7.26] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.15 | [+1.09, +1.21] |
| ➖ | file_to_blackhole | % cpu utilization | +0.68 | [-5.90, +7.26] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.02 | [-0.59, +0.63] |
| ➖ | trace_agent_json | ingress throughput | +0.00 | [-0.02, +0.03] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | file_tree | memory utilization | -0.01 | [-0.07, +0.06] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.02 | [-0.05, +0.02] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.03 | [-0.04, -0.01] |
| ➖ | idle | memory utilization | -0.05 | [-0.08, -0.01] |
| ➖ | process_agent_standard_check | memory utilization | -0.05 | [-0.08, -0.01] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -1.03 | [-1.06, -0.99] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.04 | [-2.46, +0.38] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
adf0df1 to
984af28
Compare
984af28 to
b72ee4e
Compare
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 50m) Use |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.52.x 7.52.x
# Navigate to the new working tree
cd .worktrees/backport-7.52.x
# Create a new branch
git switch --create backport-23316-to-7.52.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 835f3bb785e1e7a9c5c0b2893e1dd0d1fde225ac
# Push it to GitHub
git push --set-upstream origin backport-23316-to-7.52.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.52.xThen, create a pull request where the |
(cherry picked from commit 835f3bb)
3 participants
What does this PR do?
The dispatching of events must all be done in same goroutine, current implementation does it in 2 one for process events, and one for etw/frim events. This PR merges both into the same one to fix race issues.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes