Skip to content

Bump Python 3 to 3.11.5#20218

Merged
FlorentClarret merged 2 commits into
mainfrom
florentclarret/bump_python_3_11
Nov 21, 2023
Merged

Bump Python 3 to 3.11.5#20218
FlorentClarret merged 2 commits into
mainfrom
florentclarret/bump_python_3_11

Conversation

@FlorentClarret

@FlorentClarret FlorentClarret commented Oct 18, 2023

Copy link
Copy Markdown
Member

What does this PR do?

  • Bump Python 3 to 3.11.5
  • We do not build the Windows binary from our fork anymore, so we do not need to verify the signatures anymore

Motivation

Additional Notes

Relates to https://datadoghq.atlassian.net/browse/AITS-281

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@pr-commenter

pr-commenter Bot commented Oct 18, 2023

Copy link
Copy Markdown

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 19c0f682-6e6f-4ea4-ab0f-eef1bebdbaf3
Baseline: adf3b79
Comparison: 95a4529
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
file_tree egress throughput +0.13 [-1.74, +2.00] 8.86%
otel_to_otel_logs ingress throughput +0.09 [-1.49, +1.67] 7.35%
file_to_blackhole egress throughput +0.05 [-0.97, +1.07] 6.12%
trace_agent_msgpack ingress throughput +0.02 [-0.12, +0.15] 15.11%
dogstatsd_string_interner_8MiB_100k ingress throughput +0.01 [-0.05, +0.07] 17.54%
trace_agent_json ingress throughput +0.00 [-0.13, +0.14] 4.66%
dogstatsd_string_interner_8MiB_10k ingress throughput +0.00 [-0.00, +0.01] 67.81%
dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.10, +0.10] 2.14%
dogstatsd_string_interner_8MiB_100 ingress throughput +0.00 [-0.13, +0.13] 1.36%
dogstatsd_string_interner_64MiB_1k ingress throughput +0.00 [-0.13, +0.13] 0.30%
dogstatsd_string_interner_8MiB_50k ingress throughput +0.00 [-0.04, +0.04] 0.00%
dogstatsd_string_interner_64MiB_100 ingress throughput -0.00 [-0.14, +0.14] 0.74%
dogstatsd_string_interner_128MiB_100 ingress throughput -0.00 [-0.14, +0.14] 0.76%
dogstatsd_string_interner_128MiB_1k ingress throughput -0.00 [-0.14, +0.14] 2.41%
idle egress throughput -0.01 [-2.55, +2.54] 0.40%
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.17, +0.15] 6.39%
uds_dogstatsd_to_api ingress throughput -0.02 [-0.20, +0.16] 17.58%
process_agent_standard_check_with_stats egress throughput -0.05 [-2.09, +1.98] 3.54%
tcp_syslog_to_blackhole ingress throughput -0.09 [-0.22, +0.03] 77.28%
process_agent_standard_check egress throughput -0.13 [-3.67, +3.41] 4.86%
process_agent_real_time_mode egress throughput -0.16 [-2.68, +2.36] 8.37%

@FlorentClarret
FlorentClarret force-pushed the florentclarret/bump_python_3_11 branch from 2e0f8f6 to 809aa68 Compare October 18, 2023 12:55
@FlorentClarret FlorentClarret added this to the Triage milestone Oct 18, 2023
@FlorentClarret
FlorentClarret force-pushed the florentclarret/bump_python_3_11 branch 4 times, most recently from 0b92b3a to b0f5c6b Compare October 25, 2023 14:59
@FlorentClarret
FlorentClarret force-pushed the florentclarret/bump_python_3_11 branch 2 times, most recently from 006f6bb to ce71712 Compare November 2, 2023 10:24
@FlorentClarret
FlorentClarret force-pushed the florentclarret/bump_python_3_11 branch from 08ff5e6 to d5ea1a4 Compare November 7, 2023 09:04
Comment thread test/kitchen/test/integration/common/rspec_datadog/spec_helper.rb Outdated
@FlorentClarret
FlorentClarret force-pushed the florentclarret/bump_python_3_11 branch 5 times, most recently from 6879ec6 to 46c0fc4 Compare November 17, 2023 07:17
@FlorentClarret FlorentClarret modified the milestones: Triage, 7.51.0 Nov 20, 2023
@FlorentClarret
FlorentClarret marked this pull request as ready for review November 20, 2023 06:48
@FlorentClarret
FlorentClarret requested review from a team as code owners November 20, 2023 06:48
@FlorentClarret FlorentClarret added [deprecated] team/agent-platform major_change Complex/large change, which significantly modifies agent behavior or could impact many agent teams labels Nov 20, 2023
@FlorentClarret
FlorentClarret force-pushed the florentclarret/bump_python_3_11 branch from 46c0fc4 to 6620d88 Compare November 20, 2023 06:55
Comment thread omnibus/config/projects/agent.rb Outdated
Comment thread omnibus/config/software/datadog-agent-finalize.rb Outdated
Comment thread omnibus/config/software/python3.rb Outdated
@FlorentClarret
FlorentClarret force-pushed the florentclarret/bump_python_3_11 branch from 6620d88 to 95a4529 Compare November 20, 2023 08:43

@chouquette chouquette left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@alai97 alai97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion!

Comment thread releasenotes/notes/python311-b4bcd71d0ef722e9.yaml Outdated
@FlorentClarret
FlorentClarret merged commit 7a43594 into main Nov 21, 2023
@FlorentClarret
FlorentClarret deleted the florentclarret/bump_python_3_11 branch November 21, 2023 07:05
vickenty added a commit that referenced this pull request Dec 7, 2023
@julien-lebot julien-lebot mentioned this pull request Dec 21, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[deprecated] team/agent-platform [deprecated] team/integrations major_change Complex/large change, which significantly modifies agent behavior or could impact many agent teams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants