Skip to content

[CWS] get rid of invalidate_dentry#17543

Merged
safchain merged 1 commit into
mainfrom
safchain/path-id-cache
Jun 16, 2023
Merged

[CWS] get rid of invalidate_dentry#17543
safchain merged 1 commit into
mainfrom
safchain/path-id-cache

Conversation

@safchain

@safchain safchain commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

We can rely only on the path_id in order to properly resolve the correct path.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@safchain safchain added this to the 7.47.0 milestone Jun 8, 2023
@pr-commenter

pr-commenter Bot commented Jun 8, 2023

Copy link
Copy Markdown

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 3582c978-cc6b-4c44-a7ca-4c926ca31951
Baseline: 0475eb9
Comparison: ca4f710
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment goal Δ mean % confidence
tcp_dd_logs_filter_exclude ingress throughput -6.08 100.00%
Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
tcp_syslog_to_blackhole ingress throughput +1.17 [+1.06, +1.28] 100.00%
file_to_blackhole egress throughput +0.18 [-0.49, +0.85] 26.65%
trace_agent_json ingress throughput +0.09 [-0.16, +0.33] 35.78%
trace_agent_msgpack ingress throughput -0.96 [-1.14, -0.78] 100.00%
uds_dogstatsd_to_api ingress throughput -1.64 [-2.67, -0.61] 95.90%
otel_to_otel_logs ingress throughput -1.65 [-1.75, -1.56] 100.00%
tcp_dd_logs_filter_exclude ingress throughput -6.08 [-6.28, -5.87] 100.00%

@safchain
safchain marked this pull request as ready for review June 9, 2023 07:36
@safchain
safchain requested a review from a team as a code owner June 9, 2023 07:36
@safchain
safchain force-pushed the safchain/path-id-cache branch 2 times, most recently from 3cdaff2 to 75fe223 Compare June 15, 2023 08:38

@Gui774ume Gui774ume left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK everything looks good to me 🚢

@safchain
safchain force-pushed the safchain/path-id-cache branch from 75fe223 to ca4f710 Compare June 15, 2023 15:25
@safchain
safchain merged commit 8f6bdc7 into main Jun 16, 2023
@safchain
safchain deleted the safchain/path-id-cache branch June 16, 2023 09:39
safchain added a commit that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants