Let the Windows installer set the correct rights on config files and directories.#588
Merged
Conversation
Member
|
need to check: whether earlier versions of the cookbook work with agents v6 >= 6.11 (on Windows) |
olivielpeau
self-requested a review
March 8, 2019 16:16
Contributor
Author
|
I've tested it with versions <6.11 (such as 6.8.0) and it worked well 👍 |
olivielpeau
reviewed
Mar 13, 2019
olivielpeau
left a comment
olivielpeau
left a comment
Member
There was a problem hiding this comment.
2 comments:
- What about the similar logic in our
datadog_monitorprovider?chef-datadog/providers/monitor.rb
Lines 13 to 17 in 0cc4f6a
- I think there was a small misunderstanding on my earlier comment: I meant to ask if version
2.17.0of the cookbook is able to successfully install a version of the Windows Agent running underdd-agent-user. If not, it means that users trying to install such a Windows Agent version with older versions of the cookbook will run into issues, so we should make sure it's documented in a very obvious way (here + in the Agent changelog + any other docs we may provide; we can discuss this in chat/offline if needed)
Contributor
Author
|
remeh
force-pushed
the
remeh/windows-dd-agent-user
branch
from
March 13, 2019 17:39
c612ebc to
4b0cf11
Compare
Contributor
Author
|
Please note that the CHANGELOG for release 2.18.0 has been updated accordingly: #589 |
olivielpeau
suggested changes
Mar 14, 2019
olivielpeau
left a comment
olivielpeau
left a comment
Member
There was a problem hiding this comment.
Left a few additional comments
The ddagentuser is only for Windows Agent v6.
olivielpeau
approved these changes
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .MSI to setup the Agent on Windows will soon run the Agent in a custom user with less privileges (than Administrator).
This commit removes the permissions change on
datadog.yamlon Windows to let the installer set it itself.I've tested that the Agent still runs while installing
6.8.0and6.10.0.Note that this PR doesn't change the behavior for the Agent 5.