Skip to content

✅ fix flaky test#3837

Merged
BenoitZugmeyer merged 1 commit into
mainfrom
benoit/push-qxtnlotumvqo
Sep 15, 2025
Merged

✅ fix flaky test#3837
BenoitZugmeyer merged 1 commit into
mainfrom
benoit/push-qxtnlotumvqo

Conversation

@BenoitZugmeyer

@BenoitZugmeyer BenoitZugmeyer commented Sep 12, 2025

Copy link
Copy Markdown
Member

Motivation

The task queue was not properly stopped when a test finished

Jasmine seed: 95071

Changes

Stop the task queue when resource collection is stopped

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@BenoitZugmeyer
✅ fix flaky test
2e9f7ac 
The task queue was not properly stopped when a test finished

Jasmine seed: 95071
@BenoitZugmeyer
BenoitZugmeyer requested a review from a team as a code owner September 12, 2025 14:17
@datadog-official

datadog-official Bot commented Sep 12, 2025

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 92.25% (-0.13%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2e9f7ac | Docs | Was this helpful? Give us feedback!

@cit-pr-commenter

cit-pr-commenter Bot commented Sep 12, 2025

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 157.25 KiB 157.28 KiB 28 B 0.02% ✅
Rum Recorder 19.53 KiB 19.53 KiB 0 B 0.00% ✅
Rum Profiler 5.18 KiB 5.18 KiB 0 B 0.00% ✅
Logs 55.74 KiB 55.74 KiB 0 B 0.00% ✅
Flagging N/A 931 B 931 B N/A% ✅
Rum Slim 114.99 KiB 115.02 KiB 28 B 0.02% ✅
Worker 23.60 KiB 23.60 KiB 0 B 0.00% ✅
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.005 0.008 0.002
addaction 0.019 0.023 0.003
addtiming 0.006 0.004 -0.002
adderror 0.025 0.024 -0.002
startstopsessionreplayrecording 0.001 0.001 -0.000
startview 0.006 0.007 0.002
logmessage 0.029 0.023 -0.006
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 25.19 KiB 25.91 KiB 732 B
addaction 44.59 KiB 48.38 KiB 3.79 KiB
addtiming 24.83 KiB 24.61 KiB -227 B
adderror 50.20 KiB 51.10 KiB 918 B
startstopsessionreplayrecording 24.18 KiB 23.85 KiB -340 B
startview 422.52 KiB 431.31 KiB 8.78 KiB
logmessage 41.24 KiB 42.82 KiB 1.58 KiB

🔗 RealWorld

@BenoitZugmeyer
BenoitZugmeyer merged commit a9f9ef7 into main Sep 15, 2025
21 checks passed
@BenoitZugmeyer
BenoitZugmeyer deleted the benoit/push-qxtnlotumvqo branch September 15, 2025 07:42
rgaignault pushed a commit that referenced this pull request Sep 15, 2025
@BenoitZugmeyer @rgaignault
✅ fix flaky test (#3837)
ec5b1ce 
The task queue was not properly stopped when a test finished

Jasmine seed: 95071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcaudan bcaudan bcaudan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BenoitZugmeyer @bcaudan