Skip to content

Bump slack-notifier version#3809

Merged
BenoitZugmeyer merged 1 commit into
mainfrom
engraver-auto-campaigner/bump-slack-notifier-version-1756741811
Sep 8, 2025
Merged

Bump slack-notifier version#3809
BenoitZugmeyer merged 1 commit into
mainfrom
engraver-auto-campaigner/bump-slack-notifier-version-1756741811

Conversation

@campaigner-prod

@campaigner-prod campaigner-prod Bot commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Update the slack notifier template to v3-sdm.

Who will it impact?

Developer interacting with CI.

Motivation

Migrate off runner:docker and runner:main
slack-notifier v1 template uses deprecated runners ; i.e. runner:main.
slack-notifier v2 template uses deprecated runners ; i.e. runner:main.
slack-notifier v3-sdm template uses our golden path runners ; i.e. arch:amd64.

Note

contact us on #ci-runner-docker-deprecation

---------- Additional Campaigner Information ----------
Atlas RunID: 5c1e6852-b43c-4f77-8a91-657a18ce3ed9

@campaigner-prod
campaigner-prod Bot requested a review from a team as a code owner September 1, 2025 15:50
@datadog-official

datadog-official Bot commented Sep 1, 2025 •
edited
Loading

Copy link
Copy Markdown

⚠️ Tests

⚠️ Warnings

🧪 5 Tests failed

bridge present › do not send records when the recording is stopped from eventBridge.scenario.ts (Datadog) 
createTest.ts:206:3 do not send records when the recording is stopped

[Edge] › ../lib/framework/createTest.ts:206:3 › bridge present › do not send records when the recording is stopped 

    Error: page.waitForTimeout: waitTimeout: expected number, got undefined

       at eventBridge.scenario.ts:110

      108 |     .run(async ({ flushEvents, intakeRegistry, page }) => {
      109 |       // wait for recorder to be properly started
...
bridge present › send action from eventBridge.scenario.ts (Datadog) 
createTest.ts:206:3 send action

[Edge] › ../lib/framework/createTest.ts:206:3 › bridge present › send action ─────────────────────

    Error: page.waitForTimeout: waitTimeout: expected number, got undefined

       at eventBridge.scenario.ts:21

      19 |       await button.click()
      20 |       // wait for click chain to close
...
recorder › layout viewport properties › getScrollX/Y should not be affected by pinch scroll from recorder/viewports.scenario.ts (Datadog) 
createTest.ts:206:3 getScrollX/Y should not be affected by pinch scroll

[Edge] › ../lib/framework/createTest.ts:206:3 › recorder › layout viewport properties › getScrollX/Y should not be affected by pinch scroll 

    Error: page.waitForTimeout: waitTimeout: expected number, got undefined

       at recorder/viewports.scenario.ts:158

      156 |     ],
      157 |   })
...
View all

ℹ️ Info

❄️ No new flaky tests detected

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 92.57% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 26988bc | Docs | Was this helpful? Give us feedback!

@cit-pr-commenter

cit-pr-commenter Bot commented Sep 1, 2025

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 155.93 KiB 155.93 KiB 0 B 0.00% ✅
Rum Recorder 19.53 KiB 19.53 KiB 0 B 0.00% ✅
Rum Profiler 5.18 KiB 5.18 KiB 0 B 0.00% ✅
Logs 55.12 KiB 55.12 KiB 0 B 0.00% ✅
Flagging N/A 931 B 931 B N/A% ✅
Rum Slim 113.80 KiB 113.80 KiB 0 B 0.00% ✅
Worker 23.60 KiB 23.60 KiB 0 B 0.00% ✅
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.009 0.013 0.004
addaction 0.029 0.042 0.013
addtiming 0.007 0.007 0.000
adderror 0.024 0.033 0.009
startstopsessionreplayrecording 0.002 0.002 0.000
startview 0.007 0.011 0.004
logmessage 0.031 0.051 0.019
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 25.28 KiB 25.05 KiB -234 B
addaction 44.65 KiB 45.72 KiB 1.06 KiB
addtiming 25.00 KiB 24.68 KiB -325 B
adderror 50.24 KiB 51.92 KiB 1.68 KiB
startstopsessionreplayrecording 24.23 KiB 23.51 KiB -730 B
startview 423.17 KiB 428.96 KiB 5.79 KiB
logmessage 43.50 KiB 42.74 KiB -783 B

🔗 RealWorld

allspain
allspain approved these changes Sep 2, 2025
View reviewed changes

@allspain allspain left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only curious what the version is but see no harm in approving

@chagui

chagui commented Sep 2, 2025

Copy link
Copy Markdown

Checked permissions:

$ ddtool auth whois --datacenter=us1.ddbuild.io gitlab-runner-browser-sdk
[ddtool] group memberships are cached based on the user's last login and MAY BE OUT OF DATE
name: gitlab-runner-browser-sdk
id: e8084c2e-34ad-be23-a68d-8e0a25769876
groups: [k8s_gitlab-runner_robots role-sign-oci-images ci-images-robots]
identity server: https://vault.us1.ddbuild.io

@chagui

chagui commented Sep 3, 2025

Copy link
Copy Markdown

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-03 10:09:24 UTC ℹ️ Start processing command /merge

2025-09-03 10:09:31 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-03 14:10:11 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@chagui

chagui commented Sep 8, 2025

Copy link
Copy Markdown

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-08 09:44:53 UTC ℹ️ Start processing command /merge

2025-09-08 09:45:03 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-08 13:45:10 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@BenoitZugmeyer
BenoitZugmeyer merged commit 9ebdd36 into main Sep 8, 2025
19 of 21 checks passed
@BenoitZugmeyer
BenoitZugmeyer deleted the engraver-auto-campaigner/bump-slack-notifier-version-1756741811 branch September 8, 2025 13:57
BeltranBulbarellaDD pushed a commit that referenced this pull request Sep 12, 2025
@campaigner-prod @BeltranBulbarellaDD
ci: bump slack-notifier to v3-sdm (#3809)
db34527 
Co-authored-by: campaigner-prod[bot] <87874424+campaigner-prod[bot]@users.noreply.github.com>
rgaignault pushed a commit that referenced this pull request Sep 15, 2025
@campaigner-prod @rgaignault
ci: bump slack-notifier to v3-sdm (#3809)
6a2dc66 
Co-authored-by: campaigner-prod[bot] <87874424+campaigner-prod[bot]@users.noreply.github.com>
BenoitZugmeyer added a commit that referenced this pull request Feb 2, 2026
@BenoitZugmeyer
Bump slack-notifier version
3941097 
Previous PR missed a few occurrences #3809
@BenoitZugmeyer BenoitZugmeyer mentioned this pull request Feb 2, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes
@allspain allspain allspain approved these changes

Assignees

No one assigned

Labels

campaigner-automated-change mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chagui @BenoitZugmeyer @allspain