Feature/enforced 2fa check#355
Merged
srobakidze-dashlane merged 2 commits intomasterfrom Feb 10, 2026
Merged
Conversation
1b78bea to
894889f
Compare
894889f to
a4535e4
Compare
jarroyorodriguez-dashlane
approved these changes
Feb 10, 2026
arenault-dashlane
approved these changes
Feb 10, 2026
a4535e4 to
452d99e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When 2FA is enforced by an admin, users are currently not blocked during login.
They can successfully log in, but:
This results in a confusing and broken user experience.
Solution
Block the user during the sync stage if:
In this case, the user is shown an explicit error message prompting them to:
Changes