patches: initial commit with patches for PC Engines#1
Conversation
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
|
|
||
| ```bash | ||
| git branch patchqueue | ||
| git checkout 4.19 -b patchqueue |
There was a problem hiding this comment.
(single comment, don't treat it as full review)
I suggest calling git format-patch with --base=<commit>. This will add base-commit: <commit> to the end of first created patch, which in turn should make it easier to find a point where it applies clearly, even after some time. There is also --base=auto, but I find it unreliable for some cases. Full commit digest would also help reviewer (or maybe even CI in the future) to test whether patches are created on top of expected base commit, and not some locally modified content.
There was a problem hiding this comment.
@krystian-hebel As you can see I experimented with that: #4
We do not yet understand how patches are managed using tools like Guilt. I'm pretty sure my lack of understanding of the tool contributes to the lack of convincing documentation and a comprehensive process, so the whole approach is at the pre-PoC stage. We can also consult professionals who have used the tool for a very long time, like Andrew. I'm pretty sure they use tools for a reason.
At first glance, I see a lot of benefits of using guilt, but I didn't produce release yet so maybe my observations are not yet good enough evidence of guilt value. For example, as explained in README.md (How to handle bug in patches ?), the way of updating patches seems to be very convenient.
The second thing I really recommend is playing with guilt since the experience is much different between reading about it vs using it; when I read about guilt, I was very skeptical, but while using it, I see more and more value when juggling with patches.
|
Any background on motivation? Why store sets of patches in git on top of some git changes instead of just using branches? |
Signed-off-by: Piotr Król <[email protected]>
|
@SergiiDmytruk I think your questions are very important for the effort presented here, so I created a dedicated PR to address your questions: https://github.com/Dasharo/dasharo-pq/pull/5/files - let's move the discussion there. |
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
…xe and add memtestv5 Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
…rrect file names Signed-off-by: Piotr Król <[email protected]>
…ve dependency on apu5 Signed-off-by: Piotr Król <[email protected]>
…g warnings Signed-off-by: Piotr Król <[email protected]>
…cable on 24.05 Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
…cable on 24.05 Signed-off-by: Piotr Król <[email protected]>
…cable on 24.05 Signed-off-by: Piotr Król <[email protected]>
…cable on 24.05 Signed-off-by: Piotr Król <[email protected]>
…n 24.05 Signed-off-by: Piotr Król <[email protected]>
…cable on 24.05 Signed-off-by: Piotr Król <[email protected]>
… on 24.05 Signed-off-by: Piotr Król <[email protected]>
…cable on 24.05 Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
…cable on 24.05 Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
…ortbootorder Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
…ucibility Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
…h-fixes Pcengines seabios 24.05.00.01 patch fixes
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
|
Unfortunately, the deadline is coming, and I have to move on with this PR, so I'm merging it. in case of future questions about the Dasharo Patchqueue Initiative, feel free to issue a bug and assign it to me. |
This commit consist of patchqueue tested against coreboot 4.19 tag, this queue should produce v4.19.0.1 build and in future be used for Dasharo (coreboot+SeaBIOS) releases.