Skip to content

patches: initial commit with patches for PC Engines#1

Merged
pietrushnic merged 59 commits intomainfrom
pcengines-seabios-25.05.00.01
Jun 25, 2024
Merged

patches: initial commit with patches for PC Engines#1
pietrushnic merged 59 commits intomainfrom
pcengines-seabios-25.05.00.01

Conversation

@pietrushnic
Copy link
Copy Markdown
Contributor

This commit consist of patchqueue tested against coreboot 4.19 tag, this queue should produce v4.19.0.1 build and in future be used for Dasharo (coreboot+SeaBIOS) releases.

@pietrushnic pietrushnic changed the title patches: initial commit with patches for PC Engines WIP: patches: initial commit with patches for PC Engines May 17, 2024
@pietrushnic pietrushnic requested review from macpijan and miczyg1 May 17, 2024 14:14
@pietrushnic pietrushnic self-assigned this May 17, 2024
@pietrushnic pietrushnic changed the base branch from main to pcengines-seabios-25.05.00.01-patches May 17, 2024 14:21

```bash
git branch patchqueue
git checkout 4.19 -b patchqueue
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(single comment, don't treat it as full review)

I suggest calling git format-patch with --base=<commit>. This will add base-commit: <commit> to the end of first created patch, which in turn should make it easier to find a point where it applies clearly, even after some time. There is also --base=auto, but I find it unreliable for some cases. Full commit digest would also help reviewer (or maybe even CI in the future) to test whether patches are created on top of expected base commit, and not some locally modified content.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krystian-hebel As you can see I experimented with that: #4

We do not yet understand how patches are managed using tools like Guilt. I'm pretty sure my lack of understanding of the tool contributes to the lack of convincing documentation and a comprehensive process, so the whole approach is at the pre-PoC stage. We can also consult professionals who have used the tool for a very long time, like Andrew. I'm pretty sure they use tools for a reason.

At first glance, I see a lot of benefits of using guilt, but I didn't produce release yet so maybe my observations are not yet good enough evidence of guilt value. For example, as explained in README.md (How to handle bug in patches ?), the way of updating patches seems to be very convenient.

The second thing I really recommend is playing with guilt since the experience is much different between reading about it vs using it; when I read about guilt, I was very skeptical, but while using it, I see more and more value when juggling with patches.

@SergiiDmytruk
Copy link
Copy Markdown
Member

Any background on motivation? Why store sets of patches in git on top of some git changes instead of just using branches?

@pietrushnic
Copy link
Copy Markdown
Contributor Author

@SergiiDmytruk I think your questions are very important for the effort presented here, so I created a dedicated PR to address your questions: https://github.com/Dasharo/dasharo-pq/pull/5/files - let's move the discussion there.

Signed-off-by: Piotr Król <[email protected]>
…h-fixes

Pcengines seabios 24.05.00.01 patch fixes
Base automatically changed from pcengines-seabios-25.05.00.01-patches to main June 25, 2024 21:36
@pietrushnic pietrushnic changed the title WIP: patches: initial commit with patches for PC Engines patches: initial commit with patches for PC Engines Jun 25, 2024
@pietrushnic
Copy link
Copy Markdown
Contributor Author

Unfortunately, the deadline is coming, and I have to move on with this PR, so I'm merging it. in case of future questions about the Dasharo Patchqueue Initiative, feel free to issue a bug and assign it to me.

@pietrushnic pietrushnic merged commit 8eba126 into main Jun 25, 2024
@pietrushnic pietrushnic deleted the pcengines-seabios-25.05.00.01 branch June 25, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants