refactor: Remove redundant file check from AutoFile shift operators

MarcoFalke · MarcoFalke · commit fafe2ca0ce84 · 2023-07-12T10:00:56.000+02:00
The shift operators will call the write or read member function, which
already does the check. Also, call sites are free to directly call
::(Un)Serialize(s, obj) to skip this check, so removing it increases
consistency.
diff --git a/src/streams.h b/src/streams.h
@@ -560,15 +560,13 @@ class AutoFile
     template <typename T>
     AutoFile& operator<<(const T& obj)
     {
-        if (!file) throw std::ios_base::failure("AutoFile::operator<<: file handle is nullptr");
         ::Serialize(*this, obj);
         return *this;
     }
 
     template <typename T>
     AutoFile& operator>>(T&& obj)
     {
-        if (!file) throw std::ios_base::failure("AutoFile::operator>>: file handle is nullptr");
         ::Unserialize(*this, obj);
         return *this;
     }
@@ -588,19 +586,13 @@ class CAutoFile : public AutoFile
     template<typename T>
     CAutoFile& operator<<(const T& obj)
     {
-        // Serialize to this stream
-        if (!file)
-            throw std::ios_base::failure("CAutoFile::operator<<: file handle is nullptr");
         ::Serialize(*this, obj);
         return (*this);
     }
 
     template<typename T>
     CAutoFile& operator>>(T&& obj)
     {
-        // Unserialize from this stream
-        if (!file)
-            throw std::ios_base::failure("CAutoFile::operator>>: file handle is nullptr");
         ::Unserialize(*this, obj);
         return (*this);
     }

Original file line number	Diff line number	Diff line change
`@@ -560,15 +560,13 @@ class AutoFile`
`560`	`560`	`template <typename T>`
`561`	`561`	`AutoFile& operator<<(const T& obj)`
`562`	`562`	`{`
`563`		`- if (!file) throw std::ios_base::failure("AutoFile::operator<<: file handle is nullptr");`
`564`	`563`	`::Serialize(*this, obj);`
`565`	`564`	`return *this;`
`566`	`565`	`}`
`567`	`566`
`568`	`567`	`template <typename T>`
`569`	`568`	`AutoFile& operator>>(T&& obj)`
`570`	`569`	`{`
`571`		`- if (!file) throw std::ios_base::failure("AutoFile::operator>>: file handle is nullptr");`
`572`	`570`	`::Unserialize(*this, obj);`
`573`	`571`	`return *this;`
`574`	`572`	`}`
`@@ -588,19 +586,13 @@ class CAutoFile : public AutoFile`
`588`	`586`	`template<typename T>`
`589`	`587`	`CAutoFile& operator<<(const T& obj)`
`590`	`588`	`{`
`591`		`- // Serialize to this stream`
`592`		`- if (!file)`
`593`		`- throw std::ios_base::failure("CAutoFile::operator<<: file handle is nullptr");`
`594`	`589`	`::Serialize(*this, obj);`
`595`	`590`	`return (*this);`
`596`	`591`	`}`
`597`	`592`
`598`	`593`	`template<typename T>`
`599`	`594`	`CAutoFile& operator>>(T&& obj)`
`600`	`595`	`{`
`601`		`- // Unserialize from this stream`
`602`		`- if (!file)`
`603`		`- throw std::ios_base::failure("CAutoFile::operator>>: file handle is nullptr");`
`604`	`596`	`::Unserialize(*this, obj);`
`605`	`597`	`return (*this);`
`606`	`598`	`}`