rpc: Select int-UniValue constructor for enum value in upgradewallet RPC

MacroFake · MacroFake · commit fa3a9a1e8d9b · 2022-07-14T11:56:13.000+02:00
UniValue does not have a constructor for enum values, however the
compiler will decay the enum into an int and select that constructor.
Avoid this compiler magic and clarify the code by explicitly selecting
the int-constructor.

This is needed for the next commit.
diff --git a/src/wallet/rpc/wallet.cpp b/src/wallet/rpc/wallet.cpp
@@ -532,7 +532,7 @@ static RPCHelpMan upgradewallet()
         "\nUpgrade the wallet. Upgrades to the latest version if no version number is specified.\n"
         "New keys may be generated and a new wallet backup will need to be made.",
         {
-            {"version", RPCArg::Type::NUM, RPCArg::Default{FEATURE_LATEST}, "The version number to upgrade to. Default is the latest wallet version."}
+            {"version", RPCArg::Type::NUM, RPCArg::Default{int{FEATURE_LATEST}}, "The version number to upgrade to. Default is the latest wallet version."}
         },
         RPCResult{
             RPCResult::Type::OBJ, "", "",

Original file line number	Diff line number	Diff line change
`@@ -532,7 +532,7 @@ static RPCHelpMan upgradewallet()`
`532`	`532`	`"\nUpgrade the wallet. Upgrades to the latest version if no version number is specified.\n"`
`533`	`533`	`"New keys may be generated and a new wallet backup will need to be made.",`
`534`	`534`	`{`
`535`		`- {"version", RPCArg::Type::NUM, RPCArg::Default{FEATURE_LATEST}, "The version number to upgrade to. Default is the latest wallet version."}`
	`535`	`+ {"version", RPCArg::Type::NUM, RPCArg::Default{int{FEATURE_LATEST}}, "The version number to upgrade to. Default is the latest wallet version."}`
`536`	`536`	`},`
`537`	`537`	`RPCResult{`
`538`	`538`	`RPCResult::Type::OBJ, "", "",`