Skip to content

Fix crash on double yielding Iterators - #2

Closed
DanielNoord wants to merge 1 commit into
masterfrom
agents/fix-mypyc-attribute-error
Closed

DanielNoord wants to merge 1 commit into
masterfrom
agents/fix-mypyc-attribute-error

Conversation

@DanielNoord

Copy link
Copy Markdown
Owner

...

@DanielNoord
DanielNoord force-pushed the agents/fix-mypyc-attribute-error branch from dea3d14 to 665a30c Compare August 9, 2026 20:26
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@DanielNoord
DanielNoord force-pushed the agents/fix-mypyc-attribute-error branch from 481c08f to 009644d Compare August 9, 2026 20:53
p-sawicki pushed a commit to python/mypy that referenced this pull request Aug 10, 2026
Closes mypyc/mypyc#1210

This fixes another issue I ran into while trying to use `mypyc` for
`isort`.

I am aware the contributing guidelines say new contributors are not
encouraged to use LLMs but I hope this can get the same handling as
#21785. I have tried to ensure this
patch works as much as I can by:

Testing locally with `pytest mypyc/test/test_run.py `.
Tested that the test fails on `master` without the changes.
Also tried to run CI on my local fork
(DanielNoord#2), which succeeded.

As with the previous PR, feel free to push changes to the branch or
cherry pick this into another branch. I just want to unblock `isort` :)
@DanielNoord
DanielNoord deleted the agents/fix-mypyc-attribute-error branch August 11, 2026 21:13
hauntsaninja pushed a commit to python/mypy that referenced this pull request Aug 15, 2026
Closes mypyc/mypyc#1210

This fixes another issue I ran into while trying to use `mypyc` for
`isort`.

I am aware the contributing guidelines say new contributors are not
encouraged to use LLMs but I hope this can get the same handling as
#21785. I have tried to ensure this
patch works as much as I can by:

Testing locally with `pytest mypyc/test/test_run.py `.
Tested that the test fails on `master` without the changes.
Also tried to run CI on my local fork
(DanielNoord#2), which succeeded.

As with the previous PR, feel free to push changes to the branch or
cherry pick this into another branch. I just want to unblock `isort` :)
hauntsaninja pushed a commit to python/mypy that referenced this pull request Aug 15, 2026
Closes mypyc/mypyc#1210

This fixes another issue I ran into while trying to use `mypyc` for
`isort`.

I am aware the contributing guidelines say new contributors are not
encouraged to use LLMs but I hope this can get the same handling as
#21785. I have tried to ensure this
patch works as much as I can by:

Testing locally with `pytest mypyc/test/test_run.py `.
Tested that the test fails on `master` without the changes.
Also tried to run CI on my local fork
(DanielNoord#2), which succeeded.

As with the previous PR, feel free to push changes to the branch or
cherry pick this into another branch. I just want to unblock `isort` :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant