This repository was archived by the owner on May 9, 2025. It is now read-only.
Removed developer description #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the developer description field and adjusted inspector/drawer usage accordingly.
Owner
|
I've thought about this myself, I never really used them when working on my own game. Seeing as they're broken in 2019.3, and I'm way too busy to fix it at the moment, I think this might be a good time to say goodbye to descriptions. You could argue that if the asset isn't understandable simply from its name, it's probably too complex, and should probably be split into multiple modules. |
Owner
|
Thanks for the great PR, as always :) |
Contributor
Absolutely, totally agree with you on that end.
Glad to help! |
|
I understand, but I'm sad to see this feature go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm not sure if this would be useful to you, but we found after some use that we didn't like developer description as a feature because it would result in long strings being shipped with a build and rely more on the name of the SO asset to be self-documenting (or outline general usage of SO assets elsewhere). This PR removes the developer description type and adjusts its usage accordingly across the library.
Feel free to close this if not useful for you.