Skip to content

Commit e1ba893

Browse files
stuartmorgan-gDanTup
authored andcommitted
Fix plugin tests after Pigeon plugin template changes (flutter#193302)
Replaces "handle" in the plugin symbol check, which was looking for the `handleMethod` method, with `getPlatformVersion`, as the new Pigeon version of the plugin template replaced `handleMethod` with `getPlatformVersion`. Fixes flutter#193294
1 parent 9c2ce71 commit e1ba893

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

‎packages/flutter_tools/test/integration.shard/ios_content_validation_test.dart‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,7 @@ void main() {
159159
: outputRunnerBinary.path;
160160
final bool helloStatic = AppleTestUtils.getExportedSymbols(binaryPath).any(
161161
(String symbol) =>
162-
symbol.contains('HelloPlugin') &&
163-
// Ignore the Pigeon API class, which is also generated in Dart code.
164-
!symbol.contains('HelloPluginApi') &&
165-
symbol.contains('handle'),
162+
symbol.contains('HelloPlugin') && symbol.contains('getPlatformVersion'),
166163
);
167164

168165
// Plugin is a dynamic xor static framework.
@@ -440,10 +437,7 @@ void main() {
440437
final bool helloDynamic = pluginFrameworkBinary.existsSync();
441438
final bool helloStatic = AppleTestUtils.getExportedSymbols(runnerBinary.path).any(
442439
(String symbol) =>
443-
symbol.contains('HelloPlugin') &&
444-
// Ignore the Pigeon API class, which is also generated in Dart code.
445-
!symbol.contains('HelloPluginApi') &&
446-
symbol.contains('handle'),
440+
symbol.contains('HelloPlugin') && symbol.contains('getPlatformVersion'),
447441
);
448442

449443
// Plugin is a dynamic xor static framework.

0 commit comments

Comments
 (0)