Skip to content

Commit c8a5c22

Browse files
harryterkelsenDanTup
authored andcommitted
[web] Unskip TextPainter.getWordBoundary test (flutter#193378)
Unskips the `TextPainter.getWordBoundary works` test in `packages/flutter/test/painting/text_painter_test.dart`. It was skipped on web (`skip: isBrowser`) for flutter#61017 and now passes on Chrome, both with the default compiler and with `--wasm`. This removes the last web skip that references flutter#61017. The other web skip in this file (invalid UTF-16 handling, flutter#87544) is unchanged because that test still fails on web. Related issues: - flutter#61017 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent f5318ee commit c8a5c22

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎packages/flutter/test/painting/text_painter_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1737,7 +1737,7 @@ void main() {
17371737
textPainter.getWordBoundary(const TextPosition(offset: 8)),
17381738
const TextRange(start: 8, end: 16),
17391739
);
1740-
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/61017
1740+
});
17411741

17421742
test('TextHeightBehavior with strut on empty paragraph', () {
17431743
// Regression test for https://github.com/flutter/flutter/issues/112123

0 commit comments

Comments
 (0)