Skip to content

Comments

DaemonCompiler: do not omit main parameter name in C#1506

Merged
illwieckz merged 1 commit intomasterfrom
illwieckz/no-omit-parameter
Jan 20, 2025
Merged

DaemonCompiler: do not omit main parameter name in C#1506
illwieckz merged 1 commit intomasterfrom
illwieckz/no-omit-parameter

Conversation

@illwieckz
Copy link
Member

@illwieckz illwieckz commented Jan 17, 2025

Do not omit main parameter name in C.

Fixes #1505:

This produced those errors:

../../daemon/cmake/DaemonCompiler/DaemonCompiler.c:163:13: error: parameter name omitted
int main(int, char**) {
            ^
../../daemon/cmake/DaemonCompiler/DaemonCompiler.c:163:21: error: parameter name omitted
int main(int, char**) {
                    ^
7 warnings and 2 errors generated.

Actually my first implementation of parsing the output of cc -dM -E could not be subject to that (no compilation was involved at all).

@illwieckz illwieckz mentioned this pull request Jan 17, 2025
Closed
@illwieckz illwieckz force-pushed the illwieckz/no-omit-parameter branch from 0ae6914 to 92aed4d Compare January 17, 2025 05:35
VReaperV
VReaperV approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@VReaperV VReaperV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slipher
Copy link
Member

slipher commented Jan 17, 2025

Why not use the int main() no-arg variant? Then you can be sure not to get trolled by unused argument warnings.

@illwieckz
Copy link
Member Author

illwieckz commented Jan 20, 2025

Why not use the int main() no-arg variant? Then you can be sure not to get trolled by unused argument warnings.

I have no opinion on this. If it is preferred at some point we can do that too, but right now it works so let's consider it fine.

Also the int main(int argc, char** argv) variant is now used for years in the DæmonArchitecture code so let's stick to that for now.

@illwieckz illwieckz merged commit 0bdb698 into master Jan 20, 2025
9 checks passed
@illwieckz illwieckz deleted the illwieckz/no-omit-parameter branch January 20, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VReaperV VReaperV VReaperV approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiler detection is flaky and spews errors

3 participants

@illwieckz @slipher @VReaperV