Skip to content

Comments

cmake: do not use space in compiler string definition, it is not compatible with the standalone MinGW for Windows#1500

Merged
illwieckz merged 1 commit intomasterfrom
illwieckz/fix-cmd-mingw
Jan 20, 2025
Merged

cmake: do not use space in compiler string definition, it is not compatible with the standalone MinGW for Windows#1500
illwieckz merged 1 commit intomasterfrom
illwieckz/fix-cmd-mingw

Conversation

@illwieckz
Copy link
Member

Do not use space in compiler string definition, it is not compatible with the standalone MinGW for Windows.

Fix #1497:

- do not use space in compiler string definition, it is not compatible with the standalone MinGW for Windows
- easier way to check for a compiler
- fix PCH
- fix Zig build
- unify sub-compiler version separator and name with compiler ones
- also log compiler sub-command
@illwieckz illwieckz force-pushed the illwieckz/fix-cmd-mingw branch 2 times, most recently from ca3634a to 08bdf0d Compare January 20, 2025 02:57
@illwieckz
Copy link
Member Author

I also added patch to fix PCH build:

And some other touch-ups.

@illwieckz illwieckz force-pushed the illwieckz/fix-cmd-mingw branch 3 times, most recently from 6a1a299 to 37b86cd Compare January 20, 2025 09:28
@illwieckz
Copy link
Member Author

Delaying the merge of this just makes every commit merged between the original merge and those fix-ups harder to bisect, so I just merge this.

@illwieckz illwieckz merged commit 45d6aa1 into master Jan 20, 2025
9 checks passed
@illwieckz illwieckz deleted the illwieckz/fix-cmd-mingw branch January 20, 2025 10:22
@illwieckz illwieckz restored the illwieckz/fix-cmd-mingw branch January 20, 2025 10:22
@illwieckz illwieckz deleted the illwieckz/fix-cmd-mingw branch January 20, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant