I don't see the global flag in the constructor on u_UnprojectMatrix. (Maybe we should delete the liquid shader so we don't have to discuss that...)

I don't see the global flag in the constructor on u_UnprojectMatrix.

Indeed. I have made it global now.

(Maybe we should delete the liquid shader so we don't have to discuss that...)

Then how would we render water?

We want water to be fixed, not NUKED:

• water shader is broken #645

LGTM

(Maybe we should delete the liquid shader so we don't have to discuss that...)

Then how would we render water?

What do you mean? We don't have any assets using that shader so everything would continue working as before.

We want water to be fixed, not NUKED:

* [water shader is broken #645](https://github.com/DaemonEngine/Daemon/issues/645)

Then the issue can have a pointer to the old version of the code, if indeed it would be useful. Meanwhile we can delete it so it is not a drag on development, what with having to migrate APIs, fix GLSL compile errors, etc. in the dead code.

Water is basically a variant of both the heatHaze code and the mirror code, so 99% of the code is already there. And the missing 1% is things that had been broken when refactoring other things because we had no asset to test it.

We have a test map: https://github.com/UnvanquishedAssets/UnvanquishedTestAssets/tree/master/pkg/map-test-water_src.dpkdir

And the code is there, probably complete or near to be. The water code was never removed.

Some tremulous maps have water. https://users.unvanquished.net/~sweet/pkg/map-citadel_0%2B0.dpk IIRC uses the water shader.

Anyway, if someone has more comments on liquid shaders, please make those in the relevant issues.