Updated Project Build Scripts and Visual Studio Build#9
Conversation
…asier; Upgraded netframework to .net 4.5 since Dnn is using 4.5; Updated all DotNetNuke references to use NuGet instead of local dnn instance; Updated bin director to be local instead of using dnn instance - bin/release and bin/debug; Added MSBuild Tasks NuGet so it is not dependent on the Tests tasks
|
I love it, I have been trying to do the same on all modules I have touched. I will test and merge soon. I have no experience with appveyor, does the organization have access to that free, or is it tied to a user account, how does that work? Would be nice to implement on the other modules too. |
|
We should be able to set something up pretty easy that is linked right to this repo. AppVeyor offers free builds for anyone building open source software. For the small modules such as this I think it is a great way to get a simple build running on Pull Requests. Some Options:
I really don't think it matters either way and I would just go with option 1 for now and iterated on it over time. Let me know if there is anything else you need me to do on this |
EPTamminga
left a comment
EPTamminga
left a comment
There was a problem hiding this comment.
I think this is good to go.
|
@EPTamminga @valadas Did anyone try building this locally? I think there may be an issue with the BuildScripts folder that was hidden by the Visual Studio Cache. I started running into some issues this morning when I tried making some changes |
|
@ahoefling Yeah, it is looking for the msbuild dll in the wrong folder, let me fix that... |
|
Fixed and merged with #13 |
3 participants
Updated Build Scripts to decouple the project from a Dnn Installation. Building within a Dnn Installation is an older way of module development. Most developer prefer to keep their module development decoupled. This change also makes it easier for developers to make more changes to this module since they can just download the source code and build.
Changes made
PR Template Checklist
Testing
After making these changes and getting it to build I was able to take the install file generated and install the module into a Dnn Sandbox Instance I have running Dnn v9.2
Follow Up
Since we have isolated the build from a Dnn Installation. If this Pull Request is approved we could easily set up an AppVeyor build to certify Pull Requests.