Skip to content

Allows giving a custom name to the Survey results page#71

Merged
valadas merged 3 commits into
DNNCommunity:developfrom
MaiklT:fix-63
Jun 13, 2023
Merged

Allows giving a custom name to the Survey results page#71
valadas merged 3 commits into
DNNCommunity:developfrom
MaiklT:fix-63

Conversation

@MaiklT

@MaiklT MaiklT commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

Changes made

Added keys to Resource files for control titles and module help, added messages to controls to display a link to the documentation

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other

Please mark which issue is solved

Close #63

@valadas valadas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one piece of text is not english...

<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="ControlTitle_surveyresults.text" xml:space="preserve">
<value>Ergebnisse</value>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would should be english

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it and commited it directly to the pull request.

Corrected a value in the resource file that was in German for some reason (in fact to test ist, but forgot to turn it back to English...)
@MaiklT MaiklT added this to the 9.2.0 milestone Jun 13, 2023

@valadas valadas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@valadas valadas changed the title Fix 63 Allows giving a custom name to the Survey results page Jun 13, 2023
@valadas valadas added the enhancement New feature or request label Jun 13, 2023
@valadas
valadas merged commit 8eb5d91 into DNNCommunity:develop Jun 13, 2023
@MaiklT
MaiklT deleted the fix-63 branch July 9, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot give a custom name to the Survey results page

2 participants