Add test in case of the settings isn't set due to module upgrade#59
Merged
valadas merged 1 commit intoDec 8, 2023
Merged
Conversation
valadas
changed the title
Member
|
@stetard I read the whole PR, I see a lot of refactoring but not seeing any meaningful change, did I miss something, can you point me to the line number where the fix starts? |
Member
|
Oh, I reread and found it, merging. |
Contributor
Author
|
OK Daniel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57
Just add a test in case of the setting doesn't exist in the database.
It could occurs on old Repository modules after an upgrade.
PR Template Checklist
Please mark which issue is solved
Close #57