Change to portability for merging to prevent duplicate links on import.#2
Closed
JoshuaBradley wants to merge 2 commits into
Closed
Change to portability for merging to prevent duplicate links on import.#2JoshuaBradley wants to merge 2 commits into
JoshuaBradley wants to merge 2 commits into
Conversation
Member
|
I did not notice this pull request before I rewrote the whole module, so I included this in my rewrite, it will be included in 7.0.0 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of just inserting all new links and having the possibility of duplicates after import, I added some logic to check if that link existed based on Title and Url and if it did, we will delete it and then re-insert the new one in case the settings are different. This was a change that I needed to make for Server to Server portability. I don't see this ever happening on Portal importing, but this could happen on Module importing as well. Feel free to email me at [email protected], or reach out on Twitter @JRBradley1