Skip to content

Added an option to export system fields #90

Merged
valadas merged 2 commits into
DNNCommunity:developmentfrom
ufoloko:development
Feb 28, 2021
Merged

Added an option to export system fields #90
valadas merged 2 commits into
DNNCommunity:developmentfrom
ufoloko:development

Conversation

@ufoloko

@ufoloko ufoloko commented Feb 26, 2021

Copy link
Copy Markdown
Contributor

I have added an option to export system fields #16

@valadas valadas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just one little thing that came to mind about the format of the date and time...

Comment thread ExportCSV.ascx.cs Outdated
@ufoloko

ufoloko commented Feb 26, 2021

Copy link
Copy Markdown
Contributor Author

You are welcome, let me know if you want to change the format to commit another change

Ready, changed the format suggested
@ufoloko

ufoloko commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

Ready, i have placed the format suggested.

@valadas valadas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, that looks good to me !

@valadas

valadas commented Feb 28, 2021

Copy link
Copy Markdown
Member

By the way, I highly suggest you create a branch for your changes for PRs instead of doing it on your develop branch. Sometimes PRs can be pending for a while and that way it allows you do do other stuff to not have you develop branch waiting for a merge... But that's just an advice for you, it is totally fine for merging here...

@valadas
valadas merged commit d305f51 into DNNCommunity:development Feb 28, 2021
@valadas

valadas commented Feb 28, 2021

Copy link
Copy Markdown
Member

Oh and one final small note, if you use a specific syntax for the issue you refer to in the PR comment, it can auto-close the issue upon merge. There are multiple of these keywords you can use and you can see them all here https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

I usually do Closes #16

@valadas valadas added this to the 6.5.6 milestone Feb 28, 2021
@ufoloko

ufoloko commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

Ok, just like I said, I'm new with this repo but I will try to do what you suggest for next changes.

@ufoloko

ufoloko commented Oct 21, 2022

Copy link
Copy Markdown
Contributor Author

Hi Valadas, do you have a date to release a new version with recent merges ?

@valadas valadas modified the milestones: 6.5.6, 6.5.8 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants