Fixes a wrong project import and removes telerik reference.#79
Merged
Conversation
The module project did not load in visual studio due to the project file trying to load MsBuild.Community.Tasks before a nuget restore happened. Although this module was already telerik free, there was still a project reference to telerik.web.ui.dll This does not really affect the build and is just a cleanup for next release.
david-poindexter
approved these changes
Nov 18, 2020
david-poindexter
left a comment
david-poindexter
left a comment
Contributor
There was a problem hiding this comment.
Looks good - thank you for doing this @valadas 🎉
Contributor
|
@SCullman I did not merge this PR because I wasn't quite sure your preferred workflow for releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module project did not load in visual studio due to the project file trying to load MsBuild.Community.Tasks before a nuget restore happened.
Although this module was already telerik free, there was still a project reference to telerik.web.ui.dll
This does not really affect the build and is just a cleanup for next release.