Skip to content

Removed placeholders from FeedbackInfo#73

Merged
david-poindexter merged 1 commit into
DNNCommunity:masterfrom
valadas:feedbackInfo-no-placeholders
Oct 14, 2025
Merged

Removed placeholders from FeedbackInfo#73
david-poindexter merged 1 commit into
DNNCommunity:masterfrom
valadas:feedbackInfo-no-placeholders

Conversation

@valadas

@valadas valadas commented Oct 14, 2025

Copy link
Copy Markdown
Member

Placeholders were added in #70
These do not exist in each feedback in the database causing huge logs and not working. These are settings only for the form unless the database is also updated to store them for each feedback entry.

Closes #74

Placeholders were added in DNNCommunity#70
These do not exist in each feedback in the database causing huge logs and not working. These are settings only for the form unless the database is also updated to store them for each feedback entry.
@valadas valadas added this to the 6.8.1 milestone Oct 14, 2025
@valadas valadas added the bug label Oct 14, 2025

@david-poindexter david-poindexter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you for the contribution @valadas 🎉

@david-poindexter
david-poindexter merged commit 58e0b42 into DNNCommunity:master Oct 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After PR #70 logs are full of errors with a missing sql field on SubjectPlacehold and others

2 participants