7.1.1#9
Merged
Merged
Conversation
added 3 commits
December 18, 2018 15:28
Implemented a Rolename check to not add a role if the role name is null or empty.
Updated the logic to pull owner and superuser data to lists, compare and remove data if its a duplicate owner and load the data into the owner dropdown.
Contributor
Author
|
Changes Included Updated the logic to pull owner and superuser data to lists, compare and remove data if its a duplicate owner and load the data into the owner dropdown. Testing Steps |
added 2 commits
May 9, 2019 14:45
Improved the method further to updating the logic and checking if any SuperAdmins were loaded.
Reverted code to original state removed, removed super host call and appending to dropdown, updated first datasource call to use GetUsers of Null and implemented Distinct to remove duplicates.
mitchelsellers
approved these changes
May 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Included
Implemented a Rolename check to not add a role if the role name is null or empty.
Testing Steps
Create a new folder thru FileManager in DNN 9 instance
Install DNN Documents module.
Add a new file and place it in the new folder
You should not be receiving the following error when updating:
Error: is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Item has already been added. Key in dictionary: '' Key being added: '' ---> System.ArgumentException: Item has already been added. Key in dictionary: '' Key being added: '' at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add) at DotNetNuke.Modules.Documents.EditDocs.CheckRolesMatch(ModulePermissionCollection ModuleRoles, FolderPermissionCollection FileRoles) at DotNetNuke.Modules.Documents.EditDocs.CheckFileSecurity(String Url) at DotNetNuke.Modules.Documents.EditDocs.Update(Boolean Override) --- End of inner exception stack trace ---